From: Daniel Vetter Subject: Re: [RFC][PATCH 6/8] drm/i915: Remove intel_crtc->new_config pointer Date: Mon, 8 Dec 2014 17:36:10 +0100 Message-ID: <20141208163610.GC27182@phenom.ffwll.local> References: <1418052069-14831-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1418052069-14831-7-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 708946E858 for ; Mon, 8 Dec 2014 08:35:37 -0800 (PST) Received: by mail-wg0-f43.google.com with SMTP id l18so6679545wgh.16 for ; Mon, 08 Dec 2014 08:35:36 -0800 (PST) Content-Disposition: inline In-Reply-To: <1418052069-14831-7-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBEZWMgMDgsIDIwMTQgYXQgMDU6MjE6MDdQTSArMDIwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFRoZXJlIGFyZSBubyBtb3JlIHVzZXJzIG9mIHRoYXQgcG9p bnRlciBzaW5jZSB0aGUgbmV3IGNvbmZpZyBpcyBub3cKPiBwYXNzZWQgZG93biB0aGUgY2FsbCBj aGFpbiBkdXJpbmcgbW9kZSBzZXQuIEFsc28sIHdoZW4gdGhlIHN3aXRjaCB0bwo+IGF0b21pYyBo YXBwZW5zLCB0aGUgcmlnaHQgY29uZmlnIChzdGF0ZSkgc2hvdWxkIGJlIGRlcml2ZWQgZnJvbSBh bgo+IGF0b21pYyBzdGF0ZSBzdHJ1Y3R1cmUuCgpBaCwgZG9lc24ndCBzZWVtIG11Y2ggd29yayBh Y3R1YWxseSB0byByZW1vdmUgb3VyIHVzYWdlIG9mIC0+bmV3X2NvbmZpZy4KV2hpY2ggaXMgbmlj ZSBzaW5jZSBpdCdsbCBhbGlnbiB1cyBtb3JlIHdpdGggaG93IHRoZSBoZWxwZXJzIHdvcmsuCgpT byBvdmVyYWxsIEkgdGhpbmsgdGhpcyBwYXRjaCBzZXJpZXMgaXMgZ29vZCB0byBnbyAoYnV0IEkn dmUgZG9uZSBvbmx5IGEKcmF0aGVyIGN1cnNvcnkgaGlnaC1sZXZlbCByZWFkaW5nKS4KClRoYW5r cywgRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg fCA0NiArKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgIDEgLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDEwIGlu c2VydGlvbnMoKyksIDM3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiBpbmRleCBhOWYzMDM0Li5hMDMyYTFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC04NTgzLDcgKzg1ODMsNiBAQCByZXRyeToKPiAgCj4gIAlp bnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjKTsKPiAgCWludGVsX2NydGMtPm5ld19lbmFi bGVkID0gdHJ1ZTsKPiAtCWludGVsX2NydGMtPm5ld19jb25maWcgPSAmaW50ZWxfY3J0Yy0+Y29u ZmlnOwo+ICAJb2xkLT5kcG1zX21vZGUgPSBjb25uZWN0b3ItPmRwbXM7Cj4gIAlvbGQtPmxvYWRf ZGV0ZWN0X3RlbXAgPSB0cnVlOwo+ICAJb2xkLT5yZWxlYXNlX2ZiID0gTlVMTDsKPiBAQCAtODYy MywxMCArODYyMiw2IEBAIHJldHJ5Ogo+ICAKPiAgIGZhaWw6Cj4gIAlpbnRlbF9jcnRjLT5uZXdf ZW5hYmxlZCA9IGNydGMtPmVuYWJsZWQ7Cj4gLQlpZiAoaW50ZWxfY3J0Yy0+bmV3X2VuYWJsZWQp Cj4gLQkJaW50ZWxfY3J0Yy0+bmV3X2NvbmZpZyA9ICZpbnRlbF9jcnRjLT5jb25maWc7Cj4gLQll bHNlCj4gLQkJaW50ZWxfY3J0Yy0+bmV3X2NvbmZpZyA9IE5VTEw7Cj4gIGZhaWxfdW5sb2NrOgo+ ICAJaWYgKHJldCA9PSAtRURFQURMSykgewo+ICAJCWRybV9tb2Rlc2V0X2JhY2tvZmYoY3R4KTsK PiBAQCAtODY1Myw3ICs4NjQ4LDYgQEAgdm9pZCBpbnRlbF9yZWxlYXNlX2xvYWRfZGV0ZWN0X3Bp cGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQl0b19pbnRlbF9jb25uZWN0 b3IoY29ubmVjdG9yKS0+bmV3X2VuY29kZXIgPSBOVUxMOwo+ICAJCWludGVsX2VuY29kZXItPm5l d19jcnRjID0gTlVMTDsKPiAgCQlpbnRlbF9jcnRjLT5uZXdfZW5hYmxlZCA9IGZhbHNlOwo+IC0J CWludGVsX2NydGMtPm5ld19jb25maWcgPSBOVUxMOwo+ICAJCWludGVsX3NldF9tb2RlKGNydGMs IE5VTEwsIDAsIDAsIE5VTEwpOwo+ICAKPiAgCQlpZiAob2xkLT5yZWxlYXNlX2ZiKSB7Cj4gQEAg LTk4MzksMTQgKzk4MzMsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tb2Rlc2V0X3VwZGF0ZV9zdGFn ZWRfb3V0cHV0X3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIAkJCXRvX2ludGVsX2Ny dGMoZW5jb2Rlci0+YmFzZS5jcnRjKTsKPiAgCX0KPiAgCj4gLQlmb3JfZWFjaF9pbnRlbF9jcnRj KGRldiwgY3J0Yykgewo+ICsJZm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGNydGMpCj4gIAkJY3J0 Yy0+bmV3X2VuYWJsZWQgPSBjcnRjLT5iYXNlLmVuYWJsZWQ7Cj4gLQo+IC0JCWlmIChjcnRjLT5u ZXdfZW5hYmxlZCkKPiAtCQkJY3J0Yy0+bmV3X2NvbmZpZyA9ICZjcnRjLT5jb25maWc7Cj4gLQkJ ZWxzZQo+IC0JCQljcnRjLT5uZXdfY29uZmlnID0gTlVMTDsKPiAtCX0KPiAgfQo+ICAKPiAgLyoq Cj4gQEAgLTEwMzU1LDEyICsxMDM0Myw4IEBAIGludGVsX21vZGVzZXRfdXBkYXRlX3N0YXRlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHVuc2lnbmVkIHByZXBhcmVfcGlwZXMpCj4gIAlpbnRlbF9t b2Rlc2V0X2NvbW1pdF9vdXRwdXRfc3RhdGUoZGV2KTsKPiAgCj4gIAkvKiBEb3VibGUgY2hlY2sg c3RhdGUuICovCj4gLQlmb3JfZWFjaF9pbnRlbF9jcnRjKGRldiwgaW50ZWxfY3J0Yykgewo+ICsJ Zm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGludGVsX2NydGMpCj4gIAkJV0FSTl9PTihpbnRlbF9j cnRjLT5iYXNlLmVuYWJsZWQgIT0gaW50ZWxfY3J0Y19pbl91c2UoJmludGVsX2NydGMtPmJhc2Up KTsKPiAtCQlXQVJOX09OKGludGVsX2NydGMtPm5ld19jb25maWcgJiYKPiAtCQkJaW50ZWxfY3J0 Yy0+bmV3X2NvbmZpZyAhPSAmaW50ZWxfY3J0Yy0+Y29uZmlnKTsKPiAtCQlXQVJOX09OKGludGVs X2NydGMtPmJhc2UuZW5hYmxlZCAhPSAhIWludGVsX2NydGMtPm5ld19jb25maWcpOwo+IC0JfQo+ ICAKPiAgCWxpc3RfZm9yX2VhY2hfZW50cnkoY29ubmVjdG9yLCAmZGV2LT5tb2RlX2NvbmZpZy5j b25uZWN0b3JfbGlzdCwgaGVhZCkgewo+ICAJCWlmICghY29ubmVjdG9yLT5lbmNvZGVyIHx8ICFj b25uZWN0b3ItPmVuY29kZXItPmNydGMpCj4gQEAgLTEwOTU3LDkgKzEwOTQxLDYgQEAgc3RhdGlj IGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCj4gIAkqc2F2 ZWRfbW9kZSA9IGNydGMtPm1vZGU7Cj4gIAo+IC0JaWYgKG1vZGVzZXRfcGlwZXMpCj4gLQkJdG9f aW50ZWxfY3J0YyhjcnRjKS0+bmV3X2NvbmZpZyA9IHBpcGVfY29uZmlnOwo+IC0KPiAgCS8qCj4g IAkgKiBTZWUgaWYgdGhlIGNvbmZpZyByZXF1aXJlcyBhbnkgYWRkaXRpb25hbCBwcmVwYXJhdGlv biwgZS5nLgo+ICAJICogdG8gYWRqdXN0IGdsb2JhbCBzdGF0ZSB3aXRoIHBpcGVzIG9mZi4gIFdl IG5lZWQgdG8gZG8gdGhpcwo+IEBAIC0xMDk4NCw3ICsxMDk2NSwxMyBAQCBzdGF0aWMgaW50IF9f aW50ZWxfc2V0X21vZGUoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJCQlnb3RvIGRvbmU7Cj4g IAo+ICAJCWZvcl9lYWNoX2ludGVsX2NydGNfbWFza2VkKGRldiwgbW9kZXNldF9waXBlcywgaW50 ZWxfY3J0Yykgewo+IC0JCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqc3RhdGUgPSBpbnRlbF9j cnRjLT5uZXdfY29uZmlnOwo+ICsJCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqc3RhdGU7Cj4g Kwo+ICsJCQlpZiAoJmludGVsX2NydGMtPmJhc2UgPT0gY3J0YykKPiArCQkJCXN0YXRlID0gcGlw ZV9jb25maWc7Cj4gKwkJCWVsc2UKPiArCQkJCXN0YXRlID0gaW50ZWxfY3J0Yy0+Y29uZmlnOwo+ ICsKPiAgCQkJcmV0ID0gZGV2X3ByaXYtPmRpc3BsYXkuY3J0Y19jb21wdXRlX2Nsb2NrKGludGVs X2NydGMsCj4gIAkJCQkJCQkJICAgc3RhdGUpOwo+ICAJCQlpZiAocmV0KSB7Cj4gQEAgLTExMDE0 LDcgKzExMDAxLDYgQEAgc3RhdGljIGludCBfX2ludGVsX3NldF9tb2RlKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YywKPiAgCQkvKiBtb2RlX3NldC9lbmFibGUvZGlzYWJsZSBmdW5jdGlvbnMgcmVseSBv biBhIGNvcnJlY3QgcGlwZQo+ICAJCSAqIGNvbmZpZy4gKi8KPiAgCQl0b19pbnRlbF9jcnRjKGNy dGMpLT5jb25maWcgPSAqcGlwZV9jb25maWc7Cj4gLQkJdG9faW50ZWxfY3J0YyhjcnRjKS0+bmV3 X2NvbmZpZyA9ICZ0b19pbnRlbF9jcnRjKGNydGMpLT5jb25maWc7Cj4gIAo+ICAJCS8qCj4gIAkJ ICogQ2FsY3VsYXRlIGFuZCBzdG9yZSB2YXJpb3VzIGNvbnN0YW50cyB3aGljaAo+IEBAIC0xMTE3 NywxNSArMTExNjMsOSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zZXRfY29uZmlnX3Jlc3RvcmVfc3Rh dGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCWludCBjb3VudDsKPiAgCj4gIAljb3VudCA9 IDA7Cj4gLQlmb3JfZWFjaF9pbnRlbF9jcnRjKGRldiwgY3J0Yykgewo+ICsJZm9yX2VhY2hfaW50 ZWxfY3J0YyhkZXYsIGNydGMpCj4gIAkJY3J0Yy0+bmV3X2VuYWJsZWQgPSBjb25maWctPnNhdmVf Y3J0Y19lbmFibGVkW2NvdW50KytdOwo+ICAKPiAtCQlpZiAoY3J0Yy0+bmV3X2VuYWJsZWQpCj4g LQkJCWNydGMtPm5ld19jb25maWcgPSAmY3J0Yy0+Y29uZmlnOwo+IC0JCWVsc2UKPiAtCQkJY3J0 Yy0+bmV3X2NvbmZpZyA9IE5VTEw7Cj4gLQl9Cj4gLQo+ICAJY291bnQgPSAwOwo+ICAJZm9yX2Vh Y2hfaW50ZWxfZW5jb2RlcihkZXYsIGVuY29kZXIpIHsKPiAgCQllbmNvZGVyLT5uZXdfY3J0YyA9 Cj4gQEAgLTExMzkxLDExICsxMTM3MSw2IEBAIGludGVsX21vZGVzZXRfc3RhZ2Vfb3V0cHV0X3N0 YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCQkgICAgICBjcnRjLT5uZXdfZW5hYmxl ZCA/ICJlbiIgOiAiZGlzIik7Cj4gIAkJCWNvbmZpZy0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsKPiAg CQl9Cj4gLQo+IC0JCWlmIChjcnRjLT5uZXdfZW5hYmxlZCkKPiAtCQkJY3J0Yy0+bmV3X2NvbmZp ZyA9ICZjcnRjLT5jb25maWc7Cj4gLQkJZWxzZQo+IC0JCQljcnRjLT5uZXdfY29uZmlnID0gTlVM TDsKPiAgCX0KPiAgCj4gIAlyZXR1cm4gMDsKPiBAQCAtMTE0MjIsNyArMTEzOTcsNiBAQCBzdGF0 aWMgdm9pZCBkaXNhYmxlX2NydGNfbm9mYihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCX0K PiAgCj4gIAljcnRjLT5uZXdfZW5hYmxlZCA9IGZhbHNlOwo+IC0JY3J0Yy0+bmV3X2NvbmZpZyA9 IE5VTEw7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgaW50ZWxfY3J0Y19zZXRfY29uZmlnKHN0cnVj dCBkcm1fbW9kZV9zZXQgKnNldCkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDBh ODQ2NjcuLjE3NWI4NTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC00NDAs NyArNDQwLDYgQEAgc3RydWN0IGludGVsX2NydGMgewo+ICAKPiAgCXN0cnVjdCBpbnRlbF9wbGFu ZV9jb25maWcgcGxhbmVfY29uZmlnOwo+ICAJc3RydWN0IGludGVsX2NydGNfc3RhdGUgY29uZmln Owo+IC0Jc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jb25maWc7Cj4gIAlib29sIG5ld19l bmFibGVkOwo+ICAKPiAgCS8qIHJlc2V0IGNvdW50ZXIgdmFsdWUgd2hlbiB0aGUgbGFzdCBmbGlw IHdhcyBzdWJtaXR0ZWQgKi8KPiAtLSAKPiAxLjkuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IElu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2Fy ZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=