From: Daniel Vetter Subject: Re: [PATCH 5/5] drm/i915: Make i915_pipe_crc_read() oops proof Date: Wed, 10 Dec 2014 11:00:02 +0100 Message-ID: <20141210100002.GI27182@phenom.ffwll.local> References: <1418153312-25319-1-git-send-email-ville.syrjala@linux.intel.com> <1418153312-25319-6-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A81C6E35C for ; Wed, 10 Dec 2014 01:59:29 -0800 (PST) Received: by mail-wi0-f174.google.com with SMTP id h11so10631561wiw.1 for ; Wed, 10 Dec 2014 01:59:28 -0800 (PST) Content-Disposition: inline In-Reply-To: <1418153312-25319-6-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBEZWMgMDksIDIwMTQgYXQgMDk6Mjg6MzJQTSArMDIwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBDdXJyZW50bHkgaTkxNV9waXBlX2NyY19yZWFkKCkg d2lsbCBkcm9wIHBpcGVfY3JjLT5sb2NrIGZvciB0aGUgZW50aXJlCj4gZHVyYXRpb24gb2YgdGhl IGNvcHlfdG9fdXNlcigpIGxvb3AsIHdoaWNoIG1lYW5zIGl0J2xsIGFjY2Vzcwo+IHBpcGVfY3Jj LT5lbnRyaWVzIHdpdGhvdXQgYW55IHByb3RlY3Rpb24uIElmIGFub3RoZXIgdGhyZWFkIHNuZWFr cyBpbgo+IGFuZCBmcmVlcyBwaXBlX2NyYy0+ZW50cmllcyB0aGUgY29kZSB3aWxsIG9vcHMuCj4g Cj4gUmVvcmdhbml6ZSB0aGUgY29kZSB0byBob2xkIHRoZSBsb2NrIGFyb3VuZCBldmVyeXRoaW5n IGV4Y2VwdAo+IGNvcHlfdG9fdXNlcigpLiBBZnRlciB0aGUgY29weSB0aGUgbG9jayBpcyByZWFj cXVpcmVkIGFuZCB0aGUgdGhlIG51bWJlcgo+IG9mIGF2YWlsYWJsZSBlbnRyaWVzIGlzIHJlY2hl Y2tlZC4KPiAKPiBTaW5jZSB0aGlzIGlzIGEgZGVidWcgZmVhdHVyZSBzaW1wbGlmeSB0aGUgZXJy b3IgaGFuZGxpbmcgYSBiaXQgYnkKPiBjb25zdW1pbmcgdGhlIGNyYyBlbnRyeSBldmVuIGlmIGNv cHlfdG9fdXNlcigpIHdvdWxkIGZhaWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCldoaWxlIHlvdSBnbyB0byBhbGwg dGhpcyB0cm91YmxlIHdpdGggbWFraW5nIHRoZSBkZWJ1Z2ZzIGludGVyZmFjZSBzYWZlCmFnYWlu c3Qgc3R1cGlkIHVzZXJzcGFjZTogc2V0X3NvdXJjZSBoYXMgYSBwb3RlbnRpYWwgbGVhayB3aGVu IC0+ZW50cmllcwppcyBhbHJlYWR5IGFsbG9jYXRlZCB3aGVuIHdlIHNldCBpdC4gQW4gdW5jb25k aXRpb25hbAprZnJlZShwaXBlX2NyYy0+ZW50cmllcyk7IGJlZm9yZSBzaG91bGQgYmUgYWxsIHdl IG5lZWQgc2luY2Uga2ZyZWUgY2FuCmhhbmRsZSB0aGlzLiBJJ2xsIHNtYXNoIGEgcGF0Y2ggb24g dG9wLgoKRW50aXJlIHNlcmllcyBtZXJnZWQsIHRoYW5rcy4KLURhbmllbAoKPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgfCAzOSArKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAx NyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4 IGQ5ZDVmMWYuLjFjNjE1NjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ IEBAIC0yODU4LDcgKzI4NTgsNyBAQCBpOTE1X3BpcGVfY3JjX3JlYWQoc3RydWN0IGZpbGUgKmZp bGVwLCBjaGFyIF9fdXNlciAqdXNlcl9idWYsIHNpemVfdCBjb3VudCwKPiAgCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gIAlzdHJ1Y3QgaW50 ZWxfcGlwZV9jcmMgKnBpcGVfY3JjID0gJmRldl9wcml2LT5waXBlX2NyY1tpbmZvLT5waXBlXTsK PiAgCWNoYXIgYnVmW1BJUEVfQ1JDX0JVRkZFUl9MRU5dOwo+IC0JaW50IGhlYWQsIHRhaWwsIG5f ZW50cmllcywgbjsKPiArCWludCBuX2VudHJpZXM7Cj4gIAlzc2l6ZV90IGJ5dGVzX3JlYWQ7Cj4g IAo+ICAJLyoKPiBAQCAtMjg5MCwzNiArMjg5MCwzOSBAQCBpOTE1X3BpcGVfY3JjX3JlYWQoc3Ry dWN0IGZpbGUgKmZpbGVwLCBjaGFyIF9fdXNlciAqdXNlcl9idWYsIHNpemVfdCBjb3VudCwKPiAg CX0KPiAgCj4gIAkvKiBXZSBub3cgaGF2ZSBvbmUgb3IgbW9yZSBlbnRyaWVzIHRvIHJlYWQgKi8K PiAtCWhlYWQgPSBwaXBlX2NyYy0+aGVhZDsKPiAtCXRhaWwgPSBwaXBlX2NyYy0+dGFpbDsKPiAt CW5fZW50cmllcyA9IG1pbigoc2l6ZV90KUNJUkNfQ05UKGhlYWQsIHRhaWwsIElOVEVMX1BJUEVf Q1JDX0VOVFJJRVNfTlIpLAo+IC0JCQljb3VudCAvIFBJUEVfQ1JDX0xJTkVfTEVOKTsKPiAtCXNw aW5fdW5sb2NrX2lycSgmcGlwZV9jcmMtPmxvY2spOwo+ICsJbl9lbnRyaWVzID0gY291bnQgLyBQ SVBFX0NSQ19MSU5FX0xFTjsKPiAgCj4gIAlieXRlc19yZWFkID0gMDsKPiAtCW4gPSAwOwo+IC0J ZG8gewo+IC0JCXN0cnVjdCBpbnRlbF9waXBlX2NyY19lbnRyeSAqZW50cnkgPSAmcGlwZV9jcmMt PmVudHJpZXNbdGFpbF07Cj4gKwl3aGlsZSAobl9lbnRyaWVzID4gMCkgewo+ICsJCXN0cnVjdCBp bnRlbF9waXBlX2NyY19lbnRyeSAqZW50cnkgPQo+ICsJCQkmcGlwZV9jcmMtPmVudHJpZXNbcGlw ZV9jcmMtPnRhaWxdOwo+ICAJCWludCByZXQ7Cj4gIAo+ICsJCWlmIChDSVJDX0NOVChwaXBlX2Ny Yy0+aGVhZCwgcGlwZV9jcmMtPnRhaWwsCj4gKwkJCSAgICAgSU5URUxfUElQRV9DUkNfRU5UUklF U19OUikgPCAxKQo+ICsJCQlicmVhazsKPiArCj4gKwkJQlVJTERfQlVHX09OX05PVF9QT1dFUl9P Rl8yKElOVEVMX1BJUEVfQ1JDX0VOVFJJRVNfTlIpOwo+ICsJCXBpcGVfY3JjLT50YWlsID0gKHBp cGVfY3JjLT50YWlsICsgMSkgJiAoSU5URUxfUElQRV9DUkNfRU5UUklFU19OUiAtIDEpOwo+ICsK PiAgCQlieXRlc19yZWFkICs9IHNucHJpbnRmKGJ1ZiwgUElQRV9DUkNfQlVGRkVSX0xFTiwKPiAg CQkJCSAgICAgICAiJTh1ICU4eCAlOHggJTh4ICU4eCAlOHhcbiIsCj4gIAkJCQkgICAgICAgZW50 cnktPmZyYW1lLCBlbnRyeS0+Y3JjWzBdLAo+ICAJCQkJICAgICAgIGVudHJ5LT5jcmNbMV0sIGVu dHJ5LT5jcmNbMl0sCj4gIAkJCQkgICAgICAgZW50cnktPmNyY1szXSwgZW50cnktPmNyY1s0XSk7 Cj4gIAo+IC0JCXJldCA9IGNvcHlfdG9fdXNlcih1c2VyX2J1ZiArIG4gKiBQSVBFX0NSQ19MSU5F X0xFTiwKPiAtCQkJCSAgIGJ1ZiwgUElQRV9DUkNfTElORV9MRU4pOwo+ICsJCXNwaW5fdW5sb2Nr X2lycSgmcGlwZV9jcmMtPmxvY2spOwo+ICsKPiArCQlyZXQgPSBjb3B5X3RvX3VzZXIodXNlcl9i dWYsIGJ1ZiwgUElQRV9DUkNfTElORV9MRU4pOwo+ICAJCWlmIChyZXQgPT0gUElQRV9DUkNfTElO RV9MRU4pCj4gIAkJCXJldHVybiAtRUZBVUxUOwo+ICAKPiAtCQlCVUlMRF9CVUdfT05fTk9UX1BP V0VSX09GXzIoSU5URUxfUElQRV9DUkNfRU5UUklFU19OUik7Cj4gLQkJdGFpbCA9ICh0YWlsICsg MSkgJiAoSU5URUxfUElQRV9DUkNfRU5UUklFU19OUiAtIDEpOwo+IC0JCW4rKzsKPiAtCX0gd2hp bGUgKC0tbl9lbnRyaWVzKTsKPiArCQl1c2VyX2J1ZiArPSBQSVBFX0NSQ19MSU5FX0xFTjsKPiAr CQluX2VudHJpZXMtLTsKPiArCj4gKwkJc3Bpbl9sb2NrX2lycSgmcGlwZV9jcmMtPmxvY2spOwo+ ICsJfQo+ICAKPiAtCXNwaW5fbG9ja19pcnEoJnBpcGVfY3JjLT5sb2NrKTsKPiAtCXBpcGVfY3Jj LT50YWlsID0gdGFpbDsKPiAgCXNwaW5fdW5sb2NrX2lycSgmcGlwZV9jcmMtPmxvY2spOwo+ICAK PiAgCXJldHVybiBieXRlc19yZWFkOwo+IEBAIC0zNDU2LDYgKzM0NTksOCBAQCBzdGF0aWMgaW50 IHBpcGVfY3JjX3NldF9zb3VyY2Uoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgZW51bSBwaXBlIHBp cGUsCj4gIAkJc3Bpbl9sb2NrX2lycSgmcGlwZV9jcmMtPmxvY2spOwo+ICAJCWVudHJpZXMgPSBw aXBlX2NyYy0+ZW50cmllczsKPiAgCQlwaXBlX2NyYy0+ZW50cmllcyA9IE5VTEw7Cj4gKwkJcGlw ZV9jcmMtPmhlYWQgPSAwOwo+ICsJCXBpcGVfY3JjLT50YWlsID0gMDsKPiAgCQlzcGluX3VubG9j a19pcnEoJnBpcGVfY3JjLT5sb2NrKTsKPiAgCj4gIAkJa2ZyZWUoZW50cmllcyk7Cj4gLS0gCj4g Mi4wLjQKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK