From: Masahiro Yamada <yamada.m@jp.panasonic.com>
Date: Wed, 10 Dec 2014 22:33:06 +0900
Subject: [U-Boot] [PATCH v5 04/11] dm: i2c: Add a sandbox I2C driver
In-Reply-To: <1417793534-31642-5-git-send-email-sjg@chromium.org>
References: <1417793534-31642-1-git-send-email-sjg@chromium.org>
	<1417793534-31642-5-git-send-email-sjg@chromium.org>
Message-ID: <20141210223306.030F.AA925319@jp.panasonic.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Simon,

I forgot to mention a minor issue.


On Fri,  5 Dec 2014 08:32:07 -0700
Simon Glass <sjg@chromium.org> wrote:


> +static int get_emul(struct udevice *bus, uint chip_addr, struct udevice **devp,
> +		    struct dm_i2c_ops **opsp)
> +{
> +	const void *blob = gd->fdt_blob;
> +	struct dm_i2c_chip *priv;
> +	struct udevice *dev;
> +	int ret;
> +
> +	*devp = NULL;
> +	*opsp = NULL;
> +	ret = i2c_get_chip(bus, chip_addr, &dev);
> +	if (ret)
> +		return ret;
> +	priv = dev_get_parentdata(dev);
> +	if (!priv->emul) {
> +		int node;
> +
> +		debug("Scanning i2c bus '%s' for devices\n", dev->name);
> +		for (node = fdt_first_subnode(blob, dev->of_offset);
> +			node >= 0;
> +			node = fdt_next_subnode(blob, node)) {


Can you fix the indent here?



Best Regards
Masahiro Yamada