Received: from eggs.gnu.org ([2001:4830:134:3::10]:51119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0uMl-0004Mw-Jc for qemu-devel@nongnu.org; Tue, 16 Dec 2014 10:48:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0uMf-00026H-Fp for qemu-devel@nongnu.org; Tue, 16 Dec 2014 10:48:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0uMf-000269-8m for qemu-devel@nongnu.org; Tue, 16 Dec 2014 10:48:45 -0500 Date: Tue, 16 Dec 2014 16:48:32 +0100 From: Kevin Wolf Message-ID: <20141216154832.GB3301@noname.str.redhat.com> References: <1418743287-20467-1-git-send-email-pl@kamp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418743287-20467-1-git-send-email-pl@kamp.de> Subject: Re: [Qemu-devel] [PATCH V2 0/4] *virtio-blk: add multiread support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: famz@redhat.com, benoit@irqsave.net, ming.lei@canonical.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, mreitz@redhat.com Am 16.12.2014 um 16:21 hat Peter Lieven geschrieben: > this series adds the long missing multiread support to virtio-blk. > > some remarks: > - i introduced rd_merged and wr_merged block accounting stats to > blockstats as a generic interface which can be set from any > driver that will introduce multirequest merging in the future. > - the knob to disable request merging is not yet there. I would > add it to the device properties also as a generic interface > to have the same switch for any driver that might introduce > request merging in the future. As there has been no knob in > the past I would post this as a seperate series as it needs > some mangling in parameter parsing which might lead to further > discussions. > - the old multiwrite interface is still there and might be removed. > > v1->v2: > - add overflow checking for nb_sectors [Kevin] > - do not change the name of the macro of max mergable requests. [Fam] Diff to v1 looks good. Now I just need to check what it does to the performance. Did you run any benchmarks yourself? Kevin