From: Andi Kleen Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel Date: Mon, 22 Dec 2014 10:49:40 -0800 Message-ID: <20141222184940.GB17192@tassilo.jf.intel.com> References: <1419246673-7222-1-git-send-email-oded.gabbay@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Alex Deucher Cc: Oded Gabbay , Dana Elifaz , LKML , Maling list - DRI developers , Alexander Deucher , LKP ML , rusty@rustcorp.co.au List-Id: dri-devel@lists.freedesktop.org On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote: > On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay wrote: > > amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no > > point in trying to initialize amdkfd in 32-bit kernel. > > > > In addition, in case of specific configuration of 32-bit kernel, no modules and > > random kernel base, the symbol_request function doesn't work as expected - It > > doesn't return NULL if the symbol doesn't exists. That makes the kernel panic. > > Therefore, the as amdkfd doesn't compile in 32-bit kernel, the best way is just > > to return false immediately. > > > > Signed-off-by: Oded Gabbay > > Reviewed-by: Alex Deucher Sorry but the patch is just bogus. X-bit only code is usually a very bad sign for the code. This is not windows programing after all. Even if you wanted to do a 64bit only driver -- which you probably don't -- the standard way would be to exclude it in Kconfig. Please root-cause why symbol_request doesn't work on 32bit and fix it properly. +rusty. -Andi