From: Ben Widawsky Subject: Re: [PATCH i-g-t] tools/intel_gpu_frequency: remove use of getsubopt Date: Thu, 15 Jan 2015 10:28:27 -0800 Message-ID: <20150115182827.GB10003@bwidawsk.net> References: <1421342870-23275-1-git-send-email-tim.gore@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 5923F6E236 for ; Thu, 15 Jan 2015 10:28:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <1421342870-23275-1-git-send-email-tim.gore@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: tim.gore@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMTUsIDIwMTUgYXQgMDU6Mjc6NTBQTSArMDAwMCwgdGltLmdvcmVAaW50ZWwu Y29tIHdyb3RlOgo+IEZyb206IFRpbSBHb3JlIDx0aW0uZ29yZUBpbnRlbC5jb20+Cj4gCj4gZ2V0 c3Vib3B0IGlzIG5vdCBhdmFpbGFibGUgaW4gYW5kcm9pZC4gVGhlICJnZXQiIG9wdGlvbgo+IGRv ZXNuJ3QgcmVhbGx5IG5lZWQgc3ViLW9wdGlvbnMsIGp1c3QgZGlzcGxheSBhbGwgdGhlCj4gY3Vy cmVudCBmcmVxdWVuY3kgc2V0dGluZ3MgKGFzIHBlciBkaXNjdXNzaW9uIHdpdGgKPiBCZW4gV2lk YXdza3kpCj4gCj4gU2lnbmVkLW9mZi1ieTogVGltIEdvcmUgPHRpbS5nb3JlQGludGVsLmNvbT4K PiAtLS0KPiAgbWFuL2ludGVsX2dwdV9mcmVxdWVuY3kubWFuIHwgIDYgKysrLS0tCj4gIHRvb2xz L2ludGVsX2dwdV9mcmVxdWVuY3kuYyB8IDI3ICsrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ICAyIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL21hbi9pbnRlbF9ncHVfZnJlcXVlbmN5Lm1hbiBiL21hbi9pbnRlbF9ncHVf ZnJlcXVlbmN5Lm1hbgo+IGluZGV4IDYwZTRlMGMuLjcxNDQ4NDggMTAwNjQ0Cj4gLS0tIGEvbWFu L2ludGVsX2dwdV9mcmVxdWVuY3kubWFuCj4gKysrIGIvbWFuL2ludGVsX2dwdV9mcmVxdWVuY3ku bWFuCj4gQEAgLTMsNyArMyw3IEBACj4gIGludGVsX2dwdV9mcmVxdWVuY3k6IFwtIG1hbnVhbCBw YWdlIGZvciBpbnRlbF9ncHVfZnJlcXVlbmN5Cj4gIC5TSCBTWU5PUFNJUwo+ICAuQiBpbnRlbF9n cHVfZnJlcXVlbmN5Cj4gLVtcZklcLC1lXC9cZlJdIFtcZklcLC0tbWluIHwgLS1tYXhcL1xmUl0g W1xmSVwsLWcgKG1pbnxtYXh8ZWZmaWNpZW50KVwvXGZSXSBbXGZJXCwtcyBmcmVxdWVuY3lfbWh6 XC9cZlJdCj4gK1tcZklcLC1lXC9cZlJdIFtcZklcLC0tbWluIHwgLS1tYXhcL1xmUl0gW1xmSVws LWdcL1xmUl0gW1xmSVwsLXMgZnJlcXVlbmN5X21oelwvXGZSXQo+ICAuU0ggREVTQ1JJUFRJT04K PiAgXCZBIHByb2dyYW0gdG8gbWFuaXB1bGF0ZSBJbnRlbCBHUFUgZnJlcXVlbmNpZXMuIEludGVs IEdQVXMKPiAgd2lsbCBhdXRvbWF0aWNhbGx5IHRocm90dGxlIHRoZSBmcmVxdWVuY2llcyBiYXNl ZCBvbiBzeXN0ZW0gZGVtYW5kcywgdXAgd2hlbgo+IEBAIC0xOSw4ICsxOSw4IEBAIHNhZmUgYmV0 Lgo+ICBcZkJcLWVcZlIKPiAgTG9jayBmcmVxdWVuY3kgdG8gdGhlIG1vc3QgZWZmaWNpZW50IGZy ZXF1ZW5jeQo+ICAuVFAKPiAtXGZCXC1nXGZSLCBcZkJcLVwtZ2V0PVxmUgo+IC1HZXQgdGhlIGZy ZXF1ZW5jeSBjb21tYSBzZXBhcmF0ZWQgbGlzdCBvZiAoImN1ciJ8Im1pbiJ8Im1heCJ8ImVmZiIp Cj4gK1xmQlwtZ1xmUiwgXGZCXC1cLWdldFxmUgo+ICtHZXQgYWxsIHRoZSBjdXJyZW50IGZyZXF1 ZW5jeSBzZXR0aW5ncwo+ICAuVFAKPiAgXGZCXC1zXGZSLCBcZkJcLVwtc2V0XGZSCj4gIExvY2sg ZnJlcXVlbmN5IHRvIGFuIGFic29sdXRlIHZhbHVlIChNSHopCj4gZGlmZiAtLWdpdCBhL3Rvb2xz L2ludGVsX2dwdV9mcmVxdWVuY3kuYyBiL3Rvb2xzL2ludGVsX2dwdV9mcmVxdWVuY3kuYwo+IGlu ZGV4IGFlZGNlYjQuLjdmODU0MjEgMTAwNjQ0Cj4gLS0tIGEvdG9vbHMvaW50ZWxfZ3B1X2ZyZXF1 ZW5jeS5jCj4gKysrIGIvdG9vbHMvaW50ZWxfZ3B1X2ZyZXF1ZW5jeS5jCj4gQEAgLTE1Miw3ICsx NTIsNyBAQCB1c2FnZShjb25zdCBjaGFyICpwcm9nKQo+ICAJcHJpbnRmKCJVc2FnZTogJXMgWy1l XSBbLS1taW4gfCAtLW1heF0gWy1nIChtaW58bWF4fGVmZmljaWVudCldIFstcyBmcmVxdWVuY3lf bWh6XVxuXG4iLCBwcm9nKTsKPiAgCXByaW50ZigiT3B0aW9uczogXG4iKTsKPiAgCXByaW50Zigi ICAtZQkJTG9jayBmcmVxdWVuY3kgdG8gdGhlIG1vc3QgZWZmaWNpZW50IGZyZXF1ZW5jeVxuIik7 Cj4gLQlwcmludGYoIiAgLWcsIC0tZ2V0PSAgICBHZXQgdGhlIGZyZXF1ZW5jeSAob3B0aW9uYWwg YXJnOiBcImN1clwifFwibWluXCJ8XCJtYXhcInxcImVmZlwiKVxuIik7Cj4gKwlwcmludGYoIiAg LWcsIC0tZ2V0ICAgICBHZXQgYWxsIHRoZSBmcmVxdWVuY3kgc2V0dGluZ3MgKGVnIFwiY3VyXCJ8 XCJtaW5cInxcIm1heFwifFwiZWZmXCIpXG4iKTsKClNob3VsZCBiZQpwcmludGYoIiAgLWcsIC0t Z2V0ICAgICBHZXQgYWxsIHRoZSBmcmVxdWVuY3kgc2V0dGluZ3MpOwoKPiAgCXByaW50ZigiICAt cywgLS1zZXQgICAgIExvY2sgZnJlcXVlbmN5IHRvIGFuIGFic29sdXRlIHZhbHVlIChNSHopXG4i KTsKPiAgCXByaW50ZigiICAtYywgLS1jdXN0b20gIFNldCBhIG1pbiwgb3IgbWF4IGZyZXF1ZW5j eSBcIm1pbj1YIHwgbWF4PVlcIlxuIik7Cj4gIAlwcmludGYoIiAgLW0gIC0tbWF4ICAgICBMb2Nr IGZyZXF1ZW5jeSB0byBtYXggZnJlcXVlbmN5XG4iKTsKPiBAQCAtMTg0LDEzICsxODQsNiBAQCBw YXJzZShpbnQgYXJnYywgY2hhciAqYXJndltdLCBib29sICphY3RfdXBvbiwgc2l6ZV90IGFjdF91 cG9uX24sIGludCAqbmV3X2ZyZXEpCj4gIAlpbnQgYywgdG1wOwo+ICAJYm9vbCB3cml0ZSA9IGZh bHNlOwo+ICAKPiAtCWNoYXIgKnRva2VuW10gPSB7Cj4gLQkJKGNoYXIgKilpbmZvW0NVUl0ubmFt ZSwKPiAtCQkoY2hhciAqKWluZm9bTUlOXS5uYW1lLAo+IC0JCShjaGFyICopImVmZiIsCj4gLQkJ KGNoYXIgKilpbmZvW01BWF0ubmFtZQo+IC0JfTsKPiAtCj4gIAkvKiBObyBhcmdzIG1lYW5zIC1n IiAqLwo+ICAJaWYgKGFyZ2MgPT0gMSkgewo+ICAJCWZvciAoYyA9IDA7IGMgPCBhY3RfdXBvbl9u OyBjKyspCj4gQEAgLTIwMCw3ICsxOTMsNyBAQCBwYXJzZShpbnQgYXJnYywgY2hhciAqYXJndltd LCBib29sICphY3RfdXBvbiwgc2l6ZV90IGFjdF91cG9uX24sIGludCAqbmV3X2ZyZXEpCj4gIAl3 aGlsZSAoMSkgewo+ICAJCWludCBvcHRpb25faW5kZXggPSAwOwo+ICAJCXN0YXRpYyBzdHJ1Y3Qg b3B0aW9uIGxvbmdfb3B0aW9uc1tdID0gewo+IC0JCQl7ICJnZXQiLCBvcHRpb25hbF9hcmd1bWVu dCwgTlVMTCwgJ2cnIH0sCj4gKwkJCXsgImdldCIsIG5vX2FyZ3VtZW50LCBOVUxMLCAnZycgfSwK PiAgCQkJeyAic2V0IiwgcmVxdWlyZWRfYXJndW1lbnQsIE5VTEwsICdzJyB9LAo+ICAJCQl7ICJj dXN0b20iLCByZXF1aXJlZF9hcmd1bWVudCwgTlVMTCwgJ2MnfSwKPiAgCQkJeyAibWluIiwgbm9f YXJndW1lbnQsIE5VTEwsICdpJyB9LAo+IEBAIC0yMTEsNyArMjA0LDcgQEAgcGFyc2UoaW50IGFy Z2MsIGNoYXIgKmFyZ3ZbXSwgYm9vbCAqYWN0X3Vwb24sIHNpemVfdCBhY3RfdXBvbl9uLCBpbnQg Km5ld19mcmVxKQo+ICAJCQl7IE5VTEwsIDAsIE5VTEwsIDB9Cj4gIAkJfTsKPiAgCj4gLQkJYyA9 IGdldG9wdF9sb25nKGFyZ2MsIGFyZ3YsICJlZzo6czpjOm1pZGgiLCBsb25nX29wdGlvbnMsICZv cHRpb25faW5kZXgpOwo+ICsJCWMgPSBnZXRvcHRfbG9uZyhhcmdjLCBhcmd2LCAiZWdzOmM6bWlk aCIsIGxvbmdfb3B0aW9ucywgJm9wdGlvbl9pbmRleCk7Cj4gIAkJaWYgKGMgPT0gLTEpCj4gIAkJ CWJyZWFrOwo+ICAKPiBAQCAtMjE5LDE5ICsyMTIsNyBAQCBwYXJzZShpbnQgYXJnYywgY2hhciAq YXJndltdLCBib29sICphY3RfdXBvbiwgc2l6ZV90IGFjdF91cG9uX24sIGludCAqbmV3X2ZyZXEp Cj4gIAkJY2FzZSAnZyc6Cj4gIAkJCWlmICh3cml0ZSA9PSB0cnVlKQo+ICAJCQkJZnByaW50Zihz dGRlcnIsICJSZWFkIGFuZCB3cml0ZSBvcGVyYXRpb25zIG5vdCBzdXBwb3J0IHNpbXVsdGFuZW91 c2x5LlxuIik7Cj4gLQo+IC0JCQlpZiAob3B0YXJnKSB7Cj4gLQkJCQljaGFyICp2YWx1ZSwgKnN1 Ym9wdHMgPSBvcHRhcmc7Cj4gLQkJCQlpbnQgeDsKPiAtCQkJCXdoaWxlICgqc3Vib3B0cyAhPSAn XDAnKSB7Cj4gLQkJCQkJeCA9IGdldHN1Ym9wdCgmc3Vib3B0cywgdG9rZW4sICZ2YWx1ZSk7Cj4g LQkJCQkJaWYgKHggPT0gLTEpIHsKPiAtCQkJCQkJZnByaW50ZihzdGRlcnIsICJVbnJlY29nbml6 ZWQgb3B0aW9uICglcylcbiIsIHZhbHVlKTsKPiAtCQkJCQkJYnJlYWs7Cj4gLQkJCQkJfSBlbHNl Cj4gLQkJCQkJCWFjdF91cG9uW3hdID0gdHJ1ZTsKPiAtCQkJCX0KPiAtCQkJfSBlbHNlIHsKPiAr CQkJewo+ICAJCQkJaW50IGk7Cj4gIAkJCQlmb3IgKGkgPSAwOyBpIDwgYWN0X3Vwb25fbjsgaSsr KQo+ICAJCQkJCWFjdF91cG9uW2ldID0gdHJ1ZTsKCllvdSBtaXNzZWQgb25lIG9mIHRoZSBleGFt cGxlcyBpbiB0aGUgdG9wIG9mIHRoZSBmaWxlOgogKiBpbnRlbF9ncHVfZnJlcXVlbmN5IC0tZ2V0 PWN1cixtaW4sbWF4LGVmZgoKV2l0aCB0aG9zZSB0d28sClJldmlld2VkLWJ5OiBCZW4gV2lkYXdz a3kgPGJlbkBid2lkYXdzay5uZXQ+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==