From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix kzalloc() smatch warnings in get_initial_plane_config() Date: Wed, 21 Jan 2015 14:54:57 +0100 Message-ID: <20150121135457.GK10113@phenom.ffwll.local> References: <1421848254-586-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTP id E900D89C3B for ; Wed, 21 Jan 2015 05:55:01 -0800 (PST) Received: by mail-wi0-f181.google.com with SMTP id fb4so21004211wid.2 for ; Wed, 21 Jan 2015 05:55:01 -0800 (PST) Content-Disposition: inline In-Reply-To: <1421848254-586-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org, kbuild@01.org, Dan Carpenter List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMjEsIDIwMTUgYXQgMDE6NTA6NTRQTSArMDAwMCwgRGFtaWVuIExlc3BpYXUg d3JvdGU6Cj4gU21hdGNoIGRvZXNuJ3QgbGlrZToKPiAKPiAgIHN0cnVjdCBkcm1fZnJhbWVidWZm ZXIgKmZiOwo+ICAgZmIgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIp LCBHRlBfS0VSTkVMKTsKPiAKPiBhbmQgd2FybnMgd2l0aDoKPiAKPiAgIHdhcm46IHN0cnVjdCB0 eXBlIG1pc21hdGNoICdkcm1fZnJhbWVidWZmZXIgdnMgaW50ZWxfZnJhbWVidWZmZXInCj4gCj4g VGhpcyBpbXBsaWNpdCBjYXN0IHdhcyBjb3JyZWN0IGFzIHN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZl ciBoYXMgc3RydWN0Cj4gZHJtX2ZyYW1lYnVmZmVyIGFzIGl0cyBmaXJzdCBtZW1iZXIsIGJ1dCBp biBjYXNlIHNvbWVvbmUgd2FudCB0byByZW9yZGVyCj4gdGhlIGZpZWxkcyBmb3Igc29tZSByZWFz b24sIGl0J3Mgc2xpZ2h0bHkgc2FmZXIgdG8gYWNjZXNzIHRoZSB1bmRlcmx5aW5nCj4gZHJtX2Zy YW1lYnVmZmVyIHRocm91Z2ggaW50ZWxfZmItPmJhc2UuCj4gCj4gQWxzbywgaGF2aW5nIGZld2Vy IHN0YXRpYyBhbmFseXNpcyB3YXJuaW5ncyBpcyBhIHdvcnRoeSBnb2FsLgo+IAo+IENjOiBrYnVp bGRAMDEub3JnCj4gQ2M6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4K PiBTaWduZWQtb2ZmLWJ5OiBEYW1pZW4gTGVzcGlhdSA8ZGFtaWVuLmxlc3BpYXVAaW50ZWwuY29t PgoKUXVldWVkIGZvciAtbmV4dCwgdGhhbmtzIGZvciB0aGUgcGF0Y2guCi1EYW5pZWwKCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDIxICsrKysrKysrKysr KysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggNjVmY2U1 Ni4uMDFkYzgwYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAt NjU4NCwxMyArNjU4NCwxNiBAQCBpOXh4X2dldF9pbml0aWFsX3BsYW5lX2NvbmZpZyhzdHJ1Y3Qg aW50ZWxfY3J0YyAqY3J0YywKPiAgCWludCBmb3VyY2MsIHBpeGVsX2Zvcm1hdDsKPiAgCWludCBh bGlnbmVkX2hlaWdodDsKPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ICsJc3RydWN0 IGludGVsX2ZyYW1lYnVmZmVyICppbnRlbF9mYjsKPiAgCj4gLQlmYiA9IGt6YWxsb2Moc2l6ZW9m KHN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciksIEdGUF9LRVJORUwpOwo+IC0JaWYgKCFmYikgewo+ ICsJaW50ZWxfZmIgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIpLCBH RlBfS0VSTkVMKTsKPiArCWlmICghaW50ZWxfZmIpIHsKPiAgCQlEUk1fREVCVUdfS01TKCJmYWls ZWQgdG8gYWxsb2MgZmJcbiIpOwo+ICAJCXJldHVybjsKPiAgCX0KPiAgCj4gKwlmYiA9ICZpbnRl bF9mYi0+YmFzZTsKPiArCj4gIAl2YWwgPSBJOTE1X1JFQUQoRFNQQ05UUihwbGFuZSkpOwo+ICAK PiAgCWlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA0KQo+IEBAIC03NjEzLDEzICs3NjE2LDE2 IEBAIHNreWxha2VfZ2V0X2luaXRpYWxfcGxhbmVfY29uZmlnKHN0cnVjdCBpbnRlbF9jcnRjICpj cnRjLAo+ICAJaW50IGZvdXJjYywgcGl4ZWxfZm9ybWF0Owo+ICAJaW50IGFsaWduZWRfaGVpZ2h0 Owo+ICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmI7Cj4gKwlzdHJ1Y3QgaW50ZWxfZnJhbWVi dWZmZXIgKmludGVsX2ZiOwo+ICAKPiAtCWZiID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IGludGVs X2ZyYW1lYnVmZmVyKSwgR0ZQX0tFUk5FTCk7Cj4gLQlpZiAoIWZiKSB7Cj4gKwlpbnRlbF9mYiA9 IGt6YWxsb2Moc2l6ZW9mKHN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciksIEdGUF9LRVJORUwpOwo+ ICsJaWYgKCFpbnRlbF9mYikgewo+ICAJCURSTV9ERUJVR19LTVMoImZhaWxlZCB0byBhbGxvYyBm YlxuIik7Cj4gIAkJcmV0dXJuOwo+ICAJfQo+ICAKPiArCWZiID0gJmludGVsX2ZiLT5iYXNlOwo+ ICsKPiAgCXZhbCA9IEk5MTVfUkVBRChQTEFORV9DVEwocGlwZSwgMCkpOwo+ICAJaWYgKHZhbCAm IFBMQU5FX0NUTF9USUxFRF9NQVNLKQo+ICAJCXBsYW5lX2NvbmZpZy0+dGlsaW5nID0gSTkxNV9U SUxJTkdfWDsKPiBAQCAtNzcwNiwxMyArNzcxMiwxNiBAQCBpcm9ubGFrZV9nZXRfaW5pdGlhbF9w bGFuZV9jb25maWcoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAlpbnQgZm91cmNjLCBwaXhl bF9mb3JtYXQ7Cj4gIAlpbnQgYWxpZ25lZF9oZWlnaHQ7Cj4gIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVm ZmVyICpmYjsKPiArCXN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZlciAqaW50ZWxfZmI7Cj4gIAo+IC0J ZmIgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIpLCBHRlBfS0VSTkVM KTsKPiAtCWlmICghZmIpIHsKPiArCWludGVsX2ZiID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IGlu dGVsX2ZyYW1lYnVmZmVyKSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIWludGVsX2ZiKSB7Cj4gIAkJ RFJNX0RFQlVHX0tNUygiZmFpbGVkIHRvIGFsbG9jIGZiXG4iKTsKPiAgCQlyZXR1cm47Cj4gIAl9 Cj4gIAo+ICsJZmIgPSAmaW50ZWxfZmItPmJhc2U7Cj4gKwo+ICAJdmFsID0gSTkxNV9SRUFEKERT UENOVFIocGlwZSkpOwo+ICAKPiAgCWlmIChJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA0KQo+IC0t IAo+IDEuOC4zLjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK