From: Steven Rostedt Subject: Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted Date: Thu, 22 Jan 2015 08:56:49 -0500 Message-ID: <20150122085649.7dc79541@grimm.local.home> References: <1421893039-426-1-git-send-email-mcgrof@do-not-panic.com> <1421893039-426-3-git-send-email-mcgrof@do-not-panic.com> <54C0E3F2.9050201@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Luis R. Rodriguez" , , , , , , "Luis R. Rodriguez" , , , Andy Lutomirski , Ingo Molnar , Jan Beulich , "H. Peter Anvin" , Masami Hiramatsu , Thomas Gleixner , Borislav Petkov To: Andrew Cooper Return-path: Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:57816 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751170AbbAVN4a (ORCPT ); Thu, 22 Jan 2015 08:56:30 -0500 In-Reply-To: <54C0E3F2.9050201@citrix.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 22 Jan 2015 11:50:10 +0000 Andrew Cooper wrote: > On 22/01/15 02:17, Luis R. Rodriguez wrote: > > --- a/drivers/xen/events/events_base.c > > +++ b/drivers/xen/events/events_base.c > > @@ -32,6 +32,8 @@ > > #include > > #include > > #include > > +#include > > +#include > > > > #ifdef CONFIG_X86 > > #include > > @@ -1243,6 +1245,17 @@ void xen_evtchn_do_upcall(struct pt_regs > > *regs) set_irq_regs(old_regs); > > } > > > > +notrace void xen_end_upcall(struct pt_regs *regs) > > +{ > > + if (!xen_is_preemptible_hypercall(regs) || > > + __this_cpu_read(xed_nesting_count)) > > + return; > > + > > + if (_cond_resched()) > > + printk(KERN_DEBUG "xen hypercall preempted\n"); > > I wouldn't even put this at debug level. On a large server with > plenty of domains being created/migrated/destroyed, it is quite > likely that a toolstack task might get preempted in this way. > > I don't believe the message is of any practical use. > Why not make this a tracepoint? Then you can enable it only when you want to. As tracepoints are also hooks, you could add you own code that hooks to it and does a printk as well. The advantage of doing it via a tracepoint is that you can turn it on and off regardless of what the loglevel is set at. That is, if there is any practical use for that message. Tracing just sched_switch will give you the same info. -- Steve