From: Daniel Vetter Subject: Re: [PATCH] drm/i915/skl: Enabling PSR on Skylake Date: Wed, 28 Jan 2015 17:02:27 +0100 Message-ID: <20150128160227.GY4764@phenom.ffwll.local> References: <1421917254-29660-1-git-send-email-sonika.jindal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTP id E3CAB6E404 for ; Wed, 28 Jan 2015 08:01:09 -0800 (PST) Received: by mail-wi0-f178.google.com with SMTP id bs8so4567423wib.5 for ; Wed, 28 Jan 2015 08:01:09 -0800 (PST) Content-Disposition: inline In-Reply-To: <1421917254-29660-1-git-send-email-sonika.jindal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sonika Jindal Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMjIsIDIwMTUgYXQgMDI6MzA6NTRQTSArMDUzMCwgU29uaWthIEppbmRhbCB3 cm90ZToKPiBNYWlubHkgdGFraW5nIGNhcmUgb2Ygc29tZSByZWdpc3RlciBvZmZzZXRzLCBvdGhl cndpc2UgdGhpbmdzIGFyZSBzaW1pbGFyIHRvCj4gaHN3LiBBbHNvLCBwcm9ncmFtbWluZyBkZGkg YXV4IHRvIHVzZSBoYXJkY29kZWQgdmFsdWVzIGZvciBwc3IgZGF0YSBzZWxlY3QuCj4gCj4gdjI6 IGludHJvZHVjZSAgRURQX1BTUl9BVVhfQkFTRSBtYWNybyAoQ2hyaXMpCj4gdjM6IE1vdmluZyB0 byBIVyB0cmFja2luZyBmb3IgU0tMKyBwbGF0Zm9ybXMsIHNvIGFjdGl2YXRpbmcgc291cmNlIHBz ciBkdXJpbmcKPiBwc3JfZW5hYmxpbmcgYW5kIHRoZW4gYXZvaWRpbmcgcHNyIGVudHJpZXMgYW5k IGV4aXRzIGZvciBlYWNoIGZyb250YnVmZmVyCj4gdXBkYXRlcy4KPiB2NDogVXNpbmcgU0tMIERE SSBBVVggcmVncyBpbnN0ZWFkIG9mIGNoYW5naW5nIFBTUl9BVVggcmVncyBkZWZpbml0aW9uIChS b2RyaWdvKQo+IAo+IFNpZ25lZC1vZmYtYnk6IFNvbmlrYSBKaW5kYWwgPHNvbmlrYS5qaW5kYWxA aW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRl bC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICAgICAg fCAgICAzICsrLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgICAgIHwg ICAgNSArKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mcm9udGJ1ZmZlci5jIHwg ICAgNyArKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jICAgICAgICAg fCAgIDI2ICsrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gIDQgZmlsZXMgY2hhbmdlZCwgMzYg aW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK PiBpbmRleCA2NmYwYzYwLi4zZDI0ODcyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4g QEAgLTIzNzEsNyArMjM3MSw4IEBAIHN0cnVjdCBkcm1faTkxNV9jbWRfdGFibGUgewo+ICAjZGVm aW5lIEhBU19EREkoZGV2KQkJKElOVEVMX0lORk8oZGV2KS0+aGFzX2RkaSkKPiAgI2RlZmluZSBI QVNfRlBHQV9EQkdfVU5DTEFJTUVEKGRldikJKElOVEVMX0lORk8oZGV2KS0+aGFzX2ZwZ2FfZGJn KQo+ICAjZGVmaW5lIEhBU19QU1IoZGV2KQkJKElTX0hBU1dFTEwoZGV2KSB8fCBJU19CUk9BRFdF TEwoZGV2KSB8fCBcCj4gLQkJCQkgSVNfVkFMTEVZVklFVyhkZXYpIHx8IElTX0NIRVJSWVZJRVco ZGV2KSkKPiArCQkJCSBJU19WQUxMRVlWSUVXKGRldikgfHwgSVNfQ0hFUlJZVklFVyhkZXYpIHx8 IFwKPiArCQkJCSBJU19TS1lMQUtFKGRldikpCj4gICNkZWZpbmUgSEFTX1JVTlRJTUVfUE0oZGV2 KQkoSVNfR0VONihkZXYpIHx8IElTX0hBU1dFTEwoZGV2KSB8fCBcCj4gIAkJCQkgSVNfQlJPQURX RUxMKGRldikgfHwgSVNfVkFMTEVZVklFVyhkZXYpKQo+ICAjZGVmaW5lIEhBU19SQzYoZGV2KQkJ KElOVEVMX0lORk8oZGV2KS0+Z2VuID49IDYpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5k ZXggYTM5YmIwMy4uYTZmMDZmYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBAIC0z NzQ4LDYgKzM3NDgsMTEgQEAgZW51bSBwdW5pdF9wb3dlcl93ZWxsIHsKPiAgI2RlZmluZSAgIERQ X0FVWF9DSF9DVExfUFJFQ0hBUkdFX1RFU1QJICAgICgxIDw8IDExKQo+ICAjZGVmaW5lICAgRFBf QVVYX0NIX0NUTF9CSVRfQ0xPQ0tfMlhfTUFTSyAgICAoMHg3ZmYpCj4gICNkZWZpbmUgICBEUF9B VVhfQ0hfQ1RMX0JJVF9DTE9DS18yWF9TSElGVCAgIDAKPiArI2RlZmluZSAgIERQX0FVWF9DSF9D VExfUFNSX0RBVEFfQVVYX1JFR19TS0wJKDEgPDwgMTQpCj4gKyNkZWZpbmUgICBEUF9BVVhfQ0hf Q1RMX0ZTX0RBVEFfQVVYX1JFR19TS0wJKDEgPDwgMTMpCj4gKyNkZWZpbmUgICBEUF9BVVhfQ0hf Q1RMX0dUQ19EQVRBX0FVWF9SRUdfU0tMCSgxIDw8IDEyKQo+ICsjZGVmaW5lICAgRFBfQVVYX0NI X0NUTF9GV19TWU5DX1BVTFNFX1NLTF9NQVNLICgxZiA8PCA1KQo+ICsjZGVmaW5lICAgRFBfQVVY X0NIX0NUTF9GV19TWU5DX1BVTFNFX1NLTChjKSAoKChjKSAtIDEpIDw8IDUpCj4gICNkZWZpbmUg ICBEUF9BVVhfQ0hfQ1RMX1NZTkNfUFVMU0VfU0tMKGMpICAgKChjKSAtIDEpCj4gIAo+ICAvKgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mcm9udGJ1ZmZlci5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZnJvbnRidWZmZXIuYwo+IGluZGV4IDc5ZjZkNzIu LjAxMGQ1NTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZnJvbnRi dWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Zyb250YnVmZmVyLmMK PiBAQCAtMTU2LDcgKzE1Niw5IEBAIHZvaWQgaW50ZWxfZmJfb2JqX2ludmFsaWRhdGUoc3RydWN0 IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgCj4gIAlpbnRlbF9tYXJrX2ZiX2J1c3koZGV2 LCBvYmotPmZyb250YnVmZmVyX2JpdHMsIHJpbmcpOwo+ICAKPiAtCWludGVsX3Bzcl9pbnZhbGlk YXRlKGRldiwgb2JqLT5mcm9udGJ1ZmZlcl9iaXRzKTsKPiArCj4gKwlpZiAoSU5URUxfSU5GTyhk ZXYpLT5nZW4gPCA5KQo+ICsJCWludGVsX3Bzcl9pbnZhbGlkYXRlKGRldiwgb2JqLT5mcm9udGJ1 ZmZlcl9iaXRzKTsKPiAgfQo+ICAKPiAgLyoqCj4gQEAgLTE4Miw3ICsxODQsOCBAQCB2b2lkIGlu dGVsX2Zyb250YnVmZmVyX2ZsdXNoKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAo+ICAJaW50 ZWxfbWFya19mYl9idXN5KGRldiwgZnJvbnRidWZmZXJfYml0cywgTlVMTCk7Cj4gIAo+IC0JaW50 ZWxfcHNyX2ZsdXNoKGRldiwgZnJvbnRidWZmZXJfYml0cyk7Cj4gKwlpZiAoSU5URUxfSU5GTyhk ZXYpLT5nZW4gPCA5KQo+ICsJCWludGVsX3Bzcl9mbHVzaChkZXYsIGZyb250YnVmZmVyX2JpdHMp OwoKQWdhaW4gbm8sIG5vdCBnb2luZyB0byB0YWtlIHdob2xlc2FsZSBmaWx0ZXJpbmcgb2YgdGhl IHN3IGludmFsaWRhdGUKcGF0aHMuIFRoaXMgbmVlZHMgdG8gYmUgcHJvcGVybHkgdGVzdGVkIGFu ZCBwdXNoZWQgZG93biBpbnRvIHRoZSBwc3IKc3BlY2lmaWMgaW52YWxpZGF0ZS9mbHVzaCBmdW5j dGlvbnMgb24gYSBwZXItZnVuY3Rpb24gYmFzaXMuCgpJJ3ZlIGRyb3BwZWQgdGhlc2UgdHdvIGh1 bmtzIGFuZCBtZXJnZWQgdGhlIHBhdGNoLgotRGFuaWVsCgo+ICAKPiAgCS8qCj4gIAkgKiBGSVhN RTogVW5jb25kaXRpb25hbCBmYmMgZmx1c2hpbmcgaGVyZSBpcyBhIHJhdGhlciBncm9zcyBoYWNr IGFuZAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gaW5kZXggZGQwZTZlMC4uNDg2N2Q1YSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gQEAgLTE0Miw2ICsxNDIsNyBAQCBzdGF0 aWMgdm9pZCBoc3dfcHNyX2VuYWJsZV9zaW5rKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4g IAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXY7Cj4gIAlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ICAJ dWludDMyX3QgYXV4X2Nsb2NrX2RpdmlkZXI7Cj4gKwl1aW50MzJfdCBhdXhfZGF0YV9yZWcsIGF1 eF9jdGxfcmVnOwo+ICAJaW50IHByZWNoYXJnZSA9IDB4MzsKPiAgCWJvb2wgb25seV9zdGFuZGJ5 ID0gZGV2X3ByaXYtPnZidC5wc3IuZnVsbF9saW5rOwo+ICAJc3RhdGljIGNvbnN0IHVpbnQ4X3Qg YXV4X21zZ1tdID0gewo+IEBAIC0xNjgsMTYgKzE2OSwzNCBAQCBzdGF0aWMgdm9pZCBoc3dfcHNy X2VuYWJsZV9zaW5rKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAkJZHJtX2RwX2RwY2Rf d3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9QU1JfRU5fQ0ZHLAo+ICAJCQkJICAgRFBfUFNSX0VO QUJMRSB8IERQX1BTUl9NQUlOX0xJTktfQUNUSVZFKTsKPiAgCj4gKwlhdXhfZGF0YV9yZWcgPSAo SU5URUxfSU5GTyhkZXYpLT5nZW4gPj0gOSkgPwo+ICsJCQkJRFBBX0FVWF9DSF9EQVRBMSA6IEVE UF9QU1JfQVVYX0RBVEExKGRldik7Cj4gKwlhdXhfY3RsX3JlZyA9IChJTlRFTF9JTkZPKGRldikt PmdlbiA+PSA5KSA/Cj4gKwkJCQlEUEFfQVVYX0NIX0NUTCA6IEVEUF9QU1JfQVVYX0NUTChkZXYp Owo+ICsKPiAgCS8qIFNldHVwIEFVWCByZWdpc3RlcnMgKi8KPiAgCWZvciAoaSA9IDA7IGkgPCBz aXplb2YoYXV4X21zZyk7IGkgKz0gNCkKPiAtCQlJOTE1X1dSSVRFKEVEUF9QU1JfQVVYX0RBVEEx KGRldikgKyBpLAo+ICsJCUk5MTVfV1JJVEUoYXV4X2RhdGFfcmVnICsgaSwKPiAgCQkJICAgaW50 ZWxfZHBfcGFja19hdXgoJmF1eF9tc2dbaV0sIHNpemVvZihhdXhfbXNnKSAtIGkpKTsKPiAgCj4g LQlJOTE1X1dSSVRFKEVEUF9QU1JfQVVYX0NUTChkZXYpLAo+ICsJaWYgKElOVEVMX0lORk8oZGV2 KS0+Z2VuID49IDkpIHsKPiArCQl1aW50MzJfdCB2YWw7Cj4gKwo+ICsJCXZhbCA9IEk5MTVfUkVB RChhdXhfY3RsX3JlZyk7Cj4gKwkJdmFsICY9IH5EUF9BVVhfQ0hfQ1RMX1RJTUVfT1VUX01BU0s7 Cj4gKwkJdmFsIHw9IERQX0FVWF9DSF9DVExfVElNRV9PVVRfMTYwMHVzOwo+ICsJCXZhbCAmPSB+ RFBfQVVYX0NIX0NUTF9NRVNTQUdFX1NJWkVfTUFTSzsKPiArCQl2YWwgfD0gKHNpemVvZihhdXhf bXNnKSA8PCBEUF9BVVhfQ0hfQ1RMX01FU1NBR0VfU0laRV9TSElGVCk7Cj4gKwkJLyogVXNlIGhh cmRjb2RlZCBkYXRhIHZhbHVlcyBmb3IgUFNSICovCj4gKwkJdmFsICY9IH5EUF9BVVhfQ0hfQ1RM X1BTUl9EQVRBX0FVWF9SRUdfU0tMOwo+ICsJCUk5MTVfV1JJVEUoYXV4X2N0bF9yZWcsIHZhbCk7 Cj4gKwl9IGVsc2Ugewo+ICsJCUk5MTVfV1JJVEUoYXV4X2N0bF9yZWcsCj4gIAkJICAgRFBfQVVY X0NIX0NUTF9USU1FX09VVF80MDB1cyB8Cj4gIAkJICAgKHNpemVvZihhdXhfbXNnKSA8PCBEUF9B VVhfQ0hfQ1RMX01FU1NBR0VfU0laRV9TSElGVCkgfAo+ICAJCSAgIChwcmVjaGFyZ2UgPDwgRFBf QVVYX0NIX0NUTF9QUkVDSEFSR0VfMlVTX1NISUZUKSB8Cj4gIAkJICAgKGF1eF9jbG9ja19kaXZp ZGVyIDw8IERQX0FVWF9DSF9DVExfQklUX0NMT0NLXzJYX1NISUZUKSk7Cj4gKwl9Cj4gIH0KPiAg Cj4gIHN0YXRpYyB2b2lkIHZsdl9wc3JfZW5hYmxlX3NvdXJjZShzdHJ1Y3QgaW50ZWxfZHAgKmlu dGVsX2RwKQo+IEBAIC0zNTUsNiArMzc0LDkgQEAgdm9pZCBpbnRlbF9wc3JfZW5hYmxlKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAo+ICAJCS8qIEVuYWJsZSBQU1Igb24gdGhlIHBhbmVs ICovCj4gIAkJaHN3X3Bzcl9lbmFibGVfc2luayhpbnRlbF9kcCk7Cj4gKwo+ICsJCWlmIChJTlRF TF9JTkZPKGRldiktPmdlbiA+PSA5KQo+ICsJCQlpbnRlbF9wc3JfYWN0aXZhdGUoaW50ZWxfZHAp Owo+ICAJfSBlbHNlIHsKPiAgCQl2bHZfcHNyX3NldHVwX3ZzYyhpbnRlbF9kcCk7Cj4gIAo+IC0t IAo+IDEuNy4xMC40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==