From: Daniel Vetter Subject: Re: [PATCH] drm/i915/skl: Enabling PSR on Skylake Date: Thu, 29 Jan 2015 17:11:24 +0100 Message-ID: <20150129161124.GG4764@phenom.ffwll.local> References: <1421917254-29660-1-git-send-email-sonika.jindal@intel.com> <20150128160227.GY4764@phenom.ffwll.local> <54C9AF9A.4060404@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by gabe.freedesktop.org (Postfix) with ESMTP id E9E496E0DF for ; Thu, 29 Jan 2015 08:10:05 -0800 (PST) Received: by mail-we0-f169.google.com with SMTP id u56so23854432wes.0 for ; Thu, 29 Jan 2015 08:10:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <54C9AF9A.4060404@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sonika Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMjksIDIwMTUgYXQgMDk6Mjc6MTRBTSArMDUzMCwgc29uaWthIHdyb3RlOgo+ IAo+IE9uIFdlZG5lc2RheSAyOCBKYW51YXJ5IDIwMTUgMDk6MzIgUE0sIERhbmllbCBWZXR0ZXIg d3JvdGU6Cj4gPk9uIFRodSwgSmFuIDIyLCAyMDE1IGF0IDAyOjMwOjU0UE0gKzA1MzAsIFNvbmlr YSBKaW5kYWwgd3JvdGU6Cj4gPj5NYWlubHkgdGFraW5nIGNhcmUgb2Ygc29tZSByZWdpc3RlciBv ZmZzZXRzLCBvdGhlcndpc2UgdGhpbmdzIGFyZSBzaW1pbGFyIHRvCj4gPj5oc3cuIEFsc28sIHBy b2dyYW1taW5nIGRkaSBhdXggdG8gdXNlIGhhcmRjb2RlZCB2YWx1ZXMgZm9yIHBzciBkYXRhIHNl bGVjdC4KPiA+Pgo+ID4+djI6IGludHJvZHVjZSAgRURQX1BTUl9BVVhfQkFTRSBtYWNybyAoQ2hy aXMpCj4gPj52MzogTW92aW5nIHRvIEhXIHRyYWNraW5nIGZvciBTS0wrIHBsYXRmb3Jtcywgc28g YWN0aXZhdGluZyBzb3VyY2UgcHNyIGR1cmluZwo+ID4+cHNyX2VuYWJsaW5nIGFuZCB0aGVuIGF2 b2lkaW5nIHBzciBlbnRyaWVzIGFuZCBleGl0cyBmb3IgZWFjaCBmcm9udGJ1ZmZlcgo+ID4+dXBk YXRlcy4KPiA+PnY0OiBVc2luZyBTS0wgRERJIEFVWCByZWdzIGluc3RlYWQgb2YgY2hhbmdpbmcg UFNSX0FVWCByZWdzIGRlZmluaXRpb24gKFJvZHJpZ28pCj4gPj4KPiA+PlNpZ25lZC1vZmYtYnk6 IFNvbmlrYSBKaW5kYWwgPHNvbmlrYS5qaW5kYWxAaW50ZWwuY29tPgo+ID4+UmV2aWV3ZWQtYnk6 IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+Pi0tLQo+ID4+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgICAgIHwgICAgMyArKy0KPiA+PiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgICAgICAgICB8ICAgIDUgKysrKysKPiA+PiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZnJvbnRidWZmZXIuYyB8ICAgIDcgKysrKystLQo+ ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyAgICAgICAgIHwgICAyNiArKysr KysrKysrKysrKysrKysrKysrKystLQo+ID4+ICA0IGZpbGVzIGNoYW5nZWQsIDM2IGluc2VydGlv bnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPj4KPiA+PmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4+ aW5kZXggNjZmMGM2MC4uM2QyNDg3MiAxMDA2NDQKPiA+Pi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPiA+PisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK PiA+PkBAIC0yMzcxLDcgKzIzNzEsOCBAQCBzdHJ1Y3QgZHJtX2k5MTVfY21kX3RhYmxlIHsKPiA+ PiAgI2RlZmluZSBIQVNfRERJKGRldikJCShJTlRFTF9JTkZPKGRldiktPmhhc19kZGkpCj4gPj4g ICNkZWZpbmUgSEFTX0ZQR0FfREJHX1VOQ0xBSU1FRChkZXYpCShJTlRFTF9JTkZPKGRldiktPmhh c19mcGdhX2RiZykKPiA+PiAgI2RlZmluZSBIQVNfUFNSKGRldikJCShJU19IQVNXRUxMKGRldikg fHwgSVNfQlJPQURXRUxMKGRldikgfHwgXAo+ID4+LQkJCQkgSVNfVkFMTEVZVklFVyhkZXYpIHx8 IElTX0NIRVJSWVZJRVcoZGV2KSkKPiA+PisJCQkJIElTX1ZBTExFWVZJRVcoZGV2KSB8fCBJU19D SEVSUllWSUVXKGRldikgfHwgXAo+ID4+KwkJCQkgSVNfU0tZTEFLRShkZXYpKQo+ID4+ICAjZGVm aW5lIEhBU19SVU5USU1FX1BNKGRldikJKElTX0dFTjYoZGV2KSB8fCBJU19IQVNXRUxMKGRldikg fHwgXAo+ID4+ICAJCQkJIElTX0JST0FEV0VMTChkZXYpIHx8IElTX1ZBTExFWVZJRVcoZGV2KSkK PiA+PiAgI2RlZmluZSBIQVNfUkM2KGRldikJCShJTlRFTF9JTkZPKGRldiktPmdlbiA+PSA2KQo+ ID4+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gPj5pbmRleCBhMzliYjAzLi5hNmYwNmZhIDEwMDY0 NAo+ID4+LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4+KysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4+QEAgLTM3NDgsNiArMzc0OCwxMSBAQCBl bnVtIHB1bml0X3Bvd2VyX3dlbGwgewo+ID4+ICAjZGVmaW5lICAgRFBfQVVYX0NIX0NUTF9QUkVD SEFSR0VfVEVTVAkgICAgKDEgPDwgMTEpCj4gPj4gICNkZWZpbmUgICBEUF9BVVhfQ0hfQ1RMX0JJ VF9DTE9DS18yWF9NQVNLICAgICgweDdmZikKPiA+PiAgI2RlZmluZSAgIERQX0FVWF9DSF9DVExf QklUX0NMT0NLXzJYX1NISUZUICAgMAo+ID4+KyNkZWZpbmUgICBEUF9BVVhfQ0hfQ1RMX1BTUl9E QVRBX0FVWF9SRUdfU0tMCSgxIDw8IDE0KQo+ID4+KyNkZWZpbmUgICBEUF9BVVhfQ0hfQ1RMX0ZT X0RBVEFfQVVYX1JFR19TS0wJKDEgPDwgMTMpCj4gPj4rI2RlZmluZSAgIERQX0FVWF9DSF9DVExf R1RDX0RBVEFfQVVYX1JFR19TS0wJKDEgPDwgMTIpCj4gPj4rI2RlZmluZSAgIERQX0FVWF9DSF9D VExfRldfU1lOQ19QVUxTRV9TS0xfTUFTSyAoMWYgPDwgNSkKPiA+PisjZGVmaW5lICAgRFBfQVVY X0NIX0NUTF9GV19TWU5DX1BVTFNFX1NLTChjKSAoKChjKSAtIDEpIDw8IDUpCj4gPj4gICNkZWZp bmUgICBEUF9BVVhfQ0hfQ1RMX1NZTkNfUFVMU0VfU0tMKGMpICAgKChjKSAtIDEpCj4gPj4gIC8q Cj4gPj5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZnJvbnRidWZmZXIu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Zyb250YnVmZmVyLmMKPiA+PmluZGV4IDc5 ZjZkNzIuLjAxMGQ1NTAgMTAwNjQ0Cj4gPj4tLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9mcm9udGJ1ZmZlci5jCj4gPj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mcm9u dGJ1ZmZlci5jCj4gPj5AQCAtMTU2LDcgKzE1Niw5IEBAIHZvaWQgaW50ZWxfZmJfb2JqX2ludmFs aWRhdGUoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiA+PiAgCWludGVsX21hcmtf ZmJfYnVzeShkZXYsIG9iai0+ZnJvbnRidWZmZXJfYml0cywgcmluZyk7Cj4gPj4tCWludGVsX3Bz cl9pbnZhbGlkYXRlKGRldiwgb2JqLT5mcm9udGJ1ZmZlcl9iaXRzKTsKPiA+PisKPiA+PisJaWYg KElOVEVMX0lORk8oZGV2KS0+Z2VuIDwgOSkKPiA+PisJCWludGVsX3Bzcl9pbnZhbGlkYXRlKGRl diwgb2JqLT5mcm9udGJ1ZmZlcl9iaXRzKTsKPiA+PiAgfQo+ID4+ICAvKioKPiA+PkBAIC0xODIs NyArMTg0LDggQEAgdm9pZCBpbnRlbF9mcm9udGJ1ZmZlcl9mbHVzaChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LAo+ID4+ICAJaW50ZWxfbWFya19mYl9idXN5KGRldiwgZnJvbnRidWZmZXJfYml0cywg TlVMTCk7Cj4gPj4tCWludGVsX3Bzcl9mbHVzaChkZXYsIGZyb250YnVmZmVyX2JpdHMpOwo+ID4+ KwlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPCA5KQo+ID4+KwkJaW50ZWxfcHNyX2ZsdXNoKGRl diwgZnJvbnRidWZmZXJfYml0cyk7Cj4gPkFnYWluIG5vLCBub3QgZ29pbmcgdG8gdGFrZSB3aG9s ZXNhbGUgZmlsdGVyaW5nIG9mIHRoZSBzdyBpbnZhbGlkYXRlCj4gPnBhdGhzLiBUaGlzIG5lZWRz IHRvIGJlIHByb3Blcmx5IHRlc3RlZCBhbmQgcHVzaGVkIGRvd24gaW50byB0aGUgcHNyCj4gPnNw ZWNpZmljIGludmFsaWRhdGUvZmx1c2ggZnVuY3Rpb25zIG9uIGEgcGVyLWZ1bmN0aW9uIGJhc2lz Lgo+ID4KPiA+SSd2ZSBkcm9wcGVkIHRoZXNlIHR3byBodW5rcyBhbmQgbWVyZ2VkIHRoZSBwYXRj aC4KPiA+LURhbmllbAo+IEhpIERhbmllbCwKPiBFdmVuIFNXIHRyYWNraW5nIGRvZXNuJ3Qgd29y ayBpbiBtYW55IGNhc2VzLCBsaWtlIEkgcmVwb3J0ZWQgZWFybGllciBpbgo+IHVidW50dSBsb2dp biBzY3JlZW4gd2hlcmUgd2UgZG9uJ3QgZ2V0IGZyb250YnVmZmVyIGZsdXNoZXMgYW5kIHdlIGRv bid0Cj4gZW50ZXIgUFNSIGF0IGFsbCB3aXRoIFNXIHRyYWNraW5nLgo+IEkgc2VlIHNpbWlsYXIg YmVoYXZpb3IgZXZlbiBpbiBmYmNvbiBtb2RlLiBTbywgSSBhbSBub3Qgc3VyZSBob3cgeW91IGNh biBzYXkKPiB0aGF0IFNXIHRyYWNraW5nIGlzIHRoZSBvbmx5IHJpZ2h0IHdheS4KCkluIHNvbWUg Y2FzZXMgdGhlIHN3IHRyYWNraW5nIGlzbid0IGVzcGVjaWFsbHkgYWNjdXJhdGUgKGNwdSBiYXNl ZApmcm9udGJ1ZmZlciByZW5kZXJpbmcgdG8gdGhlIGd0dCkuIFBhdWxvIGhhcyBzZWVuIGEgc2lt aWxhciBpc3N1ZSB3aXRoCmZiYywgYW5kIHNpbmNlIGh3IHRyYWNraW5nIHdvcmtzIGNvcnJlY3Rs eSBmb3IgdGhhdCBjYXNlIGhpcyBwYXRjaGVzCmZpbHRlciB0aGF0IHNvdXJjZSBvZiBzdyBpbnZh bGlkYXRlcyBvdXQuIFBhdWxvIHNob3VsZCBiZSBiYWNrIGZyb20gaGlzCnZhY2F0aW9uIG5leHQg d2Vlaywgc28gcGxlYXNlIHBpbmcgaGltIHdoZW4gaGUncyBiYWNrLgoKPiBJZiB0aGVyZSBhcmUg Y2FzZXMgd2hlcmUgSFcgdHJhY2tpbmcgZmFpbHMgKGFuZCBJIGtub3cgYSBmZXcpLCB3ZSBuZWVk IHRvCj4gZml4IHRoZW0uIEkgY2FuIG1vdmUgdGhpcyBnZW4gY2hlY2sgdG8gdGhlIGludGVsX3Bz cl8qIGZ1bmN0aW9uIGlmIHRoYXQgaXMKPiB0aGUgbWFqb3IgY29uY2Vybi4KClllYWgsIHRoZSBj aGVjayBzaG91bGQgYmUgcHVzaGVkIGRvd24gaW1vLCBpbiB0aGUgY29yZSBzdyB0cmFja2luZyBj b2RlCml0J3MgYSBiaXQgaW4gdGhlIHdyb25nIGxheWVyLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0 dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1 NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==