From: Guenter Roeck Date: Mon, 02 Feb 2015 16:21:18 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable Message-Id: <20150202162118.GA14642@roeck-us.net> List-Id: References: <20150127233455.0c62457e@endymion.delvare> <54C86035.9080605@roeck-us.net> <54C87F3C.2020105@axis.com> <54C8F73D.4040808@roeck-us.net> <54C9DA9D.3010802@axis.com> <54C9DBD5.5030808@roeck-us.net> <54CA226E.6080505@axis.com> <20150129193040.GA21937@roeck-us.net> <54CD36DF.7010602@roeck-us.net> <54CF3189.8050504@axis.com> In-Reply-To: <54CF3189.8050504@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Robert Rosengren Cc: Johan Adolfsson , "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" On Mon, Feb 02, 2015 at 09:12:57AM +0100, Robert Rosengren wrote: > On 01/31/2015 09:11 PM, Guenter Roeck wrote: > >On 01/29/2015 11:30 AM, Guenter Roeck wrote: > >>On Thu, Jan 29, 2015 at 01:07:10PM +0100, Robert Rosengren wrote: > >>>>Is your hardware big endian or little endian ? > >>>CONFIG_CPU_LITTLE_ENDIAN=y > >>> > >>Hi Robert, > >> > >>I have another question: What is your i2c controller type ? > >> > >Robert, > > > >I now tried both 3.15 and 3.19-rc6. Both kernels require the byte swap code. > > Agrees, no difference for me when trying with 3.15 and 3.18 version. > > The i2c is a bit-bang driver, specific for the hardware I am running on. > > > > >The only reason I can imagine why you don't need it in your code would be > >that your i2c controller does not support i2c functionality but only SMBus. > >This would be the case, for example, with the i801 controller. So it would > >be quite helpful to know which controller your system uses to access the > >ads7828. > > > >Thanks, > >Guenter > > > > I tried your latest patch set (the 3 patches submitted last night) and it > works fine for me. Great work! > > Please change my Cc-tag in the patches to Reviewed-by or Tested-by (I have > done both, but one tag is enough). Thanks :-) > I made it Reviewed-and-Tested-by. Thanks a lot! Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors