From: Wei Liu Subject: Re: [PATCH] rump kernels: use new platform macro Date: Tue, 3 Feb 2015 13:34:35 +0000 Message-ID: <20150203133435.GA23306@zion.uk.xensource.com> References: <1422969055-636-1-git-send-email-wei.liu2@citrix.com> <1422970074.9323.77.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1422970074.9323.77.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ian Jackson , Wei Liu , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, Feb 03, 2015 at 01:27:54PM +0000, Ian Campbell wrote: > On Tue, 2015-02-03 at 13:10 +0000, Wei Liu wrote: > > Starting from rump kernel changeset 91d5623 ("Renaming platform macros, > > app-tools and autoconf target string"), __RUMPUSER_XEN__ and __RUMPAPP__ > > are deleted. We are supposed to use __RUMPRUN__ instead. > > How much do we care about forward/backwards compat here? > I don't think rump kernel ever declared a macro stable for a specific version. In fact, rump kernel is not yet officially released AFAICT. > One specific potential wrinkle: > > I suspect rumpkernel changeset 91d5623 cannot pass the rump kernel push > gate without this change in the xen being used (which is the output opf > the Xen gate), and this change cannot pass the xen-unstable push gate > without the rumpkernel one, so we have an impasse. > Ah, yes. I missed that xen-unstable is also gated by rump kernel build. > I think we probably need libxc to handle both __RUMPRUN__ and > __RUMPUSER_XEN_, at least for the time being (which might be a very > short time while the other change passes its gate). I will resend a patch to have both __RUMPRUN__ and __RUMPUSER_XEN__. Wei. > > Ian.