From: "Luis R. Rodriguez" Subject: Re: [Xen-devel] [PATCH v5 1/2] xen: add xen_is_preemptible_hypercall() Date: Tue, 3 Feb 2015 19:03:34 +0100 Message-ID: <20150203180334.GT19988@wotan.suse.de> References: <1422323467-16713-1-git-send-email-mcgrof@do-not-panic.com> <1422323467-16713-2-git-send-email-mcgrof@do-not-panic.com> <54D0AB6B.9060909@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Luis R. Rodriguez" , konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org, Borislav Petkov , kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, Andy Lutomirski , Ingo Molnar , Jan Beulich , "H. Peter Anvin" , Masami Hiramatsu , Thomas Gleixner , paulmck@linux.vnet.ibm.com To: David Vrabel Return-path: Content-Disposition: inline In-Reply-To: <54D0AB6B.9060909@citrix.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Feb 03, 2015 at 11:05:15AM +0000, David Vrabel wrote: > On 27/01/15 01:51, Luis R. Rodriguez wrote: > > > > +#ifndef CONFIG_PREEMPT > > +extern struct { char _entry[32]; } preemptible_hypercall_page[]; > > + > > +static inline bool xen_is_preemptible_hypercall(struct pt_regs *regs) > > +{ > > + return !user_mode_vm(regs) && > > + regs->ip >= (unsigned long)preemptible_hypercall_page && > > + regs->ip < (unsigned long)preemptible_hypercall_page + PAGE_SIZE; > > I asked for this test to be optimized. > > return (regs->ip >> PAGE_SHIFT) > == ((unsigned long)preemptible_hypercall_page >> PAGE_SHIFT) > && !user_mode_vm(regs); It didn't seem you were so sure about it and I asked some clarifications about it but you had not replied: http://www.gossamer-threads.com/lists/xen/devel/363565?page=last Luis