From: Lukasz Majewski Date: Wed, 04 Feb 2015 10:22:26 +0100 Subject: [U-Boot] [PATCH 3/5] dfu: nand: Verify writes In-Reply-To: <1422986296-26086-3-git-send-email-ptyser@xes-inc.com> References: <1422986296-26086-1-git-send-email-ptyser@xes-inc.com> <1422986296-26086-3-git-send-email-ptyser@xes-inc.com> Message-ID: <20150204102226.4427988b@amdc2363> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peter, > Previously NAND writes were not verified and could fail silently. Add > a verification step after all writes to NAND. > > Signed-off-by: Peter Tyser > --- > I don't have a board with DFU support, so this change is untested. > > drivers/dfu/dfu_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dfu/dfu_nand.c b/drivers/dfu/dfu_nand.c > index f9ee189..a975492 100644 > --- a/drivers/dfu/dfu_nand.c > +++ b/drivers/dfu/dfu_nand.c > @@ -64,7 +64,7 @@ static int nand_block_op(enum dfu_op op, struct > dfu_entity *dfu, return ret; > /* then write */ > ret = nand_write_skip_bad(nand, start, &count, > &actual, > - lim, buf, 0); > + lim, buf, WITH_WR_VERIFY); > } > > if (ret != 0) { Reviewed-by: Lukasz Majewski I think that Heiko or Tom, who are active users of DFU NAND, should check this patch too. -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group