Received: from eggs.gnu.org ([2001:4830:134:3::10]:33310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJhU4-0005WY-J2 for qemu-devel@nongnu.org; Fri, 06 Feb 2015 06:54:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJhU0-0008JZ-7r for qemu-devel@nongnu.org; Fri, 06 Feb 2015 06:54:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJhU0-0008JR-0z for qemu-devel@nongnu.org; Fri, 06 Feb 2015 06:54:00 -0500 Date: Fri, 6 Feb 2015 12:53:47 +0100 From: Kevin Wolf Message-ID: <20150206115347.GB13081@noname.redhat.com> References: <1423220051-16058-1-git-send-email-pl@kamp.de> <1423221883-16804-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423221883-16804-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 1/1] nbd: fix max_discard/max_transfer_length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Peter Lieven , qemu-devel@nongnu.org Am 06.02.2015 um 12:24 hat Denis V. Lunev geschrieben: > nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t > as the length in bytes of the data to discard due to the following > definition: > > struct nbd_request { > uint32_t magic; > uint32_t type; > uint64_t handle; > uint64_t from; > uint32_t len; <-- the length of data to be discarded, in bytes > } QEMU_PACKED; > > Thus we should limit bl_max_discard to UINT32_MAX >> BDRV_SECTOR_BITS to > avoid overflow. > > NBD read/write code uses the same structure for transfers. Fix > max_transfer_length accordingly. > > Signed-off-by: Denis V. Lunev > CC: Peter Lieven > CC: Kevin Wolf Thanks, I have applied both Peter's and your patch. Can you guys please check whether the current state of my block branch is correct or whether I forgot to include or remove some patch? By the way, I don't think this NBD patch is strictly necessary as you'll have a hard time finding a platform where INT_MAX > UINT32_MAX, but I think it's good documentation at least and a safeguard if we ever decide to lift the general block layer restrictions. Kevin