Received: from eggs.gnu.org ([2001:4830:134:3::10]:37993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJlUj-00006I-DO for qemu-devel@nongnu.org; Fri, 06 Feb 2015 11:11:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJlUf-0006aE-B3 for qemu-devel@nongnu.org; Fri, 06 Feb 2015 11:11:01 -0500 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:59802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJlUf-0006a7-5G for qemu-devel@nongnu.org; Fri, 06 Feb 2015 11:10:57 -0500 Received: by mail-wi0-f174.google.com with SMTP id n3so3625210wiv.1 for ; Fri, 06 Feb 2015 08:10:56 -0800 (PST) Date: Fri, 6 Feb 2015 16:10:54 +0000 From: Stefan Hajnoczi Message-ID: <20150206161054.GG18729@stefanha-thinkpad.redhat.com> References: <1423158090-25580-1-git-send-email-jsnow@redhat.com> <1423158090-25580-5-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PpAOPzA3dXsRhoo+" Content-Disposition: inline In-Reply-To: <1423158090-25580-5-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 04/19] libqos/ahci: Add command header helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com --PpAOPzA3dXsRhoo+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 05, 2015 at 12:41:15PM -0500, John Snow wrote: > Adds command header helper functions: > -ahci_command_header_set > -ahci_command_header_get, > -ahci_command_destroy, and > -ahci_cmd_pick >=20 > These helpers help to quickly manage the command header information in > the AHCI device. >=20 > ahci_command_header_set and get will store or retrieve an AHCI command > header, respectively. >=20 > ahci_cmd_pick chooses the first available but least recently used > command slot to allow us to cycle through the available command slots. >=20 > ahci_command_destroy obliterates all information contained within a > given slot's command header, and frees its associated command table, > but not its DMA buffer! >=20 > Lastly, the command table pointer fields (dba and dbau) are merged into > a single 64bit value to make managing 64bit tests simpler. >=20 > Signed-off-by: John Snow > --- > tests/ahci-test.c | 43 ++++++++++++++++-------------- > tests/libqos/ahci.c | 75 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/libqos/ahci.h | 17 ++++++++---- > 3 files changed, 110 insertions(+), 25 deletions(-) Reviewed-by: Stefan Hajnoczi --PpAOPzA3dXsRhoo+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU1OeOAAoJEJykq7OBq3PI1LQH/0hgGG0N/MBzz0V0PwD/xonq VhmvK+us5jxk6o9X86xGb5+WVASTjxArwImUQaYdKTBMCYqH/c4wE/KMmn8AlVQD QwH4EhhEIGH7ns7befZsfK68A2oZtJAGVG5B9ZoNhT8AcjUJ4Oqtem8HvL6wNkyk yilxFXLL8d+oJS5LeUTN4PE6pmreEli3XZRQVgXmqKXjiokk4zHR1fYHXqV5pqN9 TZSTizXND5jumILdoqWJEGiVxGVn9pnk9cFWnJNbVX0ZZEAXP1t4u/uK6A7GK73L 5rfD6BfiBMI1kTYnNSgvSzBonlJ4ueEdjqPFLRRcqgmOFowuWYwEcltGOkOG5Lw= =qLLA -----END PGP SIGNATURE----- --PpAOPzA3dXsRhoo+--