From: Pablo Neira Ayuso Subject: Re: [PATCH 3.4.106] ipvs: rerouting to local clients is not needed anymore Date: Mon, 9 Feb 2015 12:32:50 +0100 Message-ID: <20150209113250.GB3854@salvia> References: <1423212972-24928-1-git-send-email-ja@ssi.bg> <20150209002320.GB12850@verge.net.au> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20150209002320.GB12850@verge.net.au> Sender: lvs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Simon Horman Cc: Julian Anastasov , lvs-devel@vger.kernel.org On Mon, Feb 09, 2015 at 09:23:20AM +0900, Simon Horman wrote: > On Fri, Feb 06, 2015 at 10:56:12AM +0200, Julian Anastasov wrote: > > commit f5a41847acc5 ("ipvs: move ip_route_me_harder for ICMP") > > from 2.6.37 introduced ip_route_me_harder() call for responses to > > local clients, so that we can provide valid rt_src after SNAT. > > It was used by TCP to provide valid daddr for ip_send_reply(). > > After commit 0a5ebb8000c5 ("ipv4: Pass explicit daddr arg to > > ip_send_reply()." from 3.0 this rerouting is not needed anymore > > and should be avoided, especially in LOCAL_IN. > > > > Signed-off-by: Julian Anastasov > > Acked-by: Simon Horman > > Pablo, could you guide this into stable 3.4 ? Also added to my queue, you'll be Cc'ed by when I'll pass this to -stable. Thanks Julian and Simon