Received: from eggs.gnu.org ([2001:4830:134:3::10]:41292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLx6n-0006Es-Rs for qemu-devel@nongnu.org; Thu, 12 Feb 2015 11:59:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLx6k-00047M-Ln for qemu-devel@nongnu.org; Thu, 12 Feb 2015 11:59:21 -0500 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:57641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLx6k-000477-By for qemu-devel@nongnu.org; Thu, 12 Feb 2015 11:59:18 -0500 Received: by mail-we0-f172.google.com with SMTP id k48so11402044wev.3 for ; Thu, 12 Feb 2015 08:59:17 -0800 (PST) Date: Thu, 12 Feb 2015 16:59:15 +0000 From: Stefan Hajnoczi Message-ID: <20150212165915.GF4054@stefanha-thinkpad.redhat.com> References: <1423158090-25580-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="twz1s1Hj1O0rHoT0" Content-Disposition: inline In-Reply-To: <1423158090-25580-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 00/19] qtest/ahci: add dma test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: famz@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com --twz1s1Hj1O0rHoT0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 05, 2015 at 12:41:11PM -0500, John Snow wrote: > Add a simple DMA r/w test to ahci-test. >=20 > Oh, and for the first 18 patches, refactor everything into helpers so > that each ahci_test isn't a thousand lines long. >=20 > This patch depends upon the "ahci test preliminary refactoring" series > upstream, which shuffled a lot of libqos and malloc facilities to > support this series. >=20 > This patchset is a necessary step in checking in AHCI/DMA migration > tests that I will later use as proof as suitability of enabling the > ICH9 and AHCI migration flags. >=20 > V3: > (04) Changed "px" to "port" and "cx" to "slot" In this and all other pat= ches. > Kept R-Bys in other patches as this is a non-functional change. > (10) Modified aux to be an array of four bytes, and added a note > explaining that they are for NCQ and not currently used in libqos. > (12) Minor formatting and updating aux initialization. Kept R-B. >=20 > V2: > (03) Added cpu_to_le16 into intermediary code. > (04) Fixed assignment to be or-equals. > ahci_set_command_header no longer modifies its argument. > (09) Fixed assignment to be or-equals in the helper refactor. > (10) New patch. Writes an FIS to guest memory, handling endianness. > (11) Remove the property table sentinel > update find_command to use the array size instead. > (12) Remove cpu_to_le16 from ahci_command_commit, > leave endianness to ahci_write_fis. > (14) Remove cpu_to_le16 from ahci_set_sizes, > leave endianness to ahci_write_fis. > (19) qmemset the buffer to zeroes between IO calls, > just to make sure. > (--) Removed the ahci_macro_boot function patch > (...for now...) > (--) Retested entire stack of patches on F20/PPC. >=20 > ~John >=20 > John Snow (19): > libqos/ahci: Add ahci_port_select helper > libqos/ahci: Add ahci_port_clear helper > qtest/ahci: rename 'Command' to 'CommandHeader' > libqos/ahci: Add command header helpers > libqos/ahci: Add ahci_port_check_error helper > libqos/ahci: Add ahci_port_check_interrupts helper > libqos/ahci: Add port_check_nonbusy helper > libqos/ahci: Add cmd response sanity check helpers > qtest/ahci: Demagic ahci tests. > qtest/ahci: add ahci_write_fis > libqos/ahci: Add ide cmd properties > libqos/ahci: add ahci command functions > libqos/ahci: add ahci command verify > libqos/ahci: add ahci command size setters > libqos/ahci: Add ahci_guest_io > libqos/ahci: add ahci_io > libqos/ahci: Add ahci_clean_mem > qtest/ahci: Assert sector size in identify test > qtest/ahci: Adding simple dma read-write test >=20 > tests/ahci-test.c | 230 ++++++++------------ > tests/libqos/ahci.c | 569 ++++++++++++++++++++++++++++++++++++++++++++= ++++++ > tests/libqos/ahci.h | 168 ++++++++++++--- > tests/libqos/malloc.c | 5 + > tests/libqos/malloc.h | 1 + > 5 files changed, 804 insertions(+), 169 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --twz1s1Hj1O0rHoT0 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU3NvjAAoJEJykq7OBq3PIxFoH/Avau9j8eSzc9+Vx6U90tbn+ JIWVSxdF+0eeOT4e1rjudiEaa5b4JdepWu7dH/HAFUoYjeJy4kD6YgK8UYnv0T7F J2SObEqMGN4H1reDSeZF/bWAD6q9WqemPXfIxL0XfSIZ2ZxHxeRTrqyWWWSBfYKm LL32ZeQ91S7dAqks1IMMv9YoHlppl5HtrIkDJKdMOVYyOSt8uhod3M8TzKxXVMNB ICg6w9RLDtdV7n3K3WMBSrxcVZeLdtDt1r04UTKNAjILdrD70dSWmaViTHWQLR3a 4hgzgrAcwGUIrKQ+anc1iJPZoJi38l7pd/uGrah/iF6D9tDLyE8ttQ9uz7mNrKw= =hF5w -----END PGP SIGNATURE----- --twz1s1Hj1O0rHoT0--