From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix an incorrect free rather than derefence issue. Date: Fri, 13 Feb 2015 10:32:15 +0100 Message-ID: <20150213093215.GH24485@phenom.ffwll.local> References: <1423744161-21554-1-git-send-email-nicholas.hoath@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id EA22F6E7B4 for ; Fri, 13 Feb 2015 01:31:18 -0800 (PST) Received: by mail-wi0-f174.google.com with SMTP id em10so10545207wid.1 for ; Fri, 13 Feb 2015 01:31:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <1423744161-21554-1-git-send-email-nicholas.hoath@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Nick Hoath Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBGZWIgMTIsIDIwMTUgYXQgMTI6Mjk6MjFQTSArMDAwMCwgTmljayBIb2F0aCB3cm90 ZToKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODg2NTIKPiAKPiBTaWduZWQtb2ZmLWJ5OiBOaWNrIEhvYXRoIDxuaWNob2xhcy5ob2F0aEBp bnRlbC5jb20+CgpDb21taXQgbWVzc2FnZSBpcyBtaXNzaW5nIHRoZSBhYnNvbHV0ZWx5IGNydWNp YWwgZGV0YWlsIGFib3V0IHdoaWNoIHBhdGNoCmludHJvZHVjZWQgdGhpcyByZWdyZXNzaW9uOgoK Y29tbWl0IDZkM2Q4Mjc0YmM0NWRlNGJhYmI2MmQ2NDU2MmQ5MmFmOTg0ZGQyMzgKQXV0aG9yOiAg ICAgTmljayBIb2F0aCA8bmljaG9sYXMuaG9hdGhAaW50ZWwuY29tPgpBdXRob3JEYXRlOiBUaHUg SmFuIDE1IDEzOjEwOjM5IDIwMTUgKzAwMDAKCiAgICBkcm0vaTkxNTogU3Vic3VtZSBpbnRlbF9j dHhfc3VibWl0X3JlcXVlc3QgaW4gdG8gZHJtX2k5MTVfZ2VtX3JlcXVlc3QKCkFub3RoZXIgdGhp bmcgSSd2ZSBub3RpY2VkIGlzIHRoYXQgd2UgZXhwbGljaXRseSBkcm9wIHRoZSBjb250ZXh0CnJl ZmVyZW5jZSBmb3IgdGhlIHJlcXVlc3QgYmVmb3JlIGRyb3BwaW5nIHRoZSByZXF1ZXN0IHJlZmVy ZW5jZS4gV2l0aG91dApjbGVhcmluZyB0aGUgcmVxLT5jdHggcG9pbnRlci4gVGhhdCBoYXMgYSB2 ZXJ5IGhpZ2ggY2hhbmNlIHRvIGxlYWRpbmcgdG8KdGVhcnMsIGltbyB0aGUgY29udGV4dCB1bnJl ZmVyZW5jZWluZyBzaG91bGQgYmUgcHVzaGVkIGludG8KaTkxNV9nZW1fcmVxdWVzdF9mcmVlLgoK RXhjZXB0IHRoYXQgaXQncyB0aGVyZSBhbHJlYWR5LCB3aGljaCBtZWFucyB3ZSBoYXZlIGEgZG91 YmxlIHVucmVmIG5vdz8KCkFsc28gdGhpcyBwYXRjaCBpcyBmb3IgdGhlIGxlZ2FjeSByaW5nYnVm ZmVyIGNvZGUsIGJ1dCB0aGUgcmVmZXJlbmNlZCBidWcKaXMgZm9yIGdlbjgrIGV4ZWNsaXN0cy4g V2UncmUgZGVmaW5pdGVseSBub3QgcnVubmluZyB0aGlzIGNvZGUgaGVyZSBJCnRoaW5rLgoKSW1v IHN0ZXAgb25lIGlzIHRvIGRyb3AgYWxsIHRoZSBleHBsaWNpdCBjdHggcmVmY291bnRpbmcgZm9y IHJlcS0+Y3R4IGFuZAphbHdheXMgcmVseSBvbiB0aGUgaW1wbGljaXQgcmVmZXJlbmNlLiBUaGVu IHNlZSB3aGF0IGhhcHBlbnMuCgpDaGVlcnMsIERhbmllbAoKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMgfCAyICstCj4gIDIgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDE3NjU5ODkuLmRjMTBk ODYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAtMjY2MSw3ICsyNjYxLDcgQEAg c3RhdGljIHZvaWQgaTkxNV9nZW1fcmVzZXRfcmluZ19jbGVhbnVwKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiAgCQkJaW50ZWxfbHJfY29udGV4dF91bnBpbihyaW5nLCBzdWJt aXRfcmVxLT5jdHgpOwo+ICAKPiAgCQlpOTE1X2dlbV9jb250ZXh0X3VucmVmZXJlbmNlKHN1Ym1p dF9yZXEtPmN0eCk7Cj4gLQkJa2ZyZWUoc3VibWl0X3JlcSk7Cj4gKwkJaTkxNV9nZW1fcmVxdWVz dF91bnJlZmVyZW5jZShzdWJtaXRfcmVxKTsKPiAgCX0KPiAgCj4gIAkvKgo+IC0tIAo+IDIuMS4x Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK Ci0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgor NDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==