Received: from eggs.gnu.org ([2001:4830:134:3::10]:48833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNicu-0000bR-5e for qemu-devel@nongnu.org; Tue, 17 Feb 2015 08:55:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNicq-0002s8-71 for qemu-devel@nongnu.org; Tue, 17 Feb 2015 08:55:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNicp-0002rh-Ug for qemu-devel@nongnu.org; Tue, 17 Feb 2015 08:55:44 -0500 Date: Tue, 17 Feb 2015 14:55:38 +0100 From: Igor Mammedov Message-ID: <20150217145538.01d51fda@nial.brq.redhat.com> In-Reply-To: <1424167517-21866-4-git-send-email-mst@redhat.com> References: <1424167517-21866-1-git-send-email-mst@redhat.com> <1424167517-21866-4-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] acpi: has_immutable_rsdp->!rsdp_in_ram List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, Anthony Liguori , Richard Henderson On Tue, 17 Feb 2015 11:05:42 +0100 "Michael S. Tsirkin" wrote: > As comment in acpi-build.c notes, RSDP is not really immutable. So it's > really a question of whether it's in RAM, name the variable accordingly. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > include/hw/i386/pc.h | 2 +- > hw/i386/acpi-build.c | 2 +- > hw/i386/pc_piix.c | 6 +++--- > hw/i386/pc_q35.c | 6 +++--- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index b0a80cf..0c595c5 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -104,7 +104,7 @@ struct PcGuestInfo { > int legacy_acpi_table_size; > bool has_acpi_build; > bool has_reserved_memory; > - bool has_immutable_rsdp; > + bool rsdp_in_ram; > }; > > /* parallel.c */ > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index e78d6cb..ffa3f00 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1556,7 +1556,7 @@ void acpi_setup(PcGuestInfo *guest_info) > fw_cfg_add_file(guest_info->fw_cfg, ACPI_BUILD_TPMLOG_FILE, > tables.tcpalog->data, acpi_data_len(tables.tcpalog)); > > - if (guest_info->has_immutable_rsdp) { > + if (!guest_info->rsdp_in_ram) { > /* > * Keep for compatibility with old machine types. > * Though RSDP is small, its contents isn't immutable, so > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index e586c7b..13ff561 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -60,7 +60,7 @@ static const int ide_iobase2[MAX_IDE_BUS] = { 0x3f6, 0x376 }; > static const int ide_irq[MAX_IDE_BUS] = { 14, 15 }; > > static bool has_acpi_build = true; > -static bool has_immutable_rsdp; > +static bool rsdp_in_ram = true; > static int legacy_acpi_table_size; > static bool smbios_defaults = true; > static bool smbios_legacy_mode; > @@ -169,7 +169,7 @@ static void pc_init1(MachineState *machine, > > guest_info->isapc_ram_fw = !pci_enabled; > guest_info->has_reserved_memory = has_reserved_memory; > - guest_info->has_immutable_rsdp = has_immutable_rsdp; > + guest_info->rsdp_in_ram = rsdp_in_ram; > > if (smbios_defaults) { > MachineClass *mc = MACHINE_GET_CLASS(machine); > @@ -312,7 +312,7 @@ static void pc_init_pci(MachineState *machine) > > static void pc_compat_2_2(MachineState *machine) > { > - has_immutable_rsdp = true; > + rsdp_in_ram = false; > x86_cpu_compat_set_features("kvm64", FEAT_1_EDX, 0, CPUID_VME); > x86_cpu_compat_set_features("kvm32", FEAT_1_EDX, 0, CPUID_VME); > x86_cpu_compat_set_features("Conroe", FEAT_1_EDX, 0, CPUID_VME); > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index 6151f2f..c0f21fe 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -50,7 +50,7 @@ > #define MAX_SATA_PORTS 6 > > static bool has_acpi_build = true; > -static bool has_immutable_rsdp; > +static bool rsdp_in_ram = true; > static bool smbios_defaults = true; > static bool smbios_legacy_mode; > static bool smbios_uuid_encoded = true; > @@ -155,7 +155,7 @@ static void pc_q35_init(MachineState *machine) > guest_info->isapc_ram_fw = false; > guest_info->has_acpi_build = has_acpi_build; > guest_info->has_reserved_memory = has_reserved_memory; > - guest_info->has_immutable_rsdp = has_immutable_rsdp; > + guest_info->rsdp_in_ram = rsdp_in_ram; > > /* Migration was not supported in 2.0 for Q35, so do not bother > * with this hack (see hw/i386/acpi-build.c). > @@ -291,7 +291,7 @@ static void pc_q35_init(MachineState *machine) > > static void pc_compat_2_2(MachineState *machine) > { > - has_immutable_rsdp = true; > + rsdp_in_ram = false; > x86_cpu_compat_set_features("kvm64", FEAT_1_EDX, 0, CPUID_VME); > x86_cpu_compat_set_features("kvm32", FEAT_1_EDX, 0, CPUID_VME); > x86_cpu_compat_set_features("Conroe", FEAT_1_EDX, 0, CPUID_VME);