Received: from eggs.gnu.org ([2001:4830:134:3::10]:58140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO1Np-0007Wy-Ug for qemu-devel@nongnu.org; Wed, 18 Feb 2015 04:57:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO1Nm-0004e3-KM for qemu-devel@nongnu.org; Wed, 18 Feb 2015 04:57:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO1Nm-0004ds-Dh for qemu-devel@nongnu.org; Wed, 18 Feb 2015 04:57:26 -0500 Date: Wed, 18 Feb 2015 10:57:18 +0100 From: Igor Mammedov Message-ID: <20150218105718.1534bf93@nial.brq.redhat.com> In-Reply-To: <20150217164200.GB26775@redhat.com> References: <1423479254-15342-1-git-send-email-imammedo@redhat.com> <1423479254-15342-7-git-send-email-imammedo@redhat.com> <20150217164200.GB26775@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 06/52] pc: acpi-build: use aml_def_block() for declaring SSDT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: drjones@redhat.com, marcel.a@redhat.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, zhaoshenglong@huawei.com On Tue, 17 Feb 2015 17:42:00 +0100 "Michael S. Tsirkin" wrote: > On Mon, Feb 09, 2015 at 10:53:28AM +0000, Igor Mammedov wrote: > > it replaces prebuilt SSDT table header template copying/patching > > with AML API > > > > Signed-off-by: Igor Mammedov > > I note that this changed the SSDT signature in random ways, > for example, it used to be named BXPCSSDT, now it's BXPC. > > Pls keep using build_header, this problem will go away then. [...] > > + /* Init SSDT Definition Block */ > > + ssdt = aml_def_block("SSDT", 1, ACPI_BUILD_APPNAME6, > > + ACPI_BUILD_APPNAME4, 1, I've missed that build_header() composes oem_table_id implicitly by merging table signature and ACPI_BUILD_APPNAME4. following should fix issue: - ACPI_BUILD_APPNAME4, 1, + "BXPCSSDT", 1, > > + ACPI_BUILD_APPNAME4_HEX, 1);