From: Tom Rini Date: Thu, 19 Feb 2015 09:27:22 -0500 Subject: [U-Boot] [PATCH v1 1/2] fastboot: Add support to flash u-boot and MLO to QSPI In-Reply-To: <1424300035-19634-1-git-send-email-dileep.katta@linaro.org> References: <1424300035-19634-1-git-send-email-dileep.katta@linaro.org> Message-ID: <20150219142722.GJ25879@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Feb 19, 2015 at 04:23:54AM +0530, Dileep Katta wrote: > This adds the functionality to flash u-boot and MLO images to QSPI using fastboot [snip] > char response[RESPONSE_LEN]; > +#ifdef CONFIG_SPL_SPI_SUPPORT > + char source[32]; > + int status = 0; > + char *sf_probe[3] = {"sf", "probe", "0"}; > + char *sf_write_xloader[5] = {"sf", "write", NULL, "0", "20000"}; > + char *sf_update_xloader[5] = {"sf", "update", NULL, "0", "20000"}; > + char *sf_write_bl[5] = {"sf", "write", NULL, "80000", "80000"}; > + char *sf_update_bl[5] = {"sf", "update", NULL, "80000", "80000"}; > +#endif Here's what I don't like. 0 -> 0x20000 isn't horrible as it's the location for the first and second "MLO" locations, on a 64KiB sector QSPI flash, or just the first one on a 128KiB sector QSPI. But then we hard-code U-Boot to 0x80000 which isn't right. For example dra7xx_evm sets this to 0x40000 and we should just use CONFIG_SYS_SPI_U_BOOT_OFFS since that has to be set in the resulting binary to the right location. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: