From: Daniel Vetter Subject: Re: [PATCH v3] drm/i915: avoid processing spurious/shared interrupts in low-power states Date: Tue, 24 Feb 2015 01:07:28 +0100 Message-ID: <20150224000728.GI24485@phenom.ffwll.local> References: <1424685494-8556-1-git-send-email-imre.deak@intel.com> <1424701909-18373-1-git-send-email-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F60F6E042 for ; Mon, 23 Feb 2015 16:05:51 -0800 (PST) Received: by wghl2 with SMTP id l2so2049039wgh.9 for ; Mon, 23 Feb 2015 16:05:50 -0800 (PST) Content-Disposition: inline In-Reply-To: <1424701909-18373-1-git-send-email-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: Jani Nikula , Klaus Ethgen , intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMjMsIDIwMTUgYXQgMDQ6MzE6NDlQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IEF0bSwgaXQncyBwb3NzaWJsZSB0aGF0IHRoZSBpbnRlcnJ1cHQgaGFuZGxlciBpcyBjYWxs ZWQgd2hlbiB0aGUgZGV2aWNlCj4gaXMgaW4gRDMgb3Igc29tZSBvdGhlciBsb3ctcG93ZXIgc3Rh dGUuIEl0IGNhbiBiZSBkdWUgdG8gYW5vdGhlciBkZXZpY2UKPiB0aGF0IGlzIHN0aWxsIGluIEQw IHN0YXRlIGFuZCBzaGFyZXMgdGhlIGludGVycnVwdCBsaW5lIHdpdGggaTkxNSwgb3Igb24KPiBz b21lIHBsYXRmb3JtcyB0aGVyZSBjb3VsZCBiZSBzcHVyaW91cyBpbnRlcnJ1cHRzIGV2ZW4gd2l0 aG91dCBzaGFyaW5nCj4gdGhlIGludGVycnVwdCBsaW5lLiBUaGUgbGF0dGVyIGNhc2Ugd2FzIHJl cG9ydGVkIGJ5IEtsYXVzIEV0aGdlbiB1c2luZyBhCj4gTGVub3ZvIHg2MXAgbWFjaGluZSAoZ2Vu IDQpLiBIZSBub3RpY2VkIHRoaXMgaXNzdWUgdmlhIGEgc3lzdGVtCj4gc3VzcGVuZC9yZXN1bWUg aGFuZyBhbmQgYmlzZWN0ZWQgaXQgdG8gdGhlIGZvbGxvd2luZyBjb21taXQ6Cj4gCj4gY29tbWl0 IGUxMWFhMzYyMzA4ZjVkZTQ2N2NlMzU1YTJhMjQ3MTMyMWIxNWEzNWMKPiBBdXRob3I6IEplc3Nl IEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgo+IERhdGU6ICAgV2VkIEp1biAxOCAw OTo1Mjo1NSAyMDE0IC0wNzAwCj4gCj4gICAgIGRybS9pOTE1OiB1c2UgcnVudGltZSBpcnEgc3Vz cGVuZC9yZXN1bWUgaW4gZnJlZXplL3RoYXcKPiAKPiBUaGlzIGlzIGEgcHJvYmxlbSwgc2luY2Ug aW4gbG93LXBvd2VyIHN0YXRlcyBJSVIgd2lsbCBhbHdheXMgcmVhZAo+IDB4ZmZmZmZmZmYgcmVz dWx0aW5nIGluIGFuIGVuZGxlc3MgSVJRIHNlcnZpY2luZyBsb29wLgo+IAo+IEZpeCB0aGlzIGJ5 IGhhbmRsaW5nIGludGVycnVwdHMgb25seSB3aGVuIHRoZSBkcml2ZXIgZXhwbGljaXRseSBlbmFi bGVzCj4gdGhlbSBhbmQgc28gaXQncyBndWFyYW50ZWVkIHRoYXQgdGhlIGludGVycnVwdCByZWdp c3RlcnMgcmV0dXJuIGEgdmFsaWQKPiB2YWx1ZS4KPiAKPiBOb3RlIHRoYXQgdGhpcyBpc3N1ZSBl eGlzdGVkIGV2ZW4gYmVmb3JlIHRoZSBhYm92ZSBjb21taXQsIHNpbmNlIGR1cmluZwo+IHJ1bnRp bWUgc3VzcGVuZC9yZXN1bWUgd2UgbmV2ZXIgdW5yZWdpc3RlcmVkIHRoZSBoYW5kbGVyLgo+IAo+ IHYyOgo+IC0gY2xhcmlmeSB0aGUgcHVycG9zZSBvZiBzbXBfbWIoKSB2cy4gc3luY2hyb25pemVf aXJxKCkgaW4gdGhlCj4gICBjb2RlIGNvbW1lbnQgKENocmlzKQo+IAo+IHYzOgo+IC0gbm8gbmVl ZCBmb3IgYW4gZXhwbGljaXQgc21wX21iKCksIHdlIGNhbiBhc3N1bWUgdGhhdCBzeW5jaHJvbml6 ZV9pcnEoKQo+ICAgYW5kIHRoZSBtbWlvIHJlYWQvd3JpdGVzIGluIHRoZSBpbnN0YWxsIGhvb2tz IHByb3ZpZGUgZm9yIHRoaXMgKERhbmllbCkKPiAtIHJlbW92ZSBjb2RlIGNvbW1lbnQgYXMgdGhl IHJlbWFpbmluZyBzeW5jaHJvbml6ZV9pcnEoKSBpcyBzZWxmCj4gICBleHBsYW5hdG9yeSAoRGFu aWVsKQo+IAo+IFJlZmVyZW5jZTogaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTUvMi8xMS8yMDUK PiBSZXBvcnRlZC1hbmQtYmlzZWN0ZWQtYnk6IEtsYXVzIEV0aGdlbiA8S2xhdXNARXRoZ2VuLmNo Pgo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8IDIzICsrKysrKysrKysrKysrKysr KysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2lycS5jCj4gaW5kZXggOTA3MzExOS4uNjEyYzljMCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9pcnEuYwo+IEBAIC0xODg5LDYgKzE4ODksOSBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgdmFs bGV5dmlld19pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICphcmcpCj4gIAl1MzIgaWlyLCBndF9p aXIsIHBtX2lpcjsKPiAgCWlycXJldHVybl90IHJldCA9IElSUV9OT05FOwo+ICAKPiArCWlmICgh aW50ZWxfaXJxc19lbmFibGVkKGRldl9wcml2KSkKPiArCQlyZXR1cm4gSVJRX05PTkU7Cj4gKwo+ ICAJd2hpbGUgKHRydWUpIHsKPiAgCQkvKiBGaW5kLCBjbGVhciwgdGhlbiBwcm9jZXNzIGVhY2gg c291cmNlIG9mIGludGVycnVwdCAqLwo+ICAKPiBAQCAtMTkzMyw2ICsxOTM2LDkgQEAgc3RhdGlj IGlycXJldHVybl90IGNoZXJyeXZpZXdfaXJxX2hhbmRsZXIoaW50IGlycSwgdm9pZCAqYXJnKQo+ ICAJdTMyIG1hc3Rlcl9jdGwsIGlpcjsKPiAgCWlycXJldHVybl90IHJldCA9IElSUV9OT05FOwo+ ICAKPiArCWlmICghaW50ZWxfaXJxc19lbmFibGVkKGRldl9wcml2KSkKPiArCQlyZXR1cm4gSVJR X05PTkU7Cj4gKwo+ICAJZm9yICg7Oykgewo+ICAJCW1hc3Rlcl9jdGwgPSBJOTE1X1JFQUQoR0VO OF9NQVNURVJfSVJRKSAmIH5HRU44X01BU1RFUl9JUlFfQ09OVFJPTDsKPiAgCQlpaXIgPSBJOTE1 X1JFQUQoVkxWX0lJUik7Cj4gQEAgLTIyMDUsNiArMjIxMSw5IEBAIHN0YXRpYyBpcnFyZXR1cm5f dCBpcm9ubGFrZV9pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICphcmcpCj4gIAl1MzIgZGVfaWly LCBndF9paXIsIGRlX2llciwgc2RlX2llciA9IDA7Cj4gIAlpcnFyZXR1cm5fdCByZXQgPSBJUlFf Tk9ORTsKPiAgCj4gKwlpZiAoIWludGVsX2lycXNfZW5hYmxlZChkZXZfcHJpdikpCj4gKwkJcmV0 dXJuIElSUV9OT05FOwo+ICsKPiAgCS8qIFdlIGdldCBpbnRlcnJ1cHRzIG9uIHVuY2xhaW1lZCBy ZWdpc3RlcnMsIHNvIGNoZWNrIGZvciB0aGlzIGJlZm9yZSB3ZQo+ICAJICogZG8gYW55IEk5MTVf e1JFQUQsV1JJVEV9LiAqLwo+ICAJaW50ZWxfdW5jb3JlX2NoZWNrX2Vycm9ycyhkZXYpOwo+IEBA IC0yMjc2LDYgKzIyODUsOSBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgZ2VuOF9pcnFfaGFuZGxlcihp bnQgaXJxLCB2b2lkICphcmcpCj4gIAllbnVtIHBpcGUgcGlwZTsKPiAgCXUzMiBhdXhfbWFzayA9 IEdFTjhfQVVYX0NIQU5ORUxfQTsKPiAgCj4gKwlpZiAoIWludGVsX2lycXNfZW5hYmxlZChkZXZf cHJpdikpCj4gKwkJcmV0dXJuIElSUV9OT05FOwo+ICsKPiAgCWlmIChJU19HRU45KGRldikpCj4g IAkJYXV4X21hc2sgfD0gIEdFTjlfQVVYX0NIQU5ORUxfQiB8IEdFTjlfQVVYX0NIQU5ORUxfQyB8 Cj4gIAkJCUdFTjlfQVVYX0NIQU5ORUxfRDsKPiBAQCAtMzc2OCw2ICszNzgwLDkgQEAgc3RhdGlj IGlycXJldHVybl90IGk4eHhfaXJxX2hhbmRsZXIoaW50IGlycSwgdm9pZCAqYXJnKQo+ICAJCUk5 MTVfRElTUExBWV9QTEFORV9BX0ZMSVBfUEVORElOR19JTlRFUlJVUFQgfAo+ICAJCUk5MTVfRElT UExBWV9QTEFORV9CX0ZMSVBfUEVORElOR19JTlRFUlJVUFQ7Cj4gIAo+ICsJaWYgKCFpbnRlbF9p cnFzX2VuYWJsZWQoZGV2X3ByaXYpKQo+ICsJCXJldHVybiBJUlFfTk9ORTsKPiArCj4gIAlpaXIg PSBJOTE1X1JFQUQxNihJSVIpOwo+ICAJaWYgKGlpciA9PSAwKQo+ICAJCXJldHVybiBJUlFfTk9O RTsKPiBAQCAtMzk0OCw2ICszOTYzLDkgQEAgc3RhdGljIGlycXJldHVybl90IGk5MTVfaXJxX2hh bmRsZXIoaW50IGlycSwgdm9pZCAqYXJnKQo+ICAJCUk5MTVfRElTUExBWV9QTEFORV9CX0ZMSVBf UEVORElOR19JTlRFUlJVUFQ7Cj4gIAlpbnQgcGlwZSwgcmV0ID0gSVJRX05PTkU7Cj4gIAo+ICsJ aWYgKCFpbnRlbF9pcnFzX2VuYWJsZWQoZGV2X3ByaXYpKQo+ICsJCXJldHVybiBJUlFfTk9ORTsK PiArCj4gIAlpaXIgPSBJOTE1X1JFQUQoSUlSKTsKPiAgCWRvIHsKPiAgCQlib29sIGlycV9yZWNl aXZlZCA9IChpaXIgJiB+ZmxpcF9tYXNrKSAhPSAwOwo+IEBAIC00MTY4LDYgKzQxODYsOSBAQCBz dGF0aWMgaXJxcmV0dXJuX3QgaTk2NV9pcnFfaGFuZGxlcihpbnQgaXJxLCB2b2lkICphcmcpCj4g IAkJSTkxNV9ESVNQTEFZX1BMQU5FX0FfRkxJUF9QRU5ESU5HX0lOVEVSUlVQVCB8Cj4gIAkJSTkx NV9ESVNQTEFZX1BMQU5FX0JfRkxJUF9QRU5ESU5HX0lOVEVSUlVQVDsKPiAgCj4gKwlpZiAoIWlu dGVsX2lycXNfZW5hYmxlZChkZXZfcHJpdikpCj4gKwkJcmV0dXJuIElSUV9OT05FOwo+ICsKPiAg CWlpciA9IEk5MTVfUkVBRChJSVIpOwo+ICAKPiAgCWZvciAoOzspIHsKPiBAQCAtNDUwNCw2ICs0 NTI1LDcgQEAgdm9pZCBpbnRlbF9pcnFfdW5pbnN0YWxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAgCWRybV9pcnFfdW5pbnN0YWxsKGRldl9wcml2LT5kZXYpOwo+ICAJaW50 ZWxfaHBkX2NhbmNlbF93b3JrKGRldl9wcml2KTsKPiAgCWRldl9wcml2LT5wbS5pcnFzX2VuYWJs ZWQgPSBmYWxzZTsKPiArCXN5bmNocm9uaXplX2lycShkZXZfcHJpdi0+ZGV2LT5pcnEpOwoKZHJt X2lycV91bmluc3RhbGwgY2FsbHMgZnJlZV9pcnEgd2hpY2ggbWVhbnMgdGhlcmUncyBubyB3YXkg YXQgYWxsIGZvciBvdXIKaGFuZGxlciB0byBzdGlsbCBydW4uIFRoZSBzeW5jaHJvbml6ZV9pcnEg aGVyZSBpcyBoZW5jZSByZWR1bmRuYW50LiBXaXRoCnRoYXQgaHVuayByZW1vdmVkIHRoaXMgaXMK ClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAg fQo+ICAKPiAgLyoqCj4gQEAgLTQ1MTcsNiArNDUzOSw3IEBAIHZvaWQgaW50ZWxfcnVudGltZV9w bV9kaXNhYmxlX2ludGVycnVwdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ ICB7Cj4gIAlkZXZfcHJpdi0+ZGV2LT5kcml2ZXItPmlycV91bmluc3RhbGwoZGV2X3ByaXYtPmRl dik7Cj4gIAlkZXZfcHJpdi0+cG0uaXJxc19lbmFibGVkID0gZmFsc2U7Cj4gKwlzeW5jaHJvbml6 ZV9pcnEoZGV2X3ByaXYtPmRldi0+aXJxKTsKPiAgfQo+ICAKPiAgLyoqCj4gLS0gCj4gMi4xLjAK PiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==