From: Patrick McHardy Subject: Re: [PATCH nf] netfilter: nf_tables: fix addition/deletion of elements from commit/abort Date: Tue, 24 Feb 2015 14:39:33 +0000 Message-ID: <20150224143932.GA3713@acer.localdomain> References: <1424448670-4458-1-git-send-email-pablo@netfilter.org> <20150221103917.GA1683@acer.localdomain> <20150224135315.GA4322@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from stinky.trash.net ([213.144.137.162]:45067 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbbBXOjh (ORCPT ); Tue, 24 Feb 2015 09:39:37 -0500 Content-Disposition: inline In-Reply-To: <20150224135315.GA4322@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 24.02, Pablo Neira Ayuso wrote: > On Sat, Feb 21, 2015 at 10:39:18AM +0000, Patrick McHardy wrote: > > On 20.02, Pablo Neira Ayuso wrote: > > > We have several problems in this path: > > > > > > 1) There is a use-after-free when removing individual elements from > > > the commit path. > > > > > > 2) We have to uninit() the data part of the element from the abort > > > path to avoid a chain refcount leak. > > > > > > 3) We have to check for set->flags to see if there's a mapping, instead > > > of the element flags. > > > > > > 4) We have to check for !(flags & NFT_SET_ELEM_INTERVAL_END) to skip > > > elements that are part of the interval that have no data part, so > > > they don't need to be uninit(). > > > > Just wondering, in the delete case, don't we need to set the flags in > > the sets' ->get() function for this to work? > > They are already set from hash and rbtree, so we only need to add the > check for NFT_SET_ELEM_INTERVAL_END from the commit path in nf_tables_api.c > > Unless you have any further concern, I'll pass up this soon. Right, in the hash case it's 0 anyways and rbtree does set them. Looks good to me.