From: Daniel Vetter Subject: Re: [PATCH i-g-t 02/12] lib: Extract igt_buf_write_to_png() from gem_render_copy Date: Tue, 24 Feb 2015 22:49:14 +0100 Message-ID: <20150224214914.GK24485@phenom.ffwll.local> References: <1424707075-27605-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1424707075-27605-3-git-send-email-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id F22946E1D2 for ; Tue, 24 Feb 2015 13:47:37 -0800 (PST) Received: by mail-wi0-f179.google.com with SMTP id ex7so685939wid.0 for ; Tue, 24 Feb 2015 13:47:37 -0800 (PST) Content-Disposition: inline In-Reply-To: <1424707075-27605-3-git-send-email-tvrtko.ursulin@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBGZWIgMjMsIDIwMTUgYXQgMDM6NTc6NDVQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gRnJvbTogRGFtaWVuIExlc3BpYXUgPGRhbWllbi5sZXNwaWF1QGludGVsLmNvbT4K PiAKPiBOb3cgdGhhdCB0aGUgQW5kcm9pZCBidWlsZCBoYXMgY2Fpcm8sIHdlIGNhbiBwdXQgY2Fp cm8tZGVwZW5kYW50IGNvZGUKPiBiYWNrIGludG8gbGliLwo+IAo+IFNpZ25lZC1vZmYtYnk6IERh bWllbiBMZXNwaWF1IDxkYW1pZW4ubGVzcGlhdUBpbnRlbC5jb20+Cj4gLS0tCj4gIGxpYi9pbnRl bF9iYXRjaGJ1ZmZlci5jIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwo+ICBsaWIvaW50 ZWxfYmF0Y2hidWZmZXIuaCB8ICAyICsrCj4gIHRlc3RzL2dlbV9yZW5kZXJfY29weS5jIHwgMjQg KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9u cygrKSwgMjEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9pbnRlbF9iYXRjaGJ1 ZmZlci5jIGIvbGliL2ludGVsX2JhdGNoYnVmZmVyLmMKPiBpbmRleCBjNzBmNmQ4Li41MjI2OTEw IDEwMDY0NAo+IC0tLSBhL2xpYi9pbnRlbF9iYXRjaGJ1ZmZlci5jCj4gKysrIGIvbGliL2ludGVs X2JhdGNoYnVmZmVyLmMKPiBAQCAtMzEsNiArMzEsOCBAQAo+ICAjaW5jbHVkZSA8c3RyaW5nLmg+ Cj4gICNpbmNsdWRlIDxhc3NlcnQuaD4KPiAgCj4gKyNpbmNsdWRlIDxjYWlyby5oPgo+ICsKPiAg I2luY2x1ZGUgImRybS5oIgo+ICAjaW5jbHVkZSAiZHJtdGVzdC5oIgo+ICAjaW5jbHVkZSAiaW50 ZWxfYmF0Y2hidWZmZXIuaCIKPiBAQCAtNDU4LDYgKzQ2MCwyOSBAQCB1bnNpZ25lZCBpZ3RfYnVm X2hlaWdodChzdHJ1Y3QgaWd0X2J1ZiAqYnVmKQo+ICB9Cj4gIAo+ICAvKioKPiArICogaWd0X2J1 Zl93cml0ZV90b19wbmc6Cj4gKyAqIEBidWY6IGFuIGktZy10IGJ1ZmZlciBvYmplY3QKPiArICoK PiArICogV3JpdGVzIHRoZSBjb250ZW50IG9mIEBidWYgYXMgYSBQTkcgZmlsZQoKTWF5YmUgbWVu dGlvbiB0aGF0IHRoZSBidWZmZXIgaXMgaW50ZXJwcmV0ZWQgYXMgcmdieCBwaXhlbHMsIHRvby4K LURhbmllbAoKPiArICovCj4gK3ZvaWQgaWd0X2J1Zl93cml0ZV90b19wbmcoc3RydWN0IGlndF9i dWYgKmJ1ZiwgY29uc3QgY2hhciAqZmlsZW5hbWUpCj4gK3sKPiArCWNhaXJvX3N1cmZhY2VfdCAq c3VyZmFjZTsKPiArCWNhaXJvX3N0YXR1c190IHJldDsKPiArCj4gKwlkcm1faW50ZWxfYm9fbWFw KGJ1Zi0+Ym8sIDApOwo+ICsJc3VyZmFjZSA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfY3JlYXRlX2Zv cl9kYXRhKGJ1Zi0+Ym8tPnZpcnR1YWwsCj4gKwkJCQkJCSAgICAgIENBSVJPX0ZPUk1BVF9SR0Iy NCwKPiArCQkJCQkJICAgICAgaWd0X2J1Zl93aWR0aChidWYpLAo+ICsJCQkJCQkgICAgICBpZ3Rf YnVmX2hlaWdodChidWYpLAo+ICsJCQkJCQkgICAgICBidWYtPnN0cmlkZSk7Cj4gKwlyZXQgPSBj YWlyb19zdXJmYWNlX3dyaXRlX3RvX3BuZyhzdXJmYWNlLCBmaWxlbmFtZSk7Cj4gKwlpZ3RfYXNz ZXJ0KHJldCA9PSBDQUlST19TVEFUVVNfU1VDQ0VTUyk7Cj4gKwljYWlyb19zdXJmYWNlX2Rlc3Ry b3koc3VyZmFjZSk7Cj4gKwlkcm1faW50ZWxfYm9fdW5tYXAoYnVmLT5ibyk7Cj4gK30KPiArCj4g Ky8qKgo+ICAgKiBpZ3RfZ2V0X3JlbmRlcl9jb3B5ZnVuYzoKPiAgICogQGRldmlkOiBwY2kgZGV2 aWNlIGlkCj4gICAqCj4gZGlmZiAtLWdpdCBhL2xpYi9pbnRlbF9iYXRjaGJ1ZmZlci5oIGIvbGli L2ludGVsX2JhdGNoYnVmZmVyLmgKPiBpbmRleCAxMmY3YmUxLi5lMmFmYzNiIDEwMDY0NAo+IC0t LSBhL2xpYi9pbnRlbF9iYXRjaGJ1ZmZlci5oCj4gKysrIGIvbGliL2ludGVsX2JhdGNoYnVmZmVy LmgKPiBAQCAtMjEwLDYgKzIxMCw4IEBAIHN0cnVjdCBpZ3RfYnVmIHsKPiAgdW5zaWduZWQgaWd0 X2J1Zl93aWR0aChzdHJ1Y3QgaWd0X2J1ZiAqYnVmKTsKPiAgdW5zaWduZWQgaWd0X2J1Zl9oZWln aHQoc3RydWN0IGlndF9idWYgKmJ1Zik7Cj4gIAo+ICt2b2lkIGlndF9idWZfd3JpdGVfdG9fcG5n KHN0cnVjdCBpZ3RfYnVmICpidWYsIGNvbnN0IGNoYXIgKmZpbGVuYW1lKTsKPiArCj4gIC8qKgo+ ICAgKiBpZ3RfcmVuZGVyX2NvcHlmdW5jX3Q6Cj4gICAqIEBiYXRjaDogYmF0Y2hidWZmZXIgb2Jq ZWN0Cj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2dlbV9yZW5kZXJfY29weS5jIGIvdGVzdHMvZ2VtX3Jl bmRlcl9jb3B5LmMKPiBpbmRleCA2MzQ4ZWVlLi42YWE5ZTBkIDEwMDY0NAo+IC0tLSBhL3Rlc3Rz L2dlbV9yZW5kZXJfY29weS5jCj4gKysrIGIvdGVzdHMvZ2VtX3JlbmRlcl9jb3B5LmMKPiBAQCAt MzEsNyArMzEsNiBAQAo+ICAKPiAgI2luY2x1ZGUgPHN0ZGJvb2wuaD4KPiAgI2luY2x1ZGUgPHVu aXN0ZC5oPgo+IC0jaW5jbHVkZSA8Y2Fpcm8uaD4KPiAgI2luY2x1ZGUgPHN0ZGxpYi5oPgo+ICAj aW5jbHVkZSA8c3lzL2lvY3RsLmg+Cj4gICNpbmNsdWRlIDxzdGRpby5oPgo+IEBAIC03MSwyMyAr NzAsNiBAQCB0eXBlZGVmIHN0cnVjdCB7Cj4gIHN0YXRpYyBpbnQgb3B0X2R1bXBfcG5nID0gZmFs c2U7Cj4gIHN0YXRpYyBpbnQgY2hlY2tfYWxsX3BpeGVscyA9IGZhbHNlOwo+ICAKPiAtc3RhdGlj IHZvaWQgc2NyYXRjaF9idWZfd3JpdGVfdG9fcG5nKHN0cnVjdCBpZ3RfYnVmICpidWYsIGNvbnN0 IGNoYXIgKmZpbGVuYW1lKQo+IC17Cj4gLQljYWlyb19zdXJmYWNlX3QgKnN1cmZhY2U7Cj4gLQlj YWlyb19zdGF0dXNfdCByZXQ7Cj4gLQo+IC0JZHJtX2ludGVsX2JvX21hcChidWYtPmJvLCAwKTsK PiAtCXN1cmZhY2UgPSBjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZV9mb3JfZGF0YShidWYtPmJv LT52aXJ0dWFsLAo+IC0JCQkJCQkgICAgICBDQUlST19GT1JNQVRfUkdCMjQsCj4gLQkJCQkJCSAg ICAgIGlndF9idWZfd2lkdGgoYnVmKSwKPiAtCQkJCQkJICAgICAgaWd0X2J1Zl9oZWlnaHQoYnVm KSwKPiAtCQkJCQkJICAgICAgYnVmLT5zdHJpZGUpOwo+IC0JcmV0ID0gY2Fpcm9fc3VyZmFjZV93 cml0ZV90b19wbmcoc3VyZmFjZSwgZmlsZW5hbWUpOwo+IC0JaWd0X2Fzc2VydChyZXQgPT0gQ0FJ Uk9fU1RBVFVTX1NVQ0NFU1MpOwo+IC0JY2Fpcm9fc3VyZmFjZV9kZXN0cm95KHN1cmZhY2UpOwo+ IC0JZHJtX2ludGVsX2JvX3VubWFwKGJ1Zi0+Ym8pOwo+IC19Cj4gLQo+ICBzdGF0aWMgdm9pZCBz Y3JhdGNoX2J1Zl9pbml0KGRhdGFfdCAqZGF0YSwgc3RydWN0IGlndF9idWYgKmJ1ZiwKPiAgCQkJ ICAgICBpbnQgd2lkdGgsIGludCBoZWlnaHQsIGludCBzdHJpZGUsIHVpbnQzMl90IGNvbG9yKQo+ ICB7Cj4gQEAgLTE2NSw4ICsxNDcsOCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3Yp Cj4gIAlzY3JhdGNoX2J1Zl9jaGVjaygmZGF0YSwgJmRzdCwgV0lEVEggLyAyLCBIRUlHSFQgLyAy LCBEU1RfQ09MT1IpOwo+ICAKPiAgCWlmIChvcHRfZHVtcF9wbmcpIHsKPiAtCQlzY3JhdGNoX2J1 Zl93cml0ZV90b19wbmcoJnNyYywgInNvdXJjZS5wbmciKTsKPiAtCQlzY3JhdGNoX2J1Zl93cml0 ZV90b19wbmcoJmRzdCwgImRlc3RpbmF0aW9uLnBuZyIpOwo+ICsJCWlndF9idWZfd3JpdGVfdG9f cG5nKCZzcmMsICJzb3VyY2UucG5nIik7Cj4gKwkJaWd0X2J1Zl93cml0ZV90b19wbmcoJmRzdCwg ImRlc3RpbmF0aW9uLnBuZyIpOwo+ICAJfQo+ICAKPiAgCWlmIChvcHRfZHVtcF9hdWIpIHsKPiBA QCAtMTg4LDcgKzE3MCw3IEBAIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKPiAgCQkg ICAgJmRzdCwgV0lEVEggLyAyLCBIRUlHSFQgLyAyKTsKPiAgCj4gIAlpZiAob3B0X2R1bXBfcG5n KQo+IC0JCXNjcmF0Y2hfYnVmX3dyaXRlX3RvX3BuZygmZHN0LCAicmVzdWx0LnBuZyIpOwo+ICsJ CWlndF9idWZfd3JpdGVfdG9fcG5nKCZkc3QsICJyZXN1bHQucG5nIik7Cj4gIAo+ICAJaWYgKG9w dF9kdW1wX2F1Yikgewo+ICAJCWRybV9pbnRlbF9nZW1fYm9fYXViX2R1bXBfYm1wKGRzdC5ibywK PiAtLSAKPiAyLjMuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwg Q29ycG9yYXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=