From: Daniel Vetter Subject: Re: [PATCH 03/51] drm/i915: Cache ringbuf pointer in request structure Date: Wed, 25 Feb 2015 22:50:29 +0100 Message-ID: <20150225215029.GC24485@phenom.ffwll.local> References: <1423828140-10653-1-git-send-email-John.C.Harrison@Intel.com> <1423828140-10653-4-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTP id E4EA089C14 for ; Wed, 25 Feb 2015 13:48:51 -0800 (PST) Received: by wghn12 with SMTP id n12so6450620wgh.1 for ; Wed, 25 Feb 2015 13:48:50 -0800 (PST) Content-Disposition: inline In-Reply-To: <1423828140-10653-4-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMTMsIDIwMTUgYXQgMTE6NDg6MTJBTSArMDAwMCwgSm9obi5DLkhhcnJpc29u QEludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25A SW50ZWwuY29tPgo+IAo+IEluIGV4ZWNsaXN0IG1vZGUsIHRoZSByaW5nYnVmIGlzIGEgZnVuY3Rp b24gb2YgdGhlIHJpbmcgYW5kIGNvbnRleHQgd2hlcmVhcyBpbgo+IGxlZ2FjeSBtb2RlLCBpdCBp cyBkZXJpdmVkIGZyb20gdGhlIHJpbmcgYWxvbmUuIFRodXMgdGhlIGNhbGN1bGF0aW9uIHJlcXVp cmVkIHRvCj4gZGV0ZXJtaW5lIHRoZSByaW5nYnVmIHBvaW50ZXIgZnJvbSB0aGUgcmluZyAoYW5k IGNvbnRleHQpIGFsc28gbmVlZHMgdG8gdGVzdAo+IGV4ZWNsaXN0IG1vZGUgb3Igbm90LiBUaGlz IGlzIG1lc3N5Lgo+IAo+IEZ1cnRoZXIsIHRoZSByZXF1ZXN0IHN0cnVjdHVyZSBob2xkcyBhIHBv aW50ZXIgdG8gYm90aCB0aGUgcmluZyBhbmQgdGhlIGNvbnRleHQKPiBmb3Igd2hpY2ggaXQgd2Fz IGNyZWF0ZWQuIFRodXMsIGdpdmVuIGEgcmVxdWVzdCwgaXQgaXMgcG9zc2libGUgdG8gZGVyaXZl IHRoZQo+IHJpbmdidWYgaW4gZWl0aGVyIGxlZ2FjeSBvciBleGVjbGlzdCBtb2RlLiBIZW5jZSBp dCBpcyBuZWNlc3NhcnkgdG8gcGFzcyBqdXN0Cj4gdGhlIHJlcXVlc3QgaW4gdG8gYWxsIHRoZSBs b3cgbGV2ZWwgZnVuY3Rpb25zIHJhdGhlciB0aGFuIHNvbWUgY29tYmluYXRpb24gb2YKPiByZXF1 ZXN0LCByaW5nLCBjb250ZXh0IGFuZCByaW5nYnVmLiBIb3dldmVyLCByYXRoZXIgdGhhbiByZWNh bGN1bGF0aW5nIGl0IGVhY2gKPiB0aW1lLCBpdCBpcyBtdWNoIHNpbXBsZXIgdG8ganVzdCBjYWNo ZSB0aGUgcmluZ2J1ZiBwb2ludGVyIGluIHRoZSByZXF1ZXN0Cj4gc3RydWN0dXJlIGl0c2VsZi4K PiAKPiBDYWNoaW5nIHRoZSBwb2ludGVyIG1lYW5zIHRoZSBjYWxjdWxhdGlvbiBpcyBkb25lIG9u ZSBhdCByZXF1ZXN0IGNyZWF0aW9uIHRpbWUKCnMvb25lL29uY2UvIEkgZ3Vlc3M/Cgo+IGFuZCBh bGwgZnVydGhlciBjb2RlIGFuZCBzaW1wbHkgcmVhZCBpdCBkaXJlY3RseSBmcm9tIHRoZSByZXF1 ZXN0IHN0cnVjdHVyZS4KPiAKPiBGb3I6IFZJWi01MTE1Cj4gU2lnbmVkLW9mZi1ieTogSm9obiBI YXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgIHwgICAgMyArKy0KPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYyAgICAgICAgIHwgICAxNCArLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgfCAgICA2ICsrKystLQo+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCAgICAxICsKPiAgNCBmaWxlcyBjaGFu Z2VkLCA4IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+IGluZGV4IGYyYTgyNWUuLmU5MGI3ODYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmgKPiBAQCAtMjEzNyw4ICsyMTM3LDkgQEAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0 IHsKPiAgCS8qKiBQb3NpdGlvbiBpbiB0aGUgcmluZ2J1ZmZlciBvZiB0aGUgZW5kIG9mIHRoZSB3 aG9sZSByZXF1ZXN0ICovCj4gIAl1MzIgdGFpbDsKPiAgCj4gLQkvKiogQ29udGV4dCByZWxhdGVk IHRvIHRoaXMgcmVxdWVzdCAqLwo+ICsJLyoqIENvbnRleHQgYW5kIHJpbmcgYnVmZmVyIHJlbGF0 ZWQgdG8gdGhpcyByZXF1ZXN0ICovCj4gIAlzdHJ1Y3QgaW50ZWxfY29udGV4dCAqY3R4Owo+ICsJ c3RydWN0IGludGVsX3JpbmdidWZmZXIgKnJpbmdidWY7Cj4gIAo+ICAJLyoqIEJhdGNoIGJ1ZmZl ciByZWxhdGVkIHRvIHRoaXMgcmVxdWVzdCBpZiBhbnkgKi8KPiAgCXN0cnVjdCBkcm1faTkxNV9n ZW1fb2JqZWN0ICpiYXRjaF9vYmo7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggYzI2 ZDM2Yy4uMmViZTkxNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0yNzU4LDcg KzI3NTgsNiBAQCBpOTE1X2dlbV9yZXRpcmVfcmVxdWVzdHNfcmluZyhzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICpyaW5nKQo+ICAKPiAgCXdoaWxlICghbGlzdF9lbXB0eSgmcmluZy0+cmVxdWVzdF9s aXN0KSkgewo+ICAJCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdDsKPiAtCQlz dHJ1Y3QgaW50ZWxfcmluZ2J1ZmZlciAqcmluZ2J1ZjsKPiAgCj4gIAkJcmVxdWVzdCA9IGxpc3Rf Zmlyc3RfZW50cnkoJnJpbmctPnJlcXVlc3RfbGlzdCwKPiAgCQkJCQkgICBzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX3JlcXVlc3QsCj4gQEAgLTI3NjksMjMgKzI3NjgsMTIgQEAgaTkxNV9nZW1fcmV0aXJl X3JlcXVlc3RzX3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykKPiAgCj4gIAkJdHJh Y2VfaTkxNV9nZW1fcmVxdWVzdF9yZXRpcmUocmVxdWVzdCk7Cj4gIAo+IC0JCS8qIFRoaXMgaXMg b25lIG9mIHRoZSBmZXcgY29tbW9uIGludGVyc2VjdGlvbiBwb2ludHMKPiAtCQkgKiBiZXR3ZWVu IGxlZ2FjeSByaW5nYnVmZmVyIHN1Ym1pc3Npb24gYW5kIGV4ZWNsaXN0czoKPiAtCQkgKiB3ZSBu ZWVkIHRvIHRlbGwgdGhlbSBhcGFydCBpbiBvcmRlciB0byBmaW5kIHRoZSBjb3JyZWN0Cj4gLQkJ ICogcmluZ2J1ZmZlciB0byB3aGljaCB0aGUgcmVxdWVzdCBiZWxvbmdzIHRvLgo+IC0JCSAqLwo+ IC0JCWlmIChpOTE1LmVuYWJsZV9leGVjbGlzdHMpIHsKPiAtCQkJc3RydWN0IGludGVsX2NvbnRl eHQgKmN0eCA9IHJlcXVlc3QtPmN0eDsKPiAtCQkJcmluZ2J1ZiA9IGN0eC0+ZW5naW5lW3Jpbmct PmlkXS5yaW5nYnVmOwo+IC0JCX0gZWxzZQo+IC0JCQlyaW5nYnVmID0gcmluZy0+YnVmZmVyOwo+ IC0KPiAgCQkvKiBXZSBrbm93IHRoZSBHUFUgbXVzdCBoYXZlIHJlYWQgdGhlIHJlcXVlc3QgdG8g aGF2ZQo+ICAJCSAqIHNlbnQgdXMgdGhlIHNlcW5vICsgaW50ZXJydXB0LCBzbyB1c2UgdGhlIHBv c2l0aW9uCj4gIAkJICogb2YgdGFpbCBvZiB0aGUgcmVxdWVzdCB0byB1cGRhdGUgdGhlIGxhc3Qg a25vd24gcG9zaXRpb24KPiAgCQkgKiBvZiB0aGUgR1BVIGhlYWQuCj4gIAkJICovCj4gLQkJcmlu Z2J1Zi0+bGFzdF9yZXRpcmVkX2hlYWQgPSByZXF1ZXN0LT5wb3N0Zml4Owo+ICsJCXJlcXVlc3Qt PnJpbmdidWYtPmxhc3RfcmV0aXJlZF9oZWFkID0gcmVxdWVzdC0+cG9zdGZpeDsKPiAgCj4gIAkJ aTkxNV9nZW1fZnJlZV9yZXF1ZXN0KHJlcXVlc3QpOwo+ICAJfQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4gaW5kZXggNzNjMTg2MS4uNzYyMTM2YiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCj4gQEAgLTg3OCwxMiArODc4LDE0IEBAIHN0YXRpYyBpbnQgbG9naWNhbF9yaW5nX2Fs bG9jX3JlcXVlc3Qoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiAgCQlyZXR1cm4gcmV0 Owo+ICAJfQo+ICAKPiAtCS8qIEhvbGQgYSByZWZlcmVuY2UgdG8gdGhlIGNvbnRleHQgdGhpcyBy ZXF1ZXN0IGJlbG9uZ3MgdG8KPiArCS8qCj4gKwkgKiBIb2xkIGEgcmVmZXJlbmNlIHRvIHRoZSBj b250ZXh0IHRoaXMgcmVxdWVzdCBiZWxvbmdzIHRvCj4gIAkgKiAod2Ugd2lsbCBuZWVkIGl0IHdo ZW4gdGhlIHRpbWUgY29tZXMgdG8gZW1pdC9yZXRpcmUgdGhlCj4gLQkgKiByZXF1ZXN0KS4KPiAr CSAqIHJlcXVlc3QpLiBMaWtld2lzZSwgdGhlIHJpbmdidWZmIGlzIHVzZWZ1bCB0byBrZWVwIHRy YWNrIG9mLgo+ICAJICovCgpJbW8gdGhpcyBjb21tZW50IGlzIGEgYml0IHRvbyBvYnZpb3VzIHNv IEkganVzdCBkZWxldGVkIGl0IDstKQotRGFuaWVsCgo+ICAJcmVxdWVzdC0+Y3R4ID0gY3R4Owo+ ICAJaTkxNV9nZW1fY29udGV4dF9yZWZlcmVuY2UocmVxdWVzdC0+Y3R4KTsKPiArCXJlcXVlc3Qt PnJpbmdidWYgPSBjdHgtPmVuZ2luZVtyaW5nLT5pZF0ucmluZ2J1ZjsKPiAgCj4gIAlyaW5nLT5v dXRzdGFuZGluZ19sYXp5X3JlcXVlc3QgPSByZXF1ZXN0Owo+ICAJcmV0dXJuIDA7Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IGQ2MTE2MDguLmNhOWU3ZTYg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gQEAgLTIxMDAs NiArMjEwMCw3IEBAIGludGVsX3JpbmdfYWxsb2NfcmVxdWVzdChzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICpyaW5nKQo+ICAKPiAgCWtyZWZfaW5pdCgmcmVxdWVzdC0+cmVmKTsKPiAgCXJlcXVlc3Qt PnJpbmcgPSByaW5nOwo+ICsJcmVxdWVzdC0+cmluZ2J1ZiA9IHJpbmctPmJ1ZmZlcjsKPiAgCXJl cXVlc3QtPnVuaXEgPSBkZXZfcHJpdmF0ZS0+cmVxdWVzdF91bmlxKys7Cj4gIAo+ICAJcmV0ID0g aTkxNV9nZW1fZ2V0X3NlcW5vKHJpbmctPmRldiwgJnJlcXVlc3QtPnNlcW5vKTsKPiAtLSAKPiAx LjcuOS41Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==