From: Daniel Vetter Subject: Re: [PATCH 05/51] drm/i915: Add return code check to i915_gem_execbuffer_retire_commands() Date: Wed, 25 Feb 2015 23:17:00 +0100 Message-ID: <20150225221700.GE24485@phenom.ffwll.local> References: <1423828140-10653-1-git-send-email-John.C.Harrison@Intel.com> <1423828140-10653-6-git-send-email-John.C.Harrison@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f170.google.com (mail-we0-f170.google.com [74.125.82.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 04C3F6E348 for ; Wed, 25 Feb 2015 14:15:23 -0800 (PST) Received: by wesw55 with SMTP id w55so6458560wes.5 for ; Wed, 25 Feb 2015 14:15:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <1423828140-10653-6-git-send-email-John.C.Harrison@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John.C.Harrison@Intel.com Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBGZWIgMTMsIDIwMTUgYXQgMTE6NDg6MTRBTSArMDAwMCwgSm9obi5DLkhhcnJpc29u QEludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBKb2huIEhhcnJpc29uIDxKb2huLkMuSGFycmlzb25A SW50ZWwuY29tPgo+IAo+IEZvciBzb21lIHJlYXNvbiwgdGhlIGk5MTVfYWRkX3JlcXVlc3QoKSBj YWxsIGluCj4gaTkxNV9nZW1fZXhlY2J1ZmZlcl9yZXRpcmVfY29tbWFuZHMoKSB3YXMgZXhwbGlj aXRseSBoYXZpbmcgaXRzIHJldHVybiBjb2RlCj4gaWdub3JlZC4gVGhlIF9yZXRpcmVfY29tbWFu ZHMoKSBmdW5jdGlvbiBpdHNlbGYgd2FzICd2b2lkJy4gR2l2ZW4gdGhhdAo+IF9hZGRfcmVxdWVz dCgpIGNhbiBmYWlsIHdpdGhvdXQgZGlzcGF0Y2hpbmcgdGhlIGJhdGNoIGJ1ZmZlciwgdGhpcyBz ZWVtcyBvZGQuCgpJIHdhcyBzbyBjb252aW5jZWQgd2UndmUgaGFkIGEgY29tbWl0IHNvbWV3aGVy ZSBleHBsYWluaW5nIHRoaXMsIGJ1dAphcHBhcmVudGx5IG5vdC4KClRoZSBkZWFsIGlzIHRoYXQg YWZ0ZXIgdGhlIGRpc3BhdGNoIGNhbGwgd2UgaGF2ZSB0aGUgYmF0Y2ggY29tbWl0IGFuZAp0aGVy ZSdzIG5vIGdvaW5nIGJhY2sgYW55IG1vcmUsIHdoaWNoIGFsc28gbWVhbnMgd2UgY2FuJ3QgcmV0 dXJuIGFuIGVycm9yCmNvZGUgZnJvbSB0aGUgaW9jdGwuIFNvIGlmIHlvdSByZXR1cm4gLUVJTyBv ciAtRU5PTUVNIHRoYXQncyBhIHByZXR0eSBiYWQKbGllIGFuZCB5b3UgcmVhbGx5IGhhdmUgdG8g aWdub3JlIHRoYXQgZXJyb3IgY29kZS4KCkFnYWluIEkndmUgdHJpZWQgdG8gZGlnIHVwIHRoZSBj b21taXQgZm9yIHRoYXQgYnV0IHRoYXQgd2FzIGxvc3QgaW4gdGhlCm1hemUgb2YgdGhlIHBhc3Qg NSB5ZWFycyBvZiBjaGFuZ2VzLiBXZSd2ZSBoYWQgcGlsZXMgb2Ygb2xkZXIgYXBwcm9hY2hlcwp0 byBkZWFsIHdpdGggdGhpcyBpc3N1ZToKLSBEb24ndCBldmVuIGVtaXQgYSByZXF1ZXN0LCBqdXN0 IG1hcmsgb2JqZWN0cyBhcyBncHUgZGlydHkuIE9ubHkgd2hlbgogIHdhaXRpbmcgZGlkIHdlIGVt aXQgZmx1c2hlcyBhbmQgcmVxdWVzdHMsIHdoaWNoIGFnYWluIGFnYWluIGdhdmUgdXMgYQogIGNv bnRleHQgdG8gcmV0dXJuIHRoZSBlcnJvci4gVGhpcyByZXN1bHRlZCBpbiBob3JyaWJsZSBsYXRl bmN5IHNpbmNlCiAgZmx1c2hlcyB3aGVyZSB3YWl0IHRvbyBsYXRlIGFuZCBhbHNvIGFsbCB0aGF0 IGJvb2sta2VlcGluZyB3YXMgbm90IHdvcnRoCiAgaXQgYXQgYWxsLiBEb24ndCBhc2sgOy0pCi0g RW1pdCBmbHVzaGVzIHJpZ2h0IGF3YXksIGJ1dCBpZiB3ZSBmYWlsIHRvIGFsbG9jIHRoZSByZXF1 ZXN0IHNldCB0aGUKICBvdXRzdGFuZGluZyBsYXp5IHJlcXVlc3QgYml0LiBUaGUgam9iIG9mIHRo ZSBjaGVja19vbHIgZnVuY3Rpb24gdXNlZCBpbgogIHdhaXRzIHdhcyB0byBub3RpY2UgdGhhdCBh bmQgcmV0cnkgdGhlIGFsbG9jYXRpb24uCi0gUHJlYWxsb2NhdGUgdGhlIHJlcXVlc3QsIGJ1dCB0 aGF0IHN0aWxsIGxlYXZlcyB0aGUgcG9zc2liaWxpdHkgdGhhdCB0aGUKICBncHUgZGllcy4gQnV0 IHNpbmNlIHdlJ3ZlIGNvbW1pdHRlZCBoYW5nY2hlY2sgd2lsbCBjbGVhbiB0aGlzIHVwIGFuZCB3 ZQogIGNhbiBqdXN0IGlnbm9yZSB0aGUgLUVJTy4KCkdpdmVuIGFsbCB0aGF0IGJhY2tzdG9yeTog V2h5IGRvZXMgYWRkX3JlcXVlc3QvcmV0aXJlX2NvbW1hbmRzIHN1ZGRlbmx5Cm5lZWQgdG8gZmFp bD8KCkNoZWVycywgRGFuaWVsCgo+IEFsc28gc2hydW5rIHRoZSBwYXJhbWV0ZXIgbGlzdCB0byBh IHNpbmdsZSBzdHJ1Y3R1cmUgYXMgZXZlcnl0aGluZyBpdCByZXF1aXJlcwo+IGlzIGF2YWlsYWJs ZSBpbiB0aGUgZXhlY2J1ZmZfcGFyYW1zIG9iamVjdC4KPiAKPiBGb3I6IFZJWi01MTE1Cj4gU2ln bmVkLW9mZi1ieTogSm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgICAgIHwgICAgNSAr LS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgfCAgIDE2 ICsrKysrKystLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgICAg ICAgICAgIHwgICAgMyArLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDE1 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IGU2ZDYxNmIu LjE0M2JjNjMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjYyNCwxMCArMjYy NCw3IEBAIGludCBpOTE1X2dlbV9zd19maW5pc2hfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgdm9pZCAqZGF0YSwKPiAgCQkJICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdik7Cj4g IHZvaWQgaTkxNV9nZW1fZXhlY2J1ZmZlcl9tb3ZlX3RvX2FjdGl2ZShzdHJ1Y3QgbGlzdF9oZWFk ICp2bWFzLAo+ICAJCQkJCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpOwo+IC12b2lkIGk5 MTVfZ2VtX2V4ZWNidWZmZXJfcmV0aXJlX2NvbW1hbmRzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs Cj4gLQkJCQkJIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiAtCQkJCQkgc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqcmluZywKPiAtCQkJCQkgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaik7 Cj4gK2ludCBpOTE1X2dlbV9leGVjYnVmZmVyX3JldGlyZV9jb21tYW5kcyhzdHJ1Y3QgaTkxNV9l eGVjYnVmZmVyX3BhcmFtcyAqcGFyYW1zKTsKPiAgaW50IGk5MTVfZ2VtX3JpbmdidWZmZXJfc3Vi bWlzc2lvbihzdHJ1Y3QgaTkxNV9leGVjYnVmZmVyX3BhcmFtcyAqcGFyYW1zLAo+ICAJCQkJICAg c3RydWN0IGRybV9pOTE1X2dlbV9leGVjYnVmZmVyMiAqYXJncywKPiAgCQkJCSAgIHN0cnVjdCBs aXN0X2hlYWQgKnZtYXMpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9leGVjYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVm ZmVyLmMKPiBpbmRleCA5M2IwZWYwLi5jYTg1ODAzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+IEBAIC05ODksMTcgKzk4OSwxNSBAQCBpOTE1X2dl bV9leGVjYnVmZmVyX21vdmVfdG9fYWN0aXZlKHN0cnVjdCBsaXN0X2hlYWQgKnZtYXMsCj4gIAl9 Cj4gIH0KPiAgCj4gLXZvaWQKPiAtaTkxNV9nZW1fZXhlY2J1ZmZlcl9yZXRpcmVfY29tbWFuZHMo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAtCQkJCSAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGUs Cj4gLQkJCQkgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiAtCQkJCSAgICBzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqKQo+ICtpbnQKPiAraTkxNV9nZW1fZXhlY2J1ZmZl cl9yZXRpcmVfY29tbWFuZHMoc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcykK PiAgewo+ICAJLyogVW5jb25kaXRpb25hbGx5IGZvcmNlIGFkZF9yZXF1ZXN0IHRvIGVtaXQgYSBm dWxsIGZsdXNoLiAqLwo+IC0JcmluZy0+Z3B1X2NhY2hlc19kaXJ0eSA9IHRydWU7Cj4gKwlwYXJh bXMtPnJpbmctPmdwdV9jYWNoZXNfZGlydHkgPSB0cnVlOwo+ICAKPiAgCS8qIEFkZCBhIGJyZWFk Y3J1bWIgZm9yIHRoZSBjb21wbGV0aW9uIG9mIHRoZSBiYXRjaCBidWZmZXIgKi8KPiAtCSh2b2lk KV9faTkxNV9hZGRfcmVxdWVzdChyaW5nLCBmaWxlLCBvYmopOwo+ICsJcmV0dXJuIF9faTkxNV9h ZGRfcmVxdWVzdChwYXJhbXMtPnJpbmcsIHBhcmFtcy0+ZmlsZSwKPiArCQkJCSAgcGFyYW1zLT5i YXRjaF9vYmopOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50Cj4gQEAgLTEyODIsOCArMTI4MCw4IEBA IGk5MTVfZ2VtX3JpbmdidWZmZXJfc3VibWlzc2lvbihzdHJ1Y3QgaTkxNV9leGVjYnVmZmVyX3Bh cmFtcyAqcGFyYW1zLAo+ICAJdHJhY2VfaTkxNV9nZW1fcmluZ19kaXNwYXRjaChpbnRlbF9yaW5n X2dldF9yZXF1ZXN0KHJpbmcpLCBwYXJhbXMtPmRpc3BhdGNoX2ZsYWdzKTsKPiAgCj4gIAlpOTE1 X2dlbV9leGVjYnVmZmVyX21vdmVfdG9fYWN0aXZlKHZtYXMsIHJpbmcpOwo+IC0JaTkxNV9nZW1f ZXhlY2J1ZmZlcl9yZXRpcmVfY29tbWFuZHMocGFyYW1zLT5kZXYsIHBhcmFtcy0+ZmlsZSwgcmlu ZywKPiAtCQkJCQkgICAgcGFyYW1zLT5iYXRjaF9vYmopOwo+ICsKPiArCXJldCA9IGk5MTVfZ2Vt X2V4ZWNidWZmZXJfcmV0aXJlX2NvbW1hbmRzKHBhcmFtcyk7Cj4gIAo+ICBlcnJvcjoKPiAgCWtm cmVlKGNsaXByZWN0cyk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBpbmRleCBjYTI5Mjkw Li45MDQwMGQwZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTcwNiw5ICs3 MDYsOCBAQCBpbnQgaW50ZWxfZXhlY2xpc3RzX3N1Ym1pc3Npb24oc3RydWN0IGk5MTVfZXhlY2J1 ZmZlcl9wYXJhbXMgKnBhcmFtcywKPiAgCXRyYWNlX2k5MTVfZ2VtX3JpbmdfZGlzcGF0Y2goaW50 ZWxfcmluZ19nZXRfcmVxdWVzdChyaW5nKSwgcGFyYW1zLT5kaXNwYXRjaF9mbGFncyk7Cj4gIAo+ ICAJaTkxNV9nZW1fZXhlY2J1ZmZlcl9tb3ZlX3RvX2FjdGl2ZSh2bWFzLCByaW5nKTsKPiAtCWk5 MTVfZ2VtX2V4ZWNidWZmZXJfcmV0aXJlX2NvbW1hbmRzKHBhcmFtcy0+ZGV2LCBwYXJhbXMtPmZp bGUsIHJpbmcsIHBhcmFtcy0+YmF0Y2hfb2JqKTsKPiAgCj4gLQlyZXR1cm4gMDsKPiArCXJldHVy biBpOTE1X2dlbV9leGVjYnVmZmVyX3JldGlyZV9jb21tYW5kcyhwYXJhbXMpOwo+ICB9Cj4gIAo+ ICB2b2lkIGludGVsX2V4ZWNsaXN0c19yZXRpcmVfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqcmluZykKPiAtLSAKPiAxLjcuOS41Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2NSA1NyA0OCAtIGh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==