Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12;
Date: Tue, 3 Mar 2015 08:52:05 -0800
From: Greg KH <gregkh@linuxfoundation.org>
To: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v10 4/4] Staging: emxx_udc: Clean
 dev_err() logging
Message-ID: <20150303165205.GA8132@kroah.com>
References: <1425320718-28979-1-git-send-email-hamohammed.sa@gmail.com>
 <1425321923-4125-1-git-send-email-hamohammed.sa@gmail.com>
 <20150302185412.GA13368@kroah.com>
 <20150302190228.GA12872@example.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150302190228.GA12872@example.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

On Mon, Mar 02, 2015 at 10:02:28PM +0300, Haneen Mohammed wrote:
> On Mon, Mar 02, 2015 at 10:54:12AM -0800, Greg KH wrote:
> > On Mon, Mar 02, 2015 at 09:45:23PM +0300, Haneen Mohammed wrote:
> > > This patch removes  __func__ from dev_err.
> > > dev_err includes the function name in the log printout, so there is no
> > > need to include it manually.
> > 
> > No, dev_err() does not include the function name, it includes much more
> > than that (device, driver, specific instance of device, etc.).
> > 
> Noted. I learned about this from the logs. 
> should I edit the commit msg and resed the patch?

Yes please.