From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active() Date: Wed, 4 Mar 2015 17:13:07 +0100 Message-ID: <20150304161307.GH18775@phenom.ffwll.local> References: <1425435313-31711-1-git-send-email-matthew.d.roper@intel.com> <20150304094542.GK11371@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTP id DB31F6E689 for ; Wed, 4 Mar 2015 08:11:58 -0800 (PST) Received: by widem10 with SMTP id em10so32033313wid.1 for ; Wed, 04 Mar 2015 08:11:58 -0800 (PST) Content-Disposition: inline In-Reply-To: <20150304094542.GK11371@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMDQsIDIwMTUgYXQgMTE6NDU6NDJBTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgTWFyIDAzLCAyMDE1IGF0IDA2OjE1OjEyUE0gLTA4MDAsIE1hdHQg Um9wZXIgd3JvdGU6Cj4gPiBVbml2ZXJzYWwgcGxhbmVzIGFsbG93IHVzIHRvIGhhdmUgYW4gYWN0 aXZlIENSVEMgd2l0aG91dCBhIHByaW1hcnkgcGxhbmUKPiA+IGZyYW1lYnVmZmVyIGJvdW5kLiAg RHJvcCB0aGUgdGVzdCBmb3IgcHJpbWFyeS0+ZmIgZnJvbQo+ID4gaW50ZWxfY3J0Y19hY3RpdmUo KSBzaW5jZSB3ZSBjYW4gY2xlYXJseSBoYXZlIGFjdGl2ZSBDUlRDJ3Mgd2l0aG91dCBhCj4gPiBm cmFtZWJ1ZmZlciwgYW5kIHRoaXMgY2hlY2sgaXMgbm93IGludGVyZmVyaW5nIHdpdGggd2F0ZXJt YXJrCj4gPiBjYWxjdWxhdGlvbnMgd2hlbiB3ZSB0cnkgdG8gcmUtZW5hYmxlIHRoZSBwcmltYXJ5 IHBsYW5lLgo+ID4gCj4gPiBOb3RlIHRoYXQgY29tbWl0Cj4gPiAKPiA+ICAgICAgICAgY29tbWl0 IDBmZGE2NTY4MGU5MjU0NWNhZWE1YmU3ODA1YTdmMGE2MTdmYjZjMjAKPiA+ICAgICAgICAgQXV0 aG9yOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+ID4gICAgICAg ICBEYXRlOiAgIEZyaSBGZWIgMjcgMTU6MTI6MzUgMjAxNSArMDAwMAo+ID4gCj4gPiAgICAgICAg ICAgICBkcm0vaTkxNS9za2w6IFVwZGF0ZSB3YXRlcm1hcmtzIGZvciBZIHRpbGluZwo+ID4gCj4g PiBhZGRzIGEgdGVzdCBmb3IgcHJpbWFyeSBwbGFuZSBlbmFibGUvZGlzYWJsZSB0byB0cmlnZ2Vy IGEgd2F0ZXJtYXJrCj4gPiB1cGRhdGUgKHByZXZpb3VzbHkgd2UgaWdub3JlZCB1cGRhdGVzIHRv IHByaW1hcnkgcGxhbmVzLCB3aGljaCB3YXNuJ3QKPiA+IHJlYWxseSBjb3JyZWN0LCBidXQgd2Ug Z290IGx1Y2t5IHNpbmNlIHdlIGFsd2F5cyBwcmV0ZW5kZWQgdGhlIHByaW1hcnkKPiA+IHBsYW5l IHdhcyBvbikuICBUdnJ0a28ncyBwYXRjaCB0cmllcyB0byB1cGRhdGUgd2F0ZXJtYXJrcyB3aGVu IHdlCj4gPiByZS1lbmFibGUgdGhlIHByaW1hcnkgcGxhbmUsIGJ1dCB0aGF0IHdhdGVybWFyayBj b21wdXRhdGlvbiBnZXRzIGFib3J0ZWQKPiA+IGVhcmx5IGJlY2F1c2UgaW50ZWxfY3J0Y19hY3Rp dmUoKSBhbHdheXMgcmV0dXJucyBmYWxzZSB3aGVuIHRoZSBwcmltYXJ5Cj4gPiBwbGFuZSBpcyBk aXNhYmxlZDsgdGhpcyBsZWFkcyB0byB3YXRlcm1hcmsgdW5kZXJydW5zIChhdCBsZWFzdCBvbgo+ ID4gcGxhdGZvcm1zIHdpdGggSUxLLXN0eWxlIHdhdGVybWFyayBjb2RlKS4KPiAKPiBJIHRoaW5r IHRoaXMgd2lsbCBtYWtlIGEgYnVuY2ggb2YgdGhlIG9sZCBwbGF0Zm9ybXMgYmxvdyB1cC4gV2Vs bCwgSQo+IHRoaW5rIHRoZXkgbWlnaHQgYWxyZWFkeSBibG93IHVwIHNpbmNlIHRoZXkgbm93IGxv b2sgYXQgY3J0Yy0+c3RhdGUtPmZiCj4gYmFzZWQgb24gdGhlIHJlc3VsdCBvZiBpbnRlbF9jcnRj X2FjdGl2ZSgpLiBTbyBJIGJlbGlldmUgbW9yZSBmaXhlcyBhcmUKPiBuZWVkZWQgYWxsIG92ZXIg dGhlIHdtIGNvZGUgYXQgbGVhc3QuCj4gCj4gSW4gZmFjdCBsb29raW5nIGF0IHRoZSBjb2RlLCBJ IHRoaW5rIG1vc3QgKG9yIGFsbD8pIG9mIHRoZSBjYWxsIHNpdGVzIGluCj4gdGhlIGluIHRoZSBp bGsrIHdtIGNvZGUgc2hvdWxkIGp1c3QgYmUgdXNpbmcgY3J0Yy0+YWN0aXZlLiBTbyBmb3Igc29t ZQo+IGV4dHJhIHNhZmV0eSBpdCBtaWdodCBtYWtlIHNlbnNlIHRvIGRvIGxlYXZlIGludGVsX2Ny dGNfYWN0aXZlKCkgYWxvbmUKPiBmb3Igbm93LCBvciBpbiBmYWN0IHdlIHNob3VsZCBtYXliZSBj aGFuZ2UgaXQgdG8gYWxzbyBsb29rIGF0Cj4gcHJpbWFyeS0+c3RhdGUtPmZiIGluc3RlYWQuIFRo YXQgc2hvdWxkIG1vcmUgb3IgbGVzcyBrZWVwIHRoZSBvbGQKPiBwbGF0Zm9ybXMgaW4gdGhlIHNh bWUgc3RhdGUgYXMgdGhleSB3ZXJlIGJlZm9yZSwgd2hpbGUgbGV0dGluZyBuZXcKPiBwbGF0Zm9y bXMgaGFuZGxlIGVhY2ggcGxhbmUgcHJvcGVybHkuCgppbnRlbF9jcnRjLT5hY3RpdmUgc2hvdWxk bid0IGJlIHVzZWQgYW55d2hlcmUgaW4gc3RhdGUgY29tcHV0YXRpb24gY29kZS4KVGhlIG9ubHkg dGhpbmcgeW91J3JlIGFsbG93ZWQgdG8gbG9vayBhdCBpcyBjcnRjX3N0YXRlLT5lbmFibGUgaW4g dGhlCmF0b21pYyB3b3JsZC4KCk90aGVyd2lzZSByZXNvdXJjZSBhbGxvY2F0aW9uIGlzbid0IHBy b3Blcmx5IGRvbmUgd2hlbiB0aGUgcGlwZSBpcyBpbiBkcG1zCm9mZiBzdGF0ZSBhbmQgdGhlbiBz dHVmZiBibG93cyB1cCB3aGVuIHVzZXJzcGFjZSB0cmllcyB0byBkcG1zIG9uLiBXaGljaAppcyBh IGJpZyBuby1ubywgYXQgbGVhc3QgZm9yIHByb3BlciBiYWNrd2FyZHMgY29tcGF0LgotRGFuaWVs Cgo+IAo+ID4gCj4gPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNv bT4KPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5j b20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA1 ICstLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCA0IGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA1ODlh ZGRmLi45MmNiMmZmIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiA+IEBAIC04OTMsMTEgKzg5Myw4IEBAIGJvb2wgaW50ZWxfY3J0Y19hY3RpdmUoc3RydWN0IGRy bV9jcnRjICpjcnRjKQo+ID4gIAkgKgo+ID4gIAkgKiBXZSBjYW4gZGl0Y2ggdGhlIGFkanVzdGVk X21vZGUuY3J0Y19jbG9jayBjaGVjayBhcyBzb29uCj4gPiAgCSAqIGFzIEhhc3dlbGwgaGFzIGdh aW5lZCBjbG9jayByZWFkb3V0L2Zhc3Rib290IHN1cHBvcnQuCj4gPiAtCSAqCj4gPiAtCSAqIFdl IGNhbiBkaXRjaCB0aGUgY3J0Yy0+cHJpbWFyeS0+ZmIgY2hlY2sgYXMgc29vbiBhcyB3ZSBjYW4K PiA+IC0JICogcHJvcGVybHkgcmVjb25zdHJ1Y3QgZnJhbWVidWZmZXJzLgo+ID4gIAkgKi8KPiA+ IC0JcmV0dXJuIGludGVsX2NydGMtPmFjdGl2ZSAmJiBjcnRjLT5wcmltYXJ5LT5mYiAmJgo+ID4g KwlyZXR1cm4gaW50ZWxfY3J0Yy0+YWN0aXZlICYmCj4gPiAgCQlpbnRlbF9jcnRjLT5jb25maWct PmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2Nsb2NrOwo+ID4gIH0KPiA+ICAKPiA+IC0tIAo+ID4g MS44LjUuMQo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsIE9UQwo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAK RGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQxICgw KSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=