From: Tom Rini Date: Wed, 4 Mar 2015 17:16:13 -0500 Subject: [U-Boot] [PATCH v6 4/6] arm: spl: Allow board_init_r() to run with a larger stack In-Reply-To: <1425394982-16196-5-git-send-email-sjg@chromium.org> References: <1425394982-16196-1-git-send-email-sjg@chromium.org> <1425394982-16196-5-git-send-email-sjg@chromium.org> Message-ID: <20150304221613.GD25373@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Mar 03, 2015 at 08:03:00AM -0700, Simon Glass wrote: > At present SPL uses a single stack, either CONFIG_SPL_STACK or > CONFIG_SYS_INIT_SP_ADDR. Since some SPL features (such as MMC and > environment) require a lot of stack, some boards set CONFIG_SPL_STACK to > point into SDRAM. They then set up SDRAM very early, before board_init_f(), > so that the larger stack can be used. > > This is an abuse of lowlevel_init(). That function should only be used for > essential start-up code which cannot be delayed. An example of a valid use is > when only part of the SPL code is visible/executable, and the SoC must be set > up so that board_init_f() can be reached. It should not be used for SDRAM > init, console init, etc. > > Add a CONFIG_SPL_STACK_R option, which allows the stack to be moved to a new > address before board_init_r() is called in SPL. > > The expected SPL flow (for CONFIG_SPL_FRAMEWORK) is documented in the README. > > Signed-off-by: Simon Glass > For version 1: > Acked-by: Albert ARIBAUD > Reviewed-by: Stefan Roese > Tested-by: Bo Shen > Acked-by: Bo Shen > Acked-by: Heiko Schocher > Tested-by: Heiko Schocher After fixing the Kconfig part to not have 'CONFIG_' in the 'config' and 'depends' lines, applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: