From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active() Date: Thu, 5 Mar 2015 13:20:17 +0100 Message-ID: <20150305122017.GW18775@phenom.ffwll.local> References: <1425435313-31711-1-git-send-email-matthew.d.roper@intel.com> <20150304094542.GK11371@intel.com> <20150304161307.GH18775@phenom.ffwll.local> <20150304182116.GV11371@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by gabe.freedesktop.org (Postfix) with ESMTP id F03CC6E29B for ; Thu, 5 Mar 2015 04:18:38 -0800 (PST) Received: by wevm14 with SMTP id m14so52539678wev.8 for ; Thu, 05 Mar 2015 04:18:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <20150304182116.GV11371@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBNYXIgMDQsIDIwMTUgYXQgMDg6MjE6MTZQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgTWFyIDA0LCAyMDE1IGF0IDA1OjEzOjA3UE0gKzAxMDAsIERhbmll bCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBXZWQsIE1hciAwNCwgMjAxNSBhdCAxMTo0NTo0MkFNICsw MjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+IE9uIFR1ZSwgTWFyIDAzLCAyMDE1IGF0 IDA2OjE1OjEyUE0gLTA4MDAsIE1hdHQgUm9wZXIgd3JvdGU6Cj4gPiA+ID4gVW5pdmVyc2FsIHBs YW5lcyBhbGxvdyB1cyB0byBoYXZlIGFuIGFjdGl2ZSBDUlRDIHdpdGhvdXQgYSBwcmltYXJ5IHBs YW5lCj4gPiA+ID4gZnJhbWVidWZmZXIgYm91bmQuICBEcm9wIHRoZSB0ZXN0IGZvciBwcmltYXJ5 LT5mYiBmcm9tCj4gPiA+ID4gaW50ZWxfY3J0Y19hY3RpdmUoKSBzaW5jZSB3ZSBjYW4gY2xlYXJs eSBoYXZlIGFjdGl2ZSBDUlRDJ3Mgd2l0aG91dCBhCj4gPiA+ID4gZnJhbWVidWZmZXIsIGFuZCB0 aGlzIGNoZWNrIGlzIG5vdyBpbnRlcmZlcmluZyB3aXRoIHdhdGVybWFyawo+ID4gPiA+IGNhbGN1 bGF0aW9ucyB3aGVuIHdlIHRyeSB0byByZS1lbmFibGUgdGhlIHByaW1hcnkgcGxhbmUuCj4gPiA+ ID4gCj4gPiA+ID4gTm90ZSB0aGF0IGNvbW1pdAo+ID4gPiA+IAo+ID4gPiA+ICAgICAgICAgY29t bWl0IDBmZGE2NTY4MGU5MjU0NWNhZWE1YmU3ODA1YTdmMGE2MTdmYjZjMjAKPiA+ID4gPiAgICAg ICAgIEF1dGhvcjogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiA+ ID4gPiAgICAgICAgIERhdGU6ICAgRnJpIEZlYiAyNyAxNToxMjozNSAyMDE1ICswMDAwCj4gPiA+ ID4gCj4gPiA+ID4gICAgICAgICAgICAgZHJtL2k5MTUvc2tsOiBVcGRhdGUgd2F0ZXJtYXJrcyBm b3IgWSB0aWxpbmcKPiA+ID4gPiAKPiA+ID4gPiBhZGRzIGEgdGVzdCBmb3IgcHJpbWFyeSBwbGFu ZSBlbmFibGUvZGlzYWJsZSB0byB0cmlnZ2VyIGEgd2F0ZXJtYXJrCj4gPiA+ID4gdXBkYXRlIChw cmV2aW91c2x5IHdlIGlnbm9yZWQgdXBkYXRlcyB0byBwcmltYXJ5IHBsYW5lcywgd2hpY2ggd2Fz bid0Cj4gPiA+ID4gcmVhbGx5IGNvcnJlY3QsIGJ1dCB3ZSBnb3QgbHVja3kgc2luY2Ugd2UgYWx3 YXlzIHByZXRlbmRlZCB0aGUgcHJpbWFyeQo+ID4gPiA+IHBsYW5lIHdhcyBvbikuICBUdnJ0a28n cyBwYXRjaCB0cmllcyB0byB1cGRhdGUgd2F0ZXJtYXJrcyB3aGVuIHdlCj4gPiA+ID4gcmUtZW5h YmxlIHRoZSBwcmltYXJ5IHBsYW5lLCBidXQgdGhhdCB3YXRlcm1hcmsgY29tcHV0YXRpb24gZ2V0 cyBhYm9ydGVkCj4gPiA+ID4gZWFybHkgYmVjYXVzZSBpbnRlbF9jcnRjX2FjdGl2ZSgpIGFsd2F5 cyByZXR1cm5zIGZhbHNlIHdoZW4gdGhlIHByaW1hcnkKPiA+ID4gPiBwbGFuZSBpcyBkaXNhYmxl ZDsgdGhpcyBsZWFkcyB0byB3YXRlcm1hcmsgdW5kZXJydW5zIChhdCBsZWFzdCBvbgo+ID4gPiA+ IHBsYXRmb3JtcyB3aXRoIElMSy1zdHlsZSB3YXRlcm1hcmsgY29kZSkuCj4gPiA+IAo+ID4gPiBJ IHRoaW5rIHRoaXMgd2lsbCBtYWtlIGEgYnVuY2ggb2YgdGhlIG9sZCBwbGF0Zm9ybXMgYmxvdyB1 cC4gV2VsbCwgSQo+ID4gPiB0aGluayB0aGV5IG1pZ2h0IGFscmVhZHkgYmxvdyB1cCBzaW5jZSB0 aGV5IG5vdyBsb29rIGF0IGNydGMtPnN0YXRlLT5mYgo+ID4gPiBiYXNlZCBvbiB0aGUgcmVzdWx0 IG9mIGludGVsX2NydGNfYWN0aXZlKCkuIFNvIEkgYmVsaWV2ZSBtb3JlIGZpeGVzIGFyZQo+ID4g PiBuZWVkZWQgYWxsIG92ZXIgdGhlIHdtIGNvZGUgYXQgbGVhc3QuCj4gPiA+IAo+ID4gPiBJbiBm YWN0IGxvb2tpbmcgYXQgdGhlIGNvZGUsIEkgdGhpbmsgbW9zdCAob3IgYWxsPykgb2YgdGhlIGNh bGwgc2l0ZXMgaW4KPiA+ID4gdGhlIGluIHRoZSBpbGsrIHdtIGNvZGUgc2hvdWxkIGp1c3QgYmUg dXNpbmcgY3J0Yy0+YWN0aXZlLiBTbyBmb3Igc29tZQo+ID4gPiBleHRyYSBzYWZldHkgaXQgbWln aHQgbWFrZSBzZW5zZSB0byBkbyBsZWF2ZSBpbnRlbF9jcnRjX2FjdGl2ZSgpIGFsb25lCj4gPiA+ IGZvciBub3csIG9yIGluIGZhY3Qgd2Ugc2hvdWxkIG1heWJlIGNoYW5nZSBpdCB0byBhbHNvIGxv b2sgYXQKPiA+ID4gcHJpbWFyeS0+c3RhdGUtPmZiIGluc3RlYWQuIFRoYXQgc2hvdWxkIG1vcmUg b3IgbGVzcyBrZWVwIHRoZSBvbGQKPiA+ID4gcGxhdGZvcm1zIGluIHRoZSBzYW1lIHN0YXRlIGFz IHRoZXkgd2VyZSBiZWZvcmUsIHdoaWxlIGxldHRpbmcgbmV3Cj4gPiA+IHBsYXRmb3JtcyBoYW5k bGUgZWFjaCBwbGFuZSBwcm9wZXJseS4KPiA+IAo+ID4gaW50ZWxfY3J0Yy0+YWN0aXZlIHNob3Vs ZG4ndCBiZSB1c2VkIGFueXdoZXJlIGluIHN0YXRlIGNvbXB1dGF0aW9uIGNvZGUuCj4gPiBUaGUg b25seSB0aGluZyB5b3UncmUgYWxsb3dlZCB0byBsb29rIGF0IGlzIGNydGNfc3RhdGUtPmVuYWJs ZSBpbiB0aGUKPiA+IGF0b21pYyB3b3JsZC4KPiAKPiBXZSdsbCB3YW50IGNydGMtPmFjdGl2ZSBp biBhIGJ1bmNoIG9mIHBsYWNlcyBpbiB0aGUgaWxrKyB3bSBjb2RlCj4gc2luY2UgaXQncyBhY3R1 YWxseSBpbnRlcnN0ZWQgaW4gdGhlIGN1cnJlbnQgc3RhdGUsIG5vdCB0aGUgZnV0dXJlCj4gc3Rh dGUuCj4gCj4gVGhlIHdheSBpdCBzaG91bGQgd29yayAoYWZ0ZXIgZ2V0dGluZyBteSByZW1haW5p bmcgaWxrKyB3bSBwYXRjaGVzCj4gcmV3b3JrZWQrbWVyZ2VkKToKPiAKPiAxLiBDb21wdXRlIG5l dyB3YXRlcm1hcmtzIGZvciB0aGlzIHNwZWNpZmljIHBpcGUgdXNpbmcgdGhlIGZ1dHVyZSBwbGFu ZS9jcnRjIHN0YXRlLgo+ICAgIFdlIGRvbid0IGNvbnNpZGVyIGF0IGFsbCBob3cgbWFueSBwaXBl cyB3aWxsIGJlIGFjdGl2ZSBvciBhcmUgYWN0aXZlIGN1cnJlbnRseSwKPiAgICBhcyB0aG9zZSBh cmUgbm90IHZhcmlhYmxlcyBpbiBvdXIgYWN0dWFsIHdhdGVybWFyayBlcXVhdGlvbnMuCj4gMi4g RmFpbCB0aGUgb3BlcmF0aW9uIGlmIExQMCBjb21lcyBvdXQgaW52YWxpZC4gTFAwIGxpbWl0cyBk byBub3QgZGVwZW5kCj4gICAgb24gdGhlIG51bWJlciBvZiBhY3RpdmUgcGlwZXMsIHNvIGEgZmFp bHVyZSB0byBtZWV0IHRoZSBMUDAgbGltaXRzIGlzCj4gICAgYWx3YXlzIGZhdGFsLiBMUDErIGxp bWl0cyB3ZSBjYW4gaWdub3JlIGF0IHRoaXMgc3RhZ2Ugc2luY2UgTFAxKyBhcmUKPiAgICBvcHRp b25hbC4KPiAzLiBNZXJnZSB0aGUgd2F0ZXJtYXJrcyBjb21wdXRlZCBhdCBzdGVwIDEgd2l0aCB0 aGUgY3VycmVudCB3YXRlcm1hcmtzCj4gICAgb24gdGhlIHBpcGUgYW5kIHN0b3JlIHRoZSByZXN1 bHQgYXMgdGhlIGN1cnJlbnQgd2F0ZXJtYXJrcyBvbiB0aGlzIHBpcGUuCj4gICAgVGhlc2UgYXJl IHdoYXQgSSBjYWxsZWQgImludGVybWVkaWF0ZSB3YXRlcm1hcmtzIiBhbmQgYXJlIG5lZWRlZCBk dWUKPiAgICB0byBsYWNrIG9mIGRvdWJsZSBidWZmZXJlZCB3YXRlcm1hcmsgcmVnaXN0ZXJzLgo+ IDQuIE1lcmdlIHRoZSBjdXJyZW50IHdhdGVybWFya3MgZnJvbSBhbGwgY3VycmVudGx5IGFjdGl2 ZSBwaXBlcywgYXBwbHlpbmcKPiAgICB3aGF0ZXZlciBleHRyYSBsaW1pdHMgYXJlIGltcG9zZWQg YnkgdGhlIG51bWJlciBvZiBhY3RpdmUgcGlwZXMgKGVnLgo+ICAgIGRpc2FsbG93IExQMSsgb24g aWxrL3NuYi9pdmIgd2l0aCBtdWx0aXBsZSBwaXBlcykgYW5kIHdyaXRlIHRoZSByZXN1bHQKPiAg ICB0byB0aGUgaGFyZHdhcmUgcmVnaXN0ZXJzCj4gNS4gQ29tbWl0IHRoZSBwbGFuZS9jcnRjIHN0 YXRlCj4gNi4gV2FpdCB1bnRpbCB0aGUgaGFyZHdhcmUgcGxhbmUvY3J0YyBzdGF0ZSBoYXMgY2hh bmdlZCAoaWUuIHVudGlsIHRoZQo+ICAgIG5leHQgdmJsYW5rKQo+IDcuIFN0b3JlIHRoZSB3YXRl cm1hcmtzIGNvbXB1dGVkIGF0IHN0ZXAgMSBhcyB0aGUgY3VycmVudCB3YXRlcm1hcmtzCj4gICAg b2YgdGhlIHBpcGUsIHJlcGxhY2luZyB0aGUgImludGVybWVkaWF0ZSB3YXRlcm1hcmtzIiBmcm9t IHN0ZXAgMwo+IDguIDxzYW1lIGFzIHN0ZXAgND4KPiAKPiBTbyBzdGVwIDEgaXMgcHJldHR5IG11 Y2ggdGhlIG9ubHkgcGxhY2Ugd2hlcmUgd2Ugc2hvdWxkIGNvbnNpZGVyIHRoZQo+IGZ1dHVyZSBz dGF0ZSBhcyBvcHBvc2VkIHRvIHRoZSBjdXJyZW50IHN0YXRlIG9mIHRoZSBoYXJkd2FyZS4KClll YWggdGhhdCdzIGEgdmFsaWQgdXNlLWNhc2UsIGJ1dCB5b3UgaW5zdGVhZCB3YW50IHRvIGxvb2sg YXQKY3J0Y19zdGF0ZS0+YWN0aXZlLiBpbnRlbF9jcnRjLT5hY3RpdmUgd2lsbCBqdXN0IGJlIGEg Y29uc2lzdGVuY3kgY2hlY2sgaW4KdGhlIGVuZCByZWFsbHkuIEFuZCBzaW5jZSBjcnRjX3N0YXRl LT5hY3RpdmUgaXMgc2V0IGNvcnJlY3RseSBldmVuIGluIHRoZQpjaGVjayBwaGFzZSBvZiB0aGUg bW9kZXNldCB3ZSBjb3VsZCBjb21wdXRlIHRoZSBmaW5hbCB3YXRlcm1hcmtzIHJpZ2h0CmF3YXku IGludGVsX2NydGMtPmFjdGl2ZSBpcyBvbmx5IHNldCB3aGlsZSBjb21taXR0aW5nIHRoZSBzdGF0 ZSB0byBody4KClRoaXMgaXMgaW1wb3J0YW50IGZyb20gYSBsb2NraW5nIHBvdiBzaW5jZSBzdGF0 ZSBvYmplY3RzIG11c3QgYmUgaW52YXJpYW50Cm9uY2UgY29tbWl0dGVkIHRvIGZvby0+c3RhdGUg cG9pbnRlcnMuIFNvIHlvdSdkIGVuZCB1cCB3aXRoIHNvbWUKaW50ZXJlc3RpbmcgYm9vay1rZWVw aW5nIHByb2JsZW1zIEkgZXhwZWN0LiBXZSdsbCBzZWUuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0 ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3 IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK