Received: from eggs.gnu.org ([2001:4830:134:3::10]:58673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTYnj-0003b5-OS for qemu-devel@nongnu.org; Thu, 05 Mar 2015 11:39:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YTYng-0007NM-Jv for qemu-devel@nongnu.org; Thu, 05 Mar 2015 11:39:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YTYng-0007N3-Bz for qemu-devel@nongnu.org; Thu, 05 Mar 2015 11:39:04 -0500 Date: Thu, 5 Mar 2015 13:38:56 -0300 From: Eduardo Habkost Message-ID: <20150305163856.GW3513@thinpad.lan.raisama.net> References: <1425569930-6660-1-git-send-email-ehabkost@redhat.com> <1425569930-6660-5-git-send-email-ehabkost@redhat.com> <20150305173139.633fe013@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150305173139.633fe013@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/6] target-i386: Rename optimize_flags_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: zhugh.fnst@cn.fujitsu.com, qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, anshul.makkar@profitbricks.com, Gu Zheng , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= On Thu, Mar 05, 2015 at 05:31:39PM +0100, Igor Mammedov wrote: > On Thu, 5 Mar 2015 12:38:48 -0300 > Eduardo Habkost wrote: > > > Rename the function so that the reason for its existence is clearer: it > > does x86-specific initialization of TCG structures. > > > > Signed-off-by: Eduardo Habkost > > --- > > target-i386/cpu.c | 2 +- > > target-i386/cpu.h | 2 +- > > target-i386/translate.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > > index 50907d0..b4e70d3 100644 > > --- a/target-i386/cpu.c > > +++ b/target-i386/cpu.c > > @@ -2883,7 +2883,7 @@ static void x86_cpu_initfn(Object *obj) > > /* init various static tables used in TCG mode */ > > if (tcg_enabled() && !inited) { > > inited = 1; > > - optimize_flags_init(); > > + tcg_x86_init(); > > } > how about moving 'inited' handling inside of tcg_x86_init() along with renaming? Makes sense, and it will help simplify patch 5/6. But I'll do that in a separate patch. > > > } > > > > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > > index 0638d24..52b460a 100644 > > --- a/target-i386/cpu.h > > +++ b/target-i386/cpu.h > > @@ -1228,7 +1228,7 @@ static inline target_long lshift(target_long x, int n) > > #define ST1 ST(1) > > > > /* translate.c */ > > -void optimize_flags_init(void); > > +void tcg_x86_init(void); > > > > #include "exec/cpu-all.h" > > #include "svm.h" > > diff --git a/target-i386/translate.c b/target-i386/translate.c > > index 094cec0..f19f20f 100644 > > --- a/target-i386/translate.c > > +++ b/target-i386/translate.c > > @@ -7852,7 +7852,7 @@ static target_ulong disas_insn(CPUX86State *env, DisasContext *s, > > return s->pc; > > } > > > > -void optimize_flags_init(void) > > +void tcg_x86_init(void) > > { > > static const char reg_names[CPU_NB_REGS][4] = { > > #ifdef TARGET_X86_64 > -- Eduardo