From: Daniel Vetter Subject: Re: [PATCH 05/51] drm/i915: Add return code check to i915_gem_execbuffer_retire_commands() Date: Fri, 6 Mar 2015 16:57:19 +0100 Message-ID: <20150306155719.GT18775@phenom.ffwll.local> References: <1423828140-10653-1-git-send-email-John.C.Harrison@Intel.com> <1423828140-10653-6-git-send-email-John.C.Harrison@Intel.com> <20150225221700.GE24485@phenom.ffwll.local> <20150226022651.GJ24485@phenom.ffwll.local> <54F854C2.7010208@Intel.com> <20150305144452.GF18775@phenom.ffwll.local> <54F87102.8020504@Intel.com> <20150305161400.GO18775@phenom.ffwll.local> <54F991C4.40804@Intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTP id C120672084 for ; Fri, 6 Mar 2015 07:55:40 -0800 (PST) Received: by wivr20 with SMTP id r20so4604073wiv.3 for ; Fri, 06 Mar 2015 07:55:40 -0800 (PST) Content-Disposition: inline In-Reply-To: <54F991C4.40804@Intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: John Harrison Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMDYsIDIwMTUgYXQgMTE6Mzg6NDRBTSArMDAwMCwgSm9obiBIYXJyaXNvbiB3 cm90ZToKPiBPbiAwNS8wMy8yMDE1IDE2OjE0LCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID5PbiBU aHUsIE1hciAwNSwgMjAxNSBhdCAwMzowNjo0MlBNICswMDAwLCBKb2huIEhhcnJpc29uIHdyb3Rl Ogo+ID4+T24gMDUvMDMvMjAxNSAxNDo0NCwgRGFuaWVsIFZldHRlciB3cm90ZToKPiA+Pj5JbW8g cmVzZXJ2aW5nIGEgYml0IG9mIHJpbmcgc3BhY2UgZm9yIGVhY2ggYWRkX3JlcXVlc3Qgc2hvdWxk IGJlIHNvbGlkLgo+ID4+PlVzZXJzcGFjZSB1c2VzIHRoZSBleGFjdCBzYW1lIHJlc2VydmF0aW9u IGxvZ2ljIGZvciBhZGRpbmcgZW5kLW9mLWJhdGNoCj4gPj4+d29ya2Fyb3VuZHMuIFRoZSBvbmx5 IHRoaW5nIG5lZWRlZCB0byBtYWtlIHRoaXMgc29saWQgaXMgdG8gV0FSTiBpZgo+ID4+PmFkZF9y ZXF1ZXN0IGVuZHMgdXAgdXNpbmcgbW9yZSByaW5nIHNwYWNlIHRoYW4gd2hhdCB3ZSd2ZSByZXNl cnZlZCAobm90Cj4gPj4+anVzdCB3aGVuIGl0IGFjdHVhbGx5IHJ1bnMgb3V0LCB0aGF0IG9idmlv dXNseSBkb2Vzbid0IGhhcHBlbiBvZnRlbgo+ID4+PmVub3VnaCBmb3IgdGVzdGluZykuCj4gPj5U aGUgcHJvYmxlbSBpcyB0aGF0IHRoZXJlIGNvdWxkIGJlIG11bHRpcGxlIHJlcXVlc3RzIGJlaW5n IHByb2Nlc3NlZCBpbgo+ID4+cGFyYWxsZWwuIFRoaXMgaXMgZXNwZWNpYWxseSB0cnVlIHdpdGgg dGhlIHNjaGVkdWxlci4gVXNlcmxhbmQgY291bGQgc3VibWl0Cj4gPj5hIHdob2xlIHN0cmVhbSBv ZiBiYXRjaGVzIHRoYXQgYWxsIGdldCBxdWV1ZWQgdXAgaW4gdGhlIHNjaGVkdWxlci4gT25seQo+ ID4+bGF0ZXIgZG8gdGhleSBnZXQgc3VibWl0dGVkIHRvIHRoZSBoYXJkd2FyZS4gVGhlIHJlcXVl c3QgbXVzdCBiZSBhbGxvY2F0ZWQKPiA+PnVwIGZyb250IGJlY2F1c2UgdGhlcmUgaXMgbm8gb3Ro ZXIgbWVhbnMgb2YgdHJhY2tpbmcgdGhlbS4gQnV0IHJlc2VydmluZwo+ID4+c3BhY2UgYXQgdGhh dCBwb2ludCB3b24ndCB3b3JrIGJlY2F1c2UgeW91IGVpdGhlciBlbmQgdXAgcmVzZXJ2aW5nIG1h c3NpdmUKPiA+PmFtb3VudHMgb2Ygc3BhY2UgaWYgdGhlIHJlc2VydmUgaXMgY3VtdWxhdGl2ZSwg b3Igbm90IGVub3VnaCBpZiBvbmx5IG9uZQo+ID4+c2xvdCBpcyByZXNlcnZlZC4KPiA+QXQgbGVh c3Qgd2l0aCBleGVjbGlzdCB3ZSBkb24ndCBoYXZlIHRoYXQgcHJvYmxlbSByZWFsbHkgc2luY2Ug d3JpdGluZyB0aGUKPiA+cmluZ2J1ZmZlciBpcyBkb25lIHN5bmNocm9ub3VzbHkgYW5kIGRpcmVj dGx5Lgo+ID4KPiA+Rm9yIHRoZSBsZWdhY3kgc2NoZWR1bGVyIEkgZXhwZWN0IHRoYXQgd2Ugd29u J3QgZG8gYW55IG9mIHRoZSByaW5nYnVmCj4gPndyaXRlcyBkaXJlY3RseSBhbmQgaW5zdGVhZCB0 aGF0J3MgYWxsIGRvbmUgYnkgdGhlIHNjaGVkdWxlcgo+ID5hc3luY2hyb25vdXNseS4KPiA+Cj4g PlNvIHRoaXMgc2hvdWxkIGp1c3QgYmUgYW4gaXNzdWUgd2hpbGUgd2UgYXJlIGNvbnZlcnRpbmcg dG8gdGhlIHNjaGVkdWxlcgo+ID5vciBvbiBwbGF0Zm9ybXMgdGhhdCB3aWxsIG5ldmVyIGhhdmUg b25lLiBBbmQgaW1vIHRoZSByZXF1ZXN0IHJpbmdidWYKPiA+cmVzZXJ2YXRpb24gaXMgdGhlIHNv bHV0aW9uIHdpdGggdGhlIHNpbXBsZXN0IGltcGFjdCBvbiB0aGUgZGVzaWduLgo+IEkgZG9uJ3Qg dW5kZXJzdGFuZCB3aGF0IHlvdSBtZWFuIGhlcmUuIFRoZSBzY2hlZHVsZXIgZGVjb3VwbGVzIHRo ZQo+IHN1Ym1pc3Npb24gb2YgYSBiYXRjaCBidWZmZXIgdG8gdGhlIGRyaXZlciB3aXRoIHRoZSBz dWJtaXNzaW9uIG9mIHRoYXQgYmF0Y2gKPiBidWZmZXIgdG8gdGhlIGhhcmR3YXJlLiBUaGUgc3Vi bWlzc2lvbiBjb2RlIHBhdGggaXRzZWxmIGlzIGlkZW50aWNhbC4gVGhlCj4gc2NoZWR1bGVyIGRv ZXMgbm90IGRvIGFueSBoYXJkd2FyZSB3cml0ZXMgLSBpdCBtZXJlbHkgYWRkcyBhbiBleHRyYSBs YXllcgo+IGJldHdlZW4gdGhlIHVzZXIgaW50ZXJmYWNlIGNvZGUgYW5kIHRoZSBoYXJkd2FyZSBh Y2Nlc3MgY29kZS4gVGhlIHJlcXVlc3QKPiBjcmVhdGlvbiBtdXN0IGJlIGRvbmUgYXQgZHJpdmVy IHN1Ym1pc3Npb24gdGltZS4gVGhlIGhhcmR3YXJlIHN1Ym1pc3Npb24KPiBjb3VsZCBiZSBhbiBh cmJpdHJhcnkgYW1vdW50IG9mIHRpbWUgbGF0ZXIuIEluIHRoZSBpbnRlcnZlbmluZyB0aW1lLCBh bnkKPiBudW1iZXIgb2YgbmV3IGJhdGNoIGJ1ZmZlcnMgbWF5IGJlIHN1Ym1pdHRlZCB0byB0aGUg ZHJpdmVyIGFuZCB0aHVzIG5ldwo+IHJlcXVlc3RzIGJlIGNyZWF0ZWQuIFRoaXMgaXMgdHJ1ZSBm b3IgYm90aCBsZWdhY3kgYW5kIGV4ZWNsaXN0IG1vZGUuCj4gCj4gVGhlIHNwYWNlIHJlc2VydmUg d291bGQgaGF2ZSB0byBiZSBkb25lIGF0IHRoZSBzdGFydCBvZiB0aGUgaGFyZHdhcmUKPiBzdWJt aXNzaW9uIHByb2Nlc3Mgbm90IGF0IGRyaXZlciBzdWJtaXNzaW9uIHRpbWUuIEkuZS4gaXQgd291 bGQgbmVlZCB0byBiZSBhCj4gc2VwYXJhdGUgYW5kIG5ldyBpOTE1X2dlbV9yZXF1ZXN0X3Jlc2Vy dmVfc3BhY2UoKSBjYWxsIGF0IHRoZSBzdGFydCBvZiB0aGUKPiBiYWNrIGhhbGYgb2YgdGhlIGV4 ZWMgYnVmZmVyIGNvZGUuIEl0IGNvdWxkIG5vdCBiZSBkb25lIGR1cmluZyByZXF1ZXN0Cj4gY3Jl YXRpb24uCgpZZWFoIHdpdGggdGhlIHNjaGVkdWxlciB3ZSBuZWVkIHRvIHRha2Ugb3V0IHRoZSBy ZXNlcnZhdGlvbiBhZ2FpbiBzaW5jZSBpdApkb2Vzbid0IG1ha2UgYSBsb3Qgb2Ygc2Vuc2UgLSB0 aGUgc2NoZWR1bGVyIGlzIHRoZSBzYWZldHkgbmV0IHRoYXQKZ3VhcmFudGVlcyBleGVjdXRpb24g KGJhcnJpbmcgZ3B1IGRlYXRoIG9mYyBhcyBhbHdheXMpIHdoZW4gdGhlIGV4ZWNidWYKaW9jdGwg cmV0dXJucyAwLiBNYXliZSBpbiB0aGUgZW5kIHdlIG5lZWQgYSBzcGVjaWFsIGFsbG9jX3JlcXVl c3QgZnVuY3Rpb24KZm9yIGV4ZWNidWYgdG8gb25seSByZXNlcnZlIHdoZW4gdGhlIHNjaGVkdWxl ciBpc24ndCBhcm91bmQuCgpUaGF0IGFkZGl0aW9uYWwgd29yayBpcyBqdXN0IHBhcnQgb2YgdGhl IHByaXplIHdlIGhhdmUgdG8gcGF5IHRvIG5ldmVyCmJyZWFrIHRoaW5ncyB3aGlsZSByZWZhY3Rv cmluZyBjb2RlLiBBbmQgc2luY2Ugd2UnbGwgZ2V0IHRoZSBleGVjbGlzdApzY2hlZHVsZXIgaW4g Zmlyc3QgdGhhdCByZXNlcnZhdGlvbiBjb2RlIHdpbGwgcHJvYmFibHkgc3RpY2sgYXJvdW5kIGZv ciBhCndoaWxlIChvciBtYXliZSBmb3JldmVyIGV2ZW4gaWYgd2UgZGVjaWRlIGFnYWluc3QgdXBz dHJlYW1pbmcgdGhlIGdlbjcKc2NoZWR1bGVyKS4KCkRvZXMgdGhpcyBtYWtlIHNlbnNlPwoKVGhh bmtzLCBEYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCis0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK