From: Daniel Vetter Subject: Re: [PATCH 05/53] drm/i915: Add return code check to i915_gem_execbuffer_retire_commands() Date: Fri, 6 Mar 2015 17:15:36 +0100 Message-ID: <20150306161536.GU18775@phenom.ffwll.local> References: <1423828140-10653-1-git-send-email-John.C.Harrison@Intel.com> <1424366285-29232-1-git-send-email-John.C.Harrison@Intel.com> <1424366285-29232-6-git-send-email-John.C.Harrison@Intel.com> <54F86BF7.3070209@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C9976E8C7 for ; Fri, 6 Mar 2015 08:13:58 -0800 (PST) Received: by widex7 with SMTP id ex7so3991831wid.3 for ; Fri, 06 Mar 2015 08:13:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <54F86BF7.3070209@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tomas Elf Cc: Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMDUsIDIwMTUgYXQgMDI6NDU6MTFQTSArMDAwMCwgVG9tYXMgRWxmIHdyb3Rl Ogo+IE9uIDE5LzAyLzIwMTUgMTc6MTcsIEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20gd3JvdGU6 Cj4gPkZyb206IEpvaG4gSGFycmlzb24gPEpvaG4uQy5IYXJyaXNvbkBJbnRlbC5jb20+Cj4gPgo+ ID5Gb3Igc29tZSByZWFzb24sIHRoZSBpOTE1X2FkZF9yZXF1ZXN0KCkgY2FsbCBpbgo+ID5pOTE1 X2dlbV9leGVjYnVmZmVyX3JldGlyZV9jb21tYW5kcygpIHdhcyBleHBsaWNpdGx5IGhhdmluZyBp dHMgcmV0dXJuIGNvZGUKPiA+aWdub3JlZC4gVGhlIF9yZXRpcmVfY29tbWFuZHMoKSBmdW5jdGlv biBpdHNlbGYgd2FzICd2b2lkJy4gR2l2ZW4gdGhhdAo+ID5fYWRkX3JlcXVlc3QoKSBjYW4gZmFp bCB3aXRob3V0IGRpc3BhdGNoaW5nIHRoZSBiYXRjaCBidWZmZXIsIHRoaXMgc2VlbXMgb2RkLgo+ ID4KPiA+QWxzbyBzaHJ1bmsgdGhlIHBhcmFtZXRlciBsaXN0IHRvIGEgc2luZ2xlIHN0cnVjdHVy ZSBhcyBldmVyeXRoaW5nIGl0IHJlcXVpcmVzCj4gPmlzIGF2YWlsYWJsZSBpbiB0aGUgZXhlY2J1 ZmZfcGFyYW1zIG9iamVjdC4KPiA+Cj4gPkZvcjogVklaLTUxMTUKPiA+U2lnbmVkLW9mZi1ieTog Sm9obiBIYXJyaXNvbiA8Sm9obi5DLkhhcnJpc29uQEludGVsLmNvbT4KPiA+LS0tCj4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgICAgIHwgICAgNSArLS0tLQo+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyB8ICAgMTYgKysrKysr Ky0tLS0tLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAg ICB8ICAgIDMgKy0tCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDE1IGRl bGV0aW9ucygtKQo+ID4KPiA+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPmluZGV4IGZkZDYzYWIu LmIzNTA5MTAgMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK PiA+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID5AQCAtMjY0MCwxMCAr MjY0MCw3IEBAIGludCBpOTE1X2dlbV9zd19maW5pc2hfaW9jdGwoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgdm9pZCAqZGF0YSwKPiA+ICAJCQkgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2 KTsKPiA+ICB2b2lkIGk5MTVfZ2VtX2V4ZWNidWZmZXJfbW92ZV90b19hY3RpdmUoc3RydWN0IGxp c3RfaGVhZCAqdm1hcywKPiA+ICAJCQkJCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpOwo+ ID4tdm9pZCBpOTE1X2dlbV9leGVjYnVmZmVyX3JldGlyZV9jb21tYW5kcyhzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LAo+ID4tCQkJCQkgc3RydWN0IGRybV9maWxlICpmaWxlLAo+ID4tCQkJCQkgc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqcmluZywKPiA+LQkJCQkJIHN0cnVjdCBkcm1faTkxNV9nZW1f b2JqZWN0ICpvYmopOwo+ID4raW50IGk5MTVfZ2VtX2V4ZWNidWZmZXJfcmV0aXJlX2NvbW1hbmRz KHN0cnVjdCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMpOwo+ID4gIGludCBpOTE1X2dl bV9yaW5nYnVmZmVyX3N1Ym1pc3Npb24oc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBh cmFtcywKPiA+ICAJCQkJICAgc3RydWN0IGRybV9pOTE1X2dlbV9leGVjYnVmZmVyMiAqYXJncywK PiA+ICAJCQkJICAgc3RydWN0IGxpc3RfaGVhZCAqdm1hcyk7Cj4gPmRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiA+aW5kZXggOTNiMGVmMC4uY2E4NTgwMyAxMDA2 NDQKPiA+LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXhlY2J1ZmZlci5jCj4g PisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V4ZWNidWZmZXIuYwo+ID5AQCAt OTg5LDE3ICs5ODksMTUgQEAgaTkxNV9nZW1fZXhlY2J1ZmZlcl9tb3ZlX3RvX2FjdGl2ZShzdHJ1 Y3QgbGlzdF9oZWFkICp2bWFzLAo+ID4gIAl9Cj4gPiAgfQo+ID4KPiA+LXZvaWQKPiA+LWk5MTVf Z2VtX2V4ZWNidWZmZXJfcmV0aXJlX2NvbW1hbmRzKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4g Pi0JCQkJICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZSwKPiA+LQkJCQkgICAgc3RydWN0IGludGVs X2VuZ2luZV9jcyAqcmluZywKPiA+LQkJCQkgICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3Qg Km9iaikKPiA+K2ludAo+ID4raTkxNV9nZW1fZXhlY2J1ZmZlcl9yZXRpcmVfY29tbWFuZHMoc3Ry dWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMgKnBhcmFtcykKPiA+ICB7Cj4gPiAgCS8qIFVuY29u ZGl0aW9uYWxseSBmb3JjZSBhZGRfcmVxdWVzdCB0byBlbWl0IGEgZnVsbCBmbHVzaC4gKi8KPiA+ LQlyaW5nLT5ncHVfY2FjaGVzX2RpcnR5ID0gdHJ1ZTsKPiA+KwlwYXJhbXMtPnJpbmctPmdwdV9j YWNoZXNfZGlydHkgPSB0cnVlOwo+ID4KPiA+ICAJLyogQWRkIGEgYnJlYWRjcnVtYiBmb3IgdGhl IGNvbXBsZXRpb24gb2YgdGhlIGJhdGNoIGJ1ZmZlciAqLwo+ID4tCSh2b2lkKV9faTkxNV9hZGRf cmVxdWVzdChyaW5nLCBmaWxlLCBvYmopOwo+ID4rCXJldHVybiBfX2k5MTVfYWRkX3JlcXVlc3Qo cGFyYW1zLT5yaW5nLCBwYXJhbXMtPmZpbGUsCj4gPisJCQkJICBwYXJhbXMtPmJhdGNoX29iaik7 Cj4gPiAgfQo+ID4KPiA+ICBzdGF0aWMgaW50Cj4gPkBAIC0xMjgyLDggKzEyODAsOCBAQCBpOTE1 X2dlbV9yaW5nYnVmZmVyX3N1Ym1pc3Npb24oc3RydWN0IGk5MTVfZXhlY2J1ZmZlcl9wYXJhbXMg KnBhcmFtcywKPiA+ICAJdHJhY2VfaTkxNV9nZW1fcmluZ19kaXNwYXRjaChpbnRlbF9yaW5nX2dl dF9yZXF1ZXN0KHJpbmcpLCBwYXJhbXMtPmRpc3BhdGNoX2ZsYWdzKTsKPiA+Cj4gPiAgCWk5MTVf Z2VtX2V4ZWNidWZmZXJfbW92ZV90b19hY3RpdmUodm1hcywgcmluZyk7Cj4gPi0JaTkxNV9nZW1f ZXhlY2J1ZmZlcl9yZXRpcmVfY29tbWFuZHMocGFyYW1zLT5kZXYsIHBhcmFtcy0+ZmlsZSwgcmlu ZywKPiA+LQkJCQkJICAgIHBhcmFtcy0+YmF0Y2hfb2JqKTsKPiA+Kwo+ID4rCXJldCA9IGk5MTVf Z2VtX2V4ZWNidWZmZXJfcmV0aXJlX2NvbW1hbmRzKHBhcmFtcyk7Cj4gPgo+ID4gIGVycm9yOgo+ ID4gIAlrZnJlZShjbGlwcmVjdHMpOwo+ID5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ID5pbmRl eCBmNmEyNGU4YTIuLmRjNDc0YjQgMTAwNjQ0Cj4gPi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2xyYy5jCj4gPisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4g PkBAIC03MTUsOSArNzE1LDggQEAgaW50IGludGVsX2V4ZWNsaXN0c19zdWJtaXNzaW9uKHN0cnVj dCBpOTE1X2V4ZWNidWZmZXJfcGFyYW1zICpwYXJhbXMsCj4gPiAgCXRyYWNlX2k5MTVfZ2VtX3Jp bmdfZGlzcGF0Y2goaW50ZWxfcmluZ19nZXRfcmVxdWVzdChyaW5nKSwgcGFyYW1zLT5kaXNwYXRj aF9mbGFncyk7Cj4gPgo+ID4gIAlpOTE1X2dlbV9leGVjYnVmZmVyX21vdmVfdG9fYWN0aXZlKHZt YXMsIHJpbmcpOwo+ID4tCWk5MTVfZ2VtX2V4ZWNidWZmZXJfcmV0aXJlX2NvbW1hbmRzKHBhcmFt cy0+ZGV2LCBwYXJhbXMtPmZpbGUsIHJpbmcsIHBhcmFtcy0+YmF0Y2hfb2JqKTsKPiA+Cj4gPi0J cmV0dXJuIDA7Cj4gPisJcmV0dXJuIGk5MTVfZ2VtX2V4ZWNidWZmZXJfcmV0aXJlX2NvbW1hbmRz KHBhcmFtcyk7Cj4gPiAgfQo+ID4KPiA+ICB2b2lkIGludGVsX2V4ZWNsaXN0c19yZXRpcmVfcmVx dWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZykKPiA+Cj4gCj4gUmV2aWV3ZWQtYnk6 IFRvbWFzIEVsZiA8dG9tYXMuZWxmQGludGVsLmNvbT4KClBhdGNoIGRpc2N1c3Npb24gdW5mb3J0 dW5hdGVseSBzcGxpdCBzaW5jZSBJJ3ZlIG1hZGUgYWxsIG15IGNvbW1lbnRzIG9uCnRoZSBlYXJs aWVyIGl0ZXJhdGlvbi4gQW55d2F5IHRoZXJlJ3MgYSBiaWcgZGlzY3Vzc2lvbiB0aGVyZSwgeW91 IG1pZ2h0CndhbnQgdG8gbG9vayBpbnRvIHRoYXQgYW5kIHJlY29uc2RlciB5b3VyIHItYiA7LSkK LURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9y YXRpb24KKzQxICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=