From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Don't require primary->fb in intel_crtc_active() Date: Fri, 6 Mar 2015 17:44:33 +0100 Message-ID: <20150306164433.GA18775@phenom.ffwll.local> References: <1425435313-31711-1-git-send-email-matthew.d.roper@intel.com> <54F7404C.8030201@linux.intel.com> <20150304174213.GB23780@intel.com> <54F87148.2010104@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 02D006E8D2 for ; Fri, 6 Mar 2015 08:42:54 -0800 (PST) Received: by wghl18 with SMTP id l18so7033633wgh.11 for ; Fri, 06 Mar 2015 08:42:53 -0800 (PST) Content-Disposition: inline In-Reply-To: <54F87148.2010104@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMDUsIDIwMTUgYXQgMDM6MDc6NTJQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gCj4gT24gMDMvMDQvMjAxNSAwNTo0MiBQTSwgTWF0dCBSb3BlciB3cm90ZToKPiA+ T24gV2VkLCBNYXIgMDQsIDIwMTUgYXQgMDU6MjY6MzZQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4g d3JvdGU6Cj4gPj4KPiA+Pk9uIDAzLzA0LzIwMTUgMDI6MTUgQU0sIE1hdHQgUm9wZXIgd3JvdGU6 Cj4gPj4+VW5pdmVyc2FsIHBsYW5lcyBhbGxvdyB1cyB0byBoYXZlIGFuIGFjdGl2ZSBDUlRDIHdp dGhvdXQgYSBwcmltYXJ5IHBsYW5lCj4gPj4+ZnJhbWVidWZmZXIgYm91bmQuICBEcm9wIHRoZSB0 ZXN0IGZvciBwcmltYXJ5LT5mYiBmcm9tCj4gPj4+aW50ZWxfY3J0Y19hY3RpdmUoKSBzaW5jZSB3 ZSBjYW4gY2xlYXJseSBoYXZlIGFjdGl2ZSBDUlRDJ3Mgd2l0aG91dCBhCj4gPj4+ZnJhbWVidWZm ZXIsIGFuZCB0aGlzIGNoZWNrIGlzIG5vdyBpbnRlcmZlcmluZyB3aXRoIHdhdGVybWFyawo+ID4+ PmNhbGN1bGF0aW9ucyB3aGVuIHdlIHRyeSB0byByZS1lbmFibGUgdGhlIHByaW1hcnkgcGxhbmUu Cj4gPj4+Cj4gPj4+Tm90ZSB0aGF0IGNvbW1pdAo+ID4+Pgo+ID4+PiAgICAgICAgIGNvbW1pdCAw ZmRhNjU2ODBlOTI1NDVjYWVhNWJlNzgwNWE3ZjBhNjE3ZmI2YzIwCj4gPj4+ICAgICAgICAgQXV0 aG9yOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+ID4+PiAgICAg ICAgIERhdGU6ICAgRnJpIEZlYiAyNyAxNToxMjozNSAyMDE1ICswMDAwCj4gPj4+Cj4gPj4+ICAg ICAgICAgICAgIGRybS9pOTE1L3NrbDogVXBkYXRlIHdhdGVybWFya3MgZm9yIFkgdGlsaW5nCj4g Pj4+Cj4gPj4+YWRkcyBhIHRlc3QgZm9yIHByaW1hcnkgcGxhbmUgZW5hYmxlL2Rpc2FibGUgdG8g dHJpZ2dlciBhIHdhdGVybWFyawo+ID4+PnVwZGF0ZSAocHJldmlvdXNseSB3ZSBpZ25vcmVkIHVw ZGF0ZXMgdG8gcHJpbWFyeSBwbGFuZXMsIHdoaWNoIHdhc24ndAo+ID4+PnJlYWxseSBjb3JyZWN0 LCBidXQgd2UgZ290IGx1Y2t5IHNpbmNlIHdlIGFsd2F5cyBwcmV0ZW5kZWQgdGhlIHByaW1hcnkK PiA+Pj5wbGFuZSB3YXMgb24pLiAgVHZydGtvJ3MgcGF0Y2ggdHJpZXMgdG8gdXBkYXRlIHdhdGVy bWFya3Mgd2hlbiB3ZQo+ID4+PnJlLWVuYWJsZSB0aGUgcHJpbWFyeSBwbGFuZSwgYnV0IHRoYXQg d2F0ZXJtYXJrIGNvbXB1dGF0aW9uIGdldHMgYWJvcnRlZAo+ID4+PmVhcmx5IGJlY2F1c2UgaW50 ZWxfY3J0Y19hY3RpdmUoKSBhbHdheXMgcmV0dXJucyBmYWxzZSB3aGVuIHRoZSBwcmltYXJ5Cj4g Pj4+cGxhbmUgaXMgZGlzYWJsZWQ7IHRoaXMgbGVhZHMgdG8gd2F0ZXJtYXJrIHVuZGVycnVucyAo YXQgbGVhc3Qgb24KPiA+Pj5wbGF0Zm9ybXMgd2l0aCBJTEstc3R5bGUgd2F0ZXJtYXJrIGNvZGUp Lgo+ID4+Pgo+ID4+PkNjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29t Pgo+ID4+PlNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5j b20+Cj4gPj4+LS0tCj4gPj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg fCA1ICstLS0tCj4gPj4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDQgZGVsZXRp b25zKC0pCj4gPj4+Cj4gPj4+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4+Pmlu ZGV4IDU4OWFkZGYuLjkyY2IyZmYgMTAwNjQ0Cj4gPj4+LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gPj4+QEAgLTg5MywxMSArODkzLDggQEAgYm9vbCBpbnRlbF9jcnRjX2FjdGl2 ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPj4+ICAJICoKPiA+Pj4gIAkgKiBXZSBjYW4gZGl0 Y2ggdGhlIGFkanVzdGVkX21vZGUuY3J0Y19jbG9jayBjaGVjayBhcyBzb29uCj4gPj4+ICAJICog YXMgSGFzd2VsbCBoYXMgZ2FpbmVkIGNsb2NrIHJlYWRvdXQvZmFzdGJvb3Qgc3VwcG9ydC4KPiA+ Pj4tCSAqCj4gPj4+LQkgKiBXZSBjYW4gZGl0Y2ggdGhlIGNydGMtPnByaW1hcnktPmZiIGNoZWNr IGFzIHNvb24gYXMgd2UgY2FuCj4gPj4+LQkgKiBwcm9wZXJseSByZWNvbnN0cnVjdCBmcmFtZWJ1 ZmZlcnMuCj4gPj4+ICAJICovCj4gPj4+LQlyZXR1cm4gaW50ZWxfY3J0Yy0+YWN0aXZlICYmIGNy dGMtPnByaW1hcnktPmZiICYmCj4gPj4+KwlyZXR1cm4gaW50ZWxfY3J0Yy0+YWN0aXZlICYmCj4g Pj4+ICAJCWludGVsX2NydGMtPmNvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfY2xvY2s7 Cj4gPj4KPiA+PlN0cnVnZ2xpbmcgdG8gcGFpbnQgdGhlIHdob2xlIHBpY3R1cmUgaGVyZS4uCj4g Pj4KPiA+PldoeSBpdCB3YXMgY29ycmVjdCB0byByZXBsYWNlIHByaW1hcnktPmZiIHdpdGggcHJp bWFyeS0+c3RhdGUtPmZiCj4gPj5lbHNld2hlcmUsIGJ1dCBub3QgaGVyZT8KPiA+Pgo+ID4+RG9l cyB0aGUgY29tbWl0IG1lc3NhZ2UgbWVhbiB0aGVyZSBjYW4gYmUgYW4gYWN0aXZlIGNydGMgd2l0 aCBhbgo+ID4+YWN0aXZlIHBsYW5lLCBidXQgY3J0Yy0+cHJpbWFyeS0+ZmIgPT0gTlVMTCBzbyB0 aGUgd20gcmVjb21wdXRlCj4gPj5pbmNvcnJlY3RseSBjb25maWd1cmVzIGZvciBkaXNhYmxlZCBw bGFuZT8KPiA+Cj4gPkJhY2sgd2hlbiB0aGlzIGNvZGUgd2FzIGZpcnN0IHdyaXR0ZW4sIHdlIGRp ZG4ndCBoYXZlIHVuaXZlcnNhbCBwbGFuZXMKPiA+eWV0IGFuZCB0aGUgZmIgcG9pbnRlciB3YXMg ZGlyZWN0bHkgaW4gdGhlIENSVEMuICAgU28gYXQgdGhhdCB0aW1lLAo+ID4oY3J0Yy0+ZmIgPT0g TlVMTCkgbWVhbnQgdGhhdCB0aGUgZW50aXJlIENSVEMgd2FzIG9mZi4KPiA+Cj4gPldoZW4gSSBh ZGRlZCB1bml2ZXJzYWwgcGxhbmUgc3VwcG9ydCwgSSB1c2VkIENvY2NpbmVsbGUgdG8gZ2xvYmFs bHkgZG8gYQo+ID5zL2NydGMtPmZiL2NydGMtPnByaW1hcnktPmZiLywgc28gdGhhdCBjaGFuZ2Ug ZGlkbid0IHJlYWxseSBoYXZlIGFueQo+ID5zcGVjaWFsIHRob3VnaHQgZ29pbmcgaW50byBpdC4g IEhvd2V2ZXIgYXQgdGhhdCBwb2ludCB3ZSBzdGFydGVkCj4gPmFsbG93aW5nIHlvdSB0byBoYXZl IGFuIGV4cGxpY2l0bHkgZGlzYWJsZWQgcHJpbWFyeSBwbGFuZSB3aXRoIGFuIGFjdGl2ZQo+ID5D UlRDIChzb21ldGhpbmcgdGhhdCBoYWQgbmV2ZXIgYmVlbiBwb3NzaWJsZSBiZWZvcmUgd2l0aCB0 aGUgbGVnYWN5Cj4gPkFQSSdzKS4gIEluIHRoaXMgY2FzZSwgY3J0Yy0+cHJpbWFyeS0+ZmIgPSBO VUxMLCBidXQgdGhlIENSVEMgaXMgc3RpbGwKPiA+cnVubmluZy4KPiA+Cj4gPlNvIG9ubHkgY29u c2lkZXJpbmcgYSBDUlRDIHRvIGJlIGFjdGl2ZSBpZiBpdHMgcHJpbWFyeSBwbGFuZSBoYXMgYQo+ ID5mcmFtZWJ1ZmZlciBpc24ndCByZWFsbHkgY29ycmVjdCBpbiB0aGUgdW5pdmVyc2FsIHBsYW5l IGFuZCBhdG9taWMKPiA+d29ybGQuICBXaGV0aGVyIHdlIHVzZSBwcmltYXJ5LT5mYiBvciBwcmlt YXJ5LT5zdGF0ZS0+ZmIgZG9lc24ndCByZWFsbHkKPiA+bWF0dGVyIGluIHRoaXMgY2FzZS4KPiA+ Cj4gPk15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCB0aGUgcmVhc29uIHdlIGFsc28gY2hlY2tlZCBm YiBhbmQgbW9kZSBpbgo+ID5hZGRpdGlvbiB0byBpbnRlbF9jcnRjLT5hY3RpdmUgaGFkIHRvIGRv IHdpdGggcXVpY2tib290IGxvZ2ljIGFuZCB0aGUKPiA+ZHJpdmVyJ3MgYWJpbGl0eSB0byBpbmhl cml0IHN0YXRlIHNldHVwIGJ5IHRoZSBib290IGZpcm13YXJlLiAgSSB0aGluawo+ID5KZXNzZSBv ciBWaWxsZSBtaWdodCBiZSBhYmxlIHRvIGV4cGxhaW4gdGhhdCBwYXJ0IGJldHRlciBhbmQgZGVz Y3JpYmUKPiA+YW55IHF1aWNrYm9vdCBwcm9ibGVtcyB0aGF0IHRoaXMgY2hhbmdlIG1pZ2h0IGNh dXNlLgo+ID4KPiA+VGhpcyBwYXRjaCBpcyBzdGlsbCBzb3J0IG9mIGEgYmFuZGFpZDsgdWx0aW1h dGVseSBvdXIgd2F0ZXJtYXJrIGNvZGUKPiA+c2hvdWxkIGFsbCBiZSBzdGF0ZS1iYXNlZCBhbmQg d2UnbGwgYmUgbG9va2luZyBhdCBjcnRjLT5zdGF0ZS0+YWN0aXZlCj4gPmFuZCBwbGFuZS0+c3Rh dGUtPkZPTyBhbmQgc3VjaCB0byBmaWd1cmUgb3V0IGhvdy93aGVuIHRvIHVwZGF0ZSBvdXIKPiA+ d2F0ZXJtYXJrcy4gIEJ1dCB0aGUgd2F0ZXJtYXJrIHJld29yayBpc24ndCBkb25lIHlldCBhbmQg d2UncmUgYWxzbyBzb3J0Cj4gPm9mIGluIGEgd2VpcmQgbGltYm8gc3RhZ2Ugd2hlcmUgcGxhbmVz IGFyZSBwcmV0dHkgbXVjaCBjb252ZXJ0ZWQgdG8KPiA+YXRvbWljLCBidXQgQ1JUQydzIGFyZSBz dGlsbCBiZWluZyB3b3JrZWQgb24uCj4gCj4gWWVhaC4uIHdlbGwsIEkgZG9uJ3Qgc2VlIHRoYXQg YW55dGhpbmcgd2lsbCBnbyBiYWQgd2l0aCB0aGlzLCBidXQgdGhpcyBpcwo+IHdpdGggbGlrZSA1 MCUgY29uZmlkZW5jZS4KPiAKPiBBbmQgdGhlIGNvbW1lbnQgc2FpZCBjaGVjayBjYW4gYmUgcmVt b3ZlZCB3aGVuIHdlIGNhbiAicHJvcGVybHkgcmVjb25zdHJ1Y3QKPiB0aGUgZnJhbWVidWZmZXIi IGFueXdheS4KPiAKPiBCdXQgd2hhdCBkb2VzICJwcm9wZXJseSIgbWVhbiB0aGVyZT8gRmlybXdh cmUgdGFrZSBvdmVyIGxvb2tzIHRoZXJlIHRvIG1lLgo+IFNvIG1heWJlIGl0IGNvdWxkIHJlYWxs eSBoYWQgYmVlbiByZW1vdmVkIGV2ZW4gcmVnYXJkbGVzcyBvZiB0aGlzIGZhbGxvdXQ/CgpDb21t ZW50IGlzIG91dGRhdGVkLCB3aGF0IHdlIHdhbnQgaW4gdGhlIGVuZCBpcyB0byBqdXN0IGRpc2Fi bGUgdGhlCnByaW1hcnkgcGxhbmUgYW5kIG1ha2Ugc3VyZSB0aGUgaHcgY2FuIGNvcGUuIFNpbmNl IGlmIHNvbWVvbmUgYm9vdHMgaW4gdmdhCm1vZGUgdGhlcmUgaXMgbm8gcHJpbWFyeSBwbGFuZSAo dGhlIHZnYSBwbGFuZSBpcyBzb21lIGVudGlyZWx5IHNlcGFyYXRlCmJlYXN0KS4KLURhbmllbAot LSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KKzQx ICgwKSA3OSAzNjUgNTcgNDggLSBodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=