Received-SPF: pass (google.com: domain of hamohammed.sa@gmail.com designates 2a00:1450:400c:c05::236 as permitted sender) client-ip=2a00:1450:400c:c05::236;
Date: Sat, 7 Mar 2015 20:08:07 +0300
From: Haneen Mohammed <hamohammed.sa@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: emxx_udc: Clean dev_err()
 logging
Message-ID: <20150307170806.GA2813@example.com>
References: <1425320718-28979-1-git-send-email-hamohammed.sa@gmail.com>
 <1425460224-8110-1-git-send-email-hamohammed.sa@gmail.com>
 <20150306232951.GB6279@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150306232951.GB6279@kroah.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Fri, Mar 06, 2015 at 03:29:51PM -0800, Greg KH wrote:
> On Wed, Mar 04, 2015 at 12:10:24PM +0300, Haneen Mohammed wrote:
> > This patch removes  __func__ from dev_err. dev_err includes information about:
> >  (devcice, driver, specific instance of device, etc) in the log printout, so there is no need for  __func__.
> > 
> > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> > ---
> > note: this patch separated from "Staging: emxx_udc: Fix checkpatch.pl warnings" patchset.
> > 
> >  drivers/staging/emxx_udc/emxx_udc.c | 18 ++++++++----------
> >  1 file changed, 8 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> > index 35dc1c4..cfe55dc 100644
> > --- a/drivers/staging/emxx_udc/emxx_udc.c
> > +++ b/drivers/staging/emxx_udc/emxx_udc.c
> > @@ -2632,7 +2632,7 @@ static int nbu2ss_ep_enable(
> >  	if ((udc->driver == NULL)
> >  		|| (udc->gadget.speed == USB_SPEED_UNKNOWN)) {
> >  
> > -		dev_err(ep->udc->dev, " *** %s, udc !!\n", __func__);
> > +		dev_err(ep->udc->dev, "  udc !!\n");
> 
> Why keep the leading spaces?
> 
> And dev_err() does not have __func__ in it, so maybe this should just be
> left alone, as these messages are not unique enough to determine the
> exact place the error happened.
> 
> sorry for missing that last time.
> 
> greg k-h

what about the other patches? You have told me to refresh my tree and resubmit the other
patchset, should I do that? or just leave it as it is?

Thank you,
Haneen