From: Dario Faggioli Subject: [PATCH v2 1/7] xl: turn some int local variable into bool Date: Fri, 13 Mar 2015 12:09:03 +0100 Message-ID: <20150313110903.32539.96348.stgit@Solace.station> References: <20150313110535.32539.77102.stgit@Solace.station> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150313110535.32539.77102.stgit@Solace.station> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Wei Liu , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org more specifically, the ones used as argument presence flags in `xl list'. Signed-off-by: Dario Faggioli Cc: Ian Campbell Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu Acked-by: Wei Liu --- Changes from v1: * use true/false for actual parameters, as requested during review --- tools/libxl/xl_cmdimpl.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index a27ac9e..3122fd5 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -3505,7 +3505,7 @@ static void print_bitmap(uint8_t *map, int maplen, FILE *stream) } } -static void list_domains(int verbose, int context, int claim, int numa, +static void list_domains(bool verbose, bool context, bool claim, bool numa, const libxl_dominfo *info, int nb_domain) { int i; @@ -4489,10 +4489,11 @@ int main_reboot(int argc, char **argv) int main_list(int argc, char **argv) { - int opt, verbose = 0; - int context = 0; - int details = 0; - int numa = 0; + int opt; + bool verbose = false; + bool context = false; + bool details = false; + bool numa = false; static struct option opts[] = { {"long", 0, 0, 'l'}, {"verbose", 0, 0, 'v'}, @@ -4508,16 +4509,16 @@ int main_list(int argc, char **argv) SWITCH_FOREACH_OPT(opt, "lvhZn", opts, "list", 0) { case 'l': - details = 1; + details = true; break; case 'v': - verbose = 1; + verbose = true; break; case 'Z': - context = 1; + context = true; break; case 'n': - numa = 1; + numa = true; break; } @@ -4550,7 +4551,8 @@ int main_list(int argc, char **argv) if (details) list_domains_details(info, nb_domain); else - list_domains(verbose, context, 0 /* claim */, numa, info, nb_domain); + list_domains(verbose, context, false /* claim */, numa, + info, nb_domain); if (info_free) libxl_dominfo_list_free(info, nb_domain); @@ -6600,8 +6602,8 @@ int main_claims(int argc, char **argv) return 1; } - list_domains(0 /* verbose */, 0 /* context */, 1 /* claim */, - 0 /* numa */, info, nb_domain); + list_domains(false /* verbose */, false /* context */, true /* claim */, + false /* numa */, info, nb_domain); libxl_dominfo_list_free(info, nb_domain); return 0;