From: Daniel Vetter Subject: Re: [RFC v5 9/9] drm/i915: Backlight control using CRC PMIC based PWM driver Date: Fri, 13 Mar 2015 18:20:53 +0100 Message-ID: <20150313172053.GN3800@phenom.ffwll.local> References: <1426177893-17945-1-git-send-email-shobhit.kumar@intel.com> <1426177893-17945-10-git-send-email-shobhit.kumar@intel.com> <20150313143043.GF17419@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 135D36EAF8 for ; Fri, 13 Mar 2015 10:19:13 -0700 (PDT) Received: by widex7 with SMTP id ex7so7986739wid.3 for ; Fri, 13 Mar 2015 10:19:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150313143043.GF17419@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Alexandre Courbot , Samuel Ortiz , Jani Nikula , Shobhit Kumar , intel-gfx , Thierry Reding , Daniel Vetter , Linus Walleij List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMTMsIDIwMTUgYXQgMDQ6MzA6NDNQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFRodSwgTWFyIDEyLCAyMDE1IGF0IDEwOjAxOjMzUE0gKzA1MzAsIFNob2Jo aXQgS3VtYXIgd3JvdGU6Cj4gPiBDQzogU2FtdWVsIE9ydGl6IDxzYW1lb0BsaW51eC5pbnRlbC5j b20+Cj4gPiBDYzogTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVpakBsaW5hcm8ub3JnPgo+ID4g Q2M6IEFsZXhhbmRyZSBDb3VyYm90IDxnbnVyb3VAZ21haWwuY29tPgo+ID4gQ2M6IFRoaWVycnkg UmVkaW5nIDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBTaG9i aGl0IEt1bWFyIDxzaG9iaGl0Lmt1bWFyQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RzaS5jIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaS5oIHwgIDMgKysrCj4gPiAgMiBmaWxl cyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rz aS5jCj4gPiBpbmRleCAyMTk0MjFjLi41MTE0NDZmIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHNpLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RzaS5jCj4gPiBAQCAtMzIsNiArMzIsNyBAQAo+ID4gICNpbmNsdWRlIDxkcm0vZHJtX21p cGlfZHNpLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiA+ICAjaW5jbHVkZSA8bGlu dXgvZ3Bpby9jb25zdW1lci5oPgo+ID4gKyNpbmNsdWRlIDxsaW51eC9wd20uaD4KPiA+ICAjaW5j bHVkZSAiaTkxNV9kcnYuaCIKPiA+ICAjaW5jbHVkZSAiaW50ZWxfZHJ2LmgiCj4gPiAgI2luY2x1 ZGUgImludGVsX2RzaS5oIgo+ID4gQEAgLTQwMiw2ICs0MDMsMTAgQEAgc3RhdGljIHZvaWQgaW50 ZWxfZHNpX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiA+ICAKPiA+ICAJ CWludGVsX2RzaV9wb3J0X2VuYWJsZShlbmNvZGVyKTsKPiA+ICAJfQo+ID4gKwo+ID4gKwkvKiBF bmFibGUgdGhlIGJhY2tsaWdodCB3aXRoIGRlZmF1bHQgUFdNIGFzIHByb2dyYW1tZWQgYnkgQklP UyAqLwo+ID4gKwlwd21fZW5hYmxlKGludGVsX2RzaS0+cHdtKTsKPiA+ICsJcHdtX2NvbmZpZ19h bHRlcm5hdGUoaW50ZWxfZHNpLT5wd20sIDB4N0YsIDEwMCk7Cj4gCj4gSSBzdXBwb3NlIHdlIG1p Z3RoIHdhbnQgdG8gd3JhcCB0aGVzZSBpbiAnaWYgKGludGVsX2RzaS0+cHdtKScgY2hlY2tzLAo+ IG9yIGRvZXMgdGhlIHB3bSBzdWJzeXN0ZW0gdGFrZSBjYXJlIG9mIE5VTEwgY2hlY2tzIGZvciB1 cz8KPiAKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgaW50ZWxfZHNpX3ByZV9lbmFibGUo c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIpCj4gPiBAQCAtNDY3LDYgKzQ3MiwxMSBAQCBz dGF0aWMgdm9pZCBpbnRlbF9kc2lfcHJlX2Rpc2FibGUoc3RydWN0IGludGVsX2VuY29kZXIgKmVu Y29kZXIpCj4gPiAgCj4gPiAgCURSTV9ERUJVR19LTVMoIlxuIik7Cj4gPiAgCj4gPiArCS8qIERp c2FibGUgdGhlIGJhY2tsaWdodCAqLwo+ID4gKwlwd21fY29uZmlnX2FsdGVybmF0ZShpbnRlbF9k c2ktPnB3bSwgMHg3RiwgMCk7Cj4gPiArCXVzbGVlcF9yYW5nZSgyMDAwLCAzMDAwKTsKPiA+ICsJ cHdtX2Rpc2FibGUoaW50ZWxfZHNpLT5wd20pOwo+IAo+IGRpdHRvCj4gCj4gPiArCj4gPiAgCWlm IChpc192aWRfbW9kZShpbnRlbF9kc2kpKSB7Cj4gPiAgCQkvKiBTZW5kIFNodXRkb3duIGNvbW1h bmQgdG8gdGhlIHBhbmVsIGluIExQIG1vZGUgKi8KPiA+ICAJCWZvcl9lYWNoX2RzaV9wb3J0KHBv cnQsIGludGVsX2RzaS0+cG9ydHMpCj4gPiBAQCAtOTcxLDYgKzk4MSwxMCBAQCBzdGF0aWMgdm9p ZCBpbnRlbF9kc2lfZW5jb2Rlcl9kZXN0cm95KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikK PiA+ICAJaWYgKGludGVsX2RzaS0+Z3Bpb19wYW5lbCkKPiA+ICAJCWdwaW9kX3B1dChpbnRlbF9k c2ktPmdwaW9fcGFuZWwpOwo+ID4gIAo+ID4gKwkvKiBkaXNwb3NlIG9mIHRoZSBwd20gKi8KPiA+ ICsJaWYgKGludGVsX2RzaS0+cHdtKQo+ID4gKwkJcHdtX3B1dChpbnRlbF9kc2ktPnB3bSk7Cj4g PiArCj4gPiAgCWludGVsX2VuY29kZXJfZGVzdHJveShlbmNvZGVyKTsKPiA+ICB9Cj4gPiAgCj4g PiBAQCAtMTA5OCw2ICsxMTEyLDE3IEBAIHZvaWQgaW50ZWxfZHNpX2luaXQoc3RydWN0IGRybV9k ZXZpY2UgKmRldikKPiA+ICAJCQlEUk1fRVJST1IoIkZhaWxlZCB0byBvd24gZ3BpbyBmb3IgcGFu ZWwgY29udHJvbFxuIik7Cj4gPiAgCQkJaW50ZWxfZHNpLT5ncGlvX3BhbmVsID0gTlVMTDsKPiA+ ICAJCX0KPiA+ICsKPiA+ICsJCS8qIEdldCB0aGUgUFdNIGNoaXAgZm9yIGJhY2tsaWdodCBjb250 cm9sICovCj4gPiArCQlpbnRlbF9kc2ktPnB3bSA9IHB3bV9nZXQoZGV2LT5kZXYsICJwd21fYmFj a2xpZ2h0Iik7Cj4gPiArCQlpZiAoSVNfRVJSKGludGVsX2RzaS0+cHdtKSkgewo+ID4gKwkJCURS TV9FUlJPUigiRmFpbGQgdG8gb3duIHRoZSBwd20gY2hpcFxuIik7Cj4gPiArCQkJaW50ZWxfZHNp LT5wd20gPSBOVUxMOwoKSWYgdGhlIGk5MTUua28gZHJpdmVyIGxvYWRzIGJlZm9yZSB0aGUgbWZk LmtvIGRyaXZlciB3ZSBuZWVkIHRvIGRvIGEKZGVmZXJyZWQgcHJvYmUgaGVyZSBJIHRoaW5rLiBK dXN0IGZhaWxpbmcgaXNuJ3Qgcm9idXN0LgoKVGhpcyBhbHNvIG1lYW5zIHRoYXQgaWYgcGVvcGxl IGRvbid0IGNvbmZpZ3VyZSB0aGVpciBrZXJuZWwgcHJvcGVybHkgdGhlbgp3ZSdsbCBmYWxsIG92 ZXIgaGVyZSwgYnV0IG1laC4KLURhbmllbAoKPiA+ICsJCX0gZWxzZSBpZiAocHdtX2NvbmZpZ19h bHRlcm5hdGUoaW50ZWxfZHNpLT5wd20sIDB4N0YsIDEwMCkgPCAwKSB7Cj4gPiArCQkJRFJNX0VS Uk9SKCJGYWlsZWQgdG8gY29uZmlndXJlIHRoZSBwd20gY2hpcFxuIik7Cj4gPiArCQkJcHdtX3B1 dChpbnRlbF9kc2ktPnB3bSk7Cj4gPiArCQkJaW50ZWxfZHNpLT5wd20gPSBOVUxMOwo+ID4gKwkJ fQo+ID4gIAl9Cj4gPiAgCj4gPiAgCWludGVsX2VuY29kZXItPnR5cGUgPSBJTlRFTF9PVVRQVVRf RFNJOwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaS5oIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpLmgKPiA+IGluZGV4IDhiZTc1YTcuLmQ4ZWM5 YzEgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuaAo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpLmgKPiA+IEBAIC01Miw2ICs1Miw5 IEBAIHN0cnVjdCBpbnRlbF9kc2kgewo+ID4gIAkvKiBHUElPIERlc2MgZm9yIENSQyBiYXNlZCBQ YW5lbCBjb250cm9sICovCj4gPiAgCXN0cnVjdCBncGlvX2Rlc2MgKmdwaW9fcGFuZWw7Cj4gPiAg Cj4gPiArCS8qIFBXTSBjaGlwICovCj4gPiArCXN0cnVjdCBwd21fZGV2aWNlICpwd207Cj4gPiAr Cj4gPiAgCXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmF0dGFjaGVkX2Nvbm5lY3RvcjsKPiA+ICAK PiA+ICAJLyogYml0IG1hc2sgb2YgcG9ydHMgYmVpbmcgZHJpdmVuICovCj4gPiAtLSAKPiA+IDIu MS4wCj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCj4gPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwgT1RDCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5p ZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5 IDM2NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==