Received-SPF: pass (google.com: domain of gregkh@linuxfoundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12;
Date: Sun, 15 Mar 2015 11:45:57 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Vatika Harlalka <vatikaharlalka@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: fbtbt: Move variable
 declarations
Message-ID: <20150315104557.GB543@kroah.com>
References: <20150312092128.GA7207@akanksha>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150312092128.GA7207@akanksha>
User-Agent: Mutt/1.5.23 (2014-03-12)

On Thu, Mar 12, 2015 at 02:51:28PM +0530, Vatika Harlalka wrote:
> Move variable declarations so as to follow kernel coding
> conventions.
> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/fbtft/fb_agm1264k-fl.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c b/drivers/staging/fbtft/fb_agm1264k-fl.c
> index 2ec607d..acf5acb 100644
> --- a/drivers/staging/fbtft/fb_agm1264k-fl.c
> +++ b/drivers/staging/fbtft/fb_agm1264k-fl.c
> @@ -410,15 +410,14 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
>  
>  static int write(struct fbtft_par *par, void *buf, size_t len)
>  {
> +	u8 i, data;
> +
>  	fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
>  		"%s(len=%d): ", __func__, len);
>  
>  	gpio_set_value(par->RW, 0); /* set write mode */
>  
> -
>  	while (len--) {
> -		u8 i, data;
> -

Why?  There is nothing wrong with this code at all, please leave it
as-is, unless there is a good reason to move it.

thanks,

greg k-h