From: Andrew Morton Date: Thu, 19 Mar 2015 15:23:05 -0700 Subject: [Ocfs2-devel] [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error In-Reply-To: <20150227234840.GA12922@devel.8.8.4.4> References: <20150227234840.GA12922@devel.8.8.4.4> Message-ID: <20150319152305.d4ff5c83744591ff9340db92@linux-foundation.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daeseok Youn Cc: mfasheh@suse.com, jlbec@evilplan.org, ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org, richard.weinberger@gmail.com On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn wrote: > The use of 'status' in __ocfs2_add_entry() can return wrong > status when some functions are failed. > > If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed, > that status is saved to 'status' but return variable is 'retval' > which is saved 'success' status. In case of this, __ocfs2_add_entry() > is failed but can be returned as 'success'. > > So replace 'status' with 'retval'. > > - mlog_errno(status); > + if (retval) { > + mlog_errno(retval); > goto bail; and bail: if (retval) mlog_errno(retval); return retval; } so we'll clearly log the same error twice.