Received: from eggs.gnu.org ([2001:4830:134:3::10]:39348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYtzg-0005QB-V2 for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:17:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYtzd-0003Hz-Oq for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:17:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYtzd-0003Ht-JC for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:17:29 -0400 Date: Fri, 20 Mar 2015 11:17:26 +0100 From: Igor Mammedov Message-ID: <20150320111726.3727f305@nial.brq.redhat.com> In-Reply-To: <1426824898-9936-1-git-send-email-lma@suse.com> References: <1426824898-9936-1-git-send-email-lma@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] object_del: Prevent removing an in-use memory backend object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lin Ma Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Fri, 20 Mar 2015 12:14:58 +0800 Lin Ma wrote: > showing a memory device whose memdev is removed leads an assert: > > (qemu) object_add memory-backend-ram,id=ram0,size=128M > (qemu) device_add pc-dimm,id=d0,memdev=ram0 > (qemu) object_del ram0 > (qemu) info memory-devices > ** > ERROR:qom/object.c:1274:object_get_canonical_path_component:\ > assertion failed: (obj->parent != NULL) > Aborted > > The patch prevents removing an in-use mem backend and outputs an error msg. > > Signed-off-by: Lin Ma > --- > qmp.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/qmp.c b/qmp.c > index c479e77..0086e2d 100644 > --- a/qmp.c > +++ b/qmp.c > @@ -704,6 +704,7 @@ void qmp_object_del(const char *id, Error **errp) > { > Object *container; > Object *obj; > + const char *typename; > > container = container_get(object_get_root(), "/objects"); > obj = object_resolve_path_component(container, id); > @@ -711,6 +712,19 @@ void qmp_object_del(const char *id, Error **errp) > error_setg(errp, "object id not found"); > return; > } > + > + typename = object_class_get_name(object_class_get_parent(\ > + object_get_class(OBJECT(obj)))); > + if (strcmp(typename, TYPE_MEMORY_BACKEND) == 0 ) { > + MemoryRegion *mr; > + mr = host_memory_backend_get_memory(MEMORY_BACKEND(obj), errp); > + if (memory_region_is_mapped(mr)) { > + char *path = object_get_canonical_path_component(obj); > + error_setg(errp, "memdev %s is in used.", path); > + g_free(path); > + return; > + } > + } How about making it more generic? i.e if (!obj_class->can_be_deleted(obj)) error out > object_unparent(obj); > } >