Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:42994 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbbCTMjY (ORCPT ); Fri, 20 Mar 2015 08:39:24 -0400 Date: Fri, 20 Mar 2015 13:39:22 +0100 From: David Sterba To: Filipe David Manana Cc: "dsterba@suse.cz" , Martin Steigerwald , "linux-btrfs@vger.kernel.org" Subject: Re: number of hardlinks for directory in ls -lid always 1? Message-ID: <20150320123922.GL20767@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <9389540.MYekrP2a8Q@merkaba> <1929370.YSr7hGqtmM@merkaba> <20150318135230.GA20767@twin.jikos.cz> <7757761.93uGJVH8dW@merkaba> <20150319132139.GE20767@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, Mar 19, 2015 at 09:47:15PM +0000, Filipe David Manana wrote: > On Thu, Mar 19, 2015 at 1:21 PM, David Sterba wrote: > > On Wed, Mar 18, 2015 at 03:23:50PM +0100, Martin Steigerwald wrote: > >> It explains that having a correct hardlink number for directory is not > >> mandatory, but it doesn´t explain why BTRFS always has 1 in there instead > >> of the actual count of hardlinks. Is this an performance optimization for > >> BTRFS or are there any other reasons why BTRFS does it this way? > > > > I believe it's for performance reasons. New inodes do not update the > > parent directory metadata wrt link counts, compared to other filesystems > > that do that. > > Weird. Because creating a new inode implies adding the dentry to the > parent directory, which implies updating the directory's i_size. I wonder why the link count is not maintained then. The directory inode is modified anyway, add a few ifs here and there will not make things worse and we could get rid of this special behaviour, plus find could use the link count reliably. It can be turned on in a fully backward compatible way: * new directories/subvolumes will get dir nlink set to 2 * if mkdir/rmdir/move sees a parent link count of 1, no change * otherwise inc/dec the link count for new subdirectoris/subvolumes Jeff Liu reported a problem, without further details http://article.gmane.org/gmane.comp.file-systems.btrfs/14628 so I still might be missing something.