From: Mark Rutland <mark.rutland@arm.com>
Date: Fri, 20 Mar 2015 18:29:00 +0000
Subject: [U-Boot] [PATCH v3 04/28] armv8/ls2085a: Fix generic timer
	clock source
In-Reply-To: <1426875211-6072-1-git-send-email-yorksun@freescale.com>
References: <1426875211-6072-1-git-send-email-yorksun@freescale.com>
Message-ID: <20150320182859.GB24455@leverpostej>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> diff --git a/arch/arm/cpu/armv8/fsl-lsch3/mp.c b/arch/arm/cpu/armv8/fsl-lsch3/mp.c
> index ce9c0c1..5338fe6 100644
> --- a/arch/arm/cpu/armv8/fsl-lsch3/mp.c
> +++ b/arch/arm/cpu/armv8/fsl-lsch3/mp.c
> @@ -30,6 +30,13 @@ int fsl_lsch3_wake_seconday_cores(void)
>  	u32 cores, cpu_up_mask = 1;
>  	int i, timeout = 10;
>  	u64 *table = get_spin_tbl_addr();
> +#ifdef COUNTER_FREQUENCY_REAL
> +	unsigned long cntfrq = COUNTER_FREQUENCY_REAL;
> +
> +	__real_cntfrq = cntfrq;	/* update for secondary cores */

Do you need the temporary cntfrq variable? Can't you just have:

	__real_cntfrq = COUNTER_FREQUENCY_REAL;

> +	flush_dcache_range((unsigned long)&__real_cntfrq,
> +			   (unsigned long)&__real_cntfrq + 8);

This looks fine, as does the rest of the patch.

So either way:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.