From: Daniel Vetter Subject: Re: [PATCH 3/9] drm/i915: Use the CRC gpio for panel enable/disable Date: Tue, 24 Mar 2015 10:50:47 +0100 Message-ID: <20150324095046.GG1349@phenom.ffwll.local> References: <20150313142936.GE17419@intel.com> <1426480967-20029-1-git-send-email-shobhit.kumar@intel.com> <20150324083241.GX1349@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 2200E89BD5 for ; Tue, 24 Mar 2015 02:49:03 -0700 (PDT) Received: by wgbcc7 with SMTP id cc7so166486398wgb.0 for ; Tue, 24 Mar 2015 02:49:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Linus Walleij Cc: Alexandre Courbot , Samuel Ortiz , Mark Brown , Shobhit Kumar , intel-gfx , Thierry Reding , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMjQsIDIwMTUgYXQgMTA6MzU6MzJBTSArMDEwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBPbiBUdWUsIE1hciAyNCwgMjAxNSBhdCA5OjMyIEFNLCBEYW5pZWwgVmV0dGVyIDxk YW5pZWxAZmZ3bGwuY2g+IHdyb3RlOgo+IAo+ID4gVGhlIGNyeXN0YWxjb3ZlIHBtaWMgdGhpbmcg aGVyZSByZWFsbHkgaXMganVzdCBhIGR1bWIgZ3BpbyBsaW5lIHRoYXQgZm9yCj4gPiB0aGUgcmVm ZXJlbmNlIGRlc2lnbiBnZXRzIHJvdXRlZCB0byB0aGUgcGFuZWwgKGFuZCBoZW5jZSBoYXMgdGhh dCBhcyB0aGUKPiA+IHVzdWFsIG5hbWUpLgo+IAo+IFNvIG9idmlvdXNseSB0aGUgcmVmbWFuIGNh bGxzIHRoaXMgcmVnaXN0ZXIgYXQgb2Zmc2V0IDB4NTIKPiBQQU5FTF9FTi9ESVNBQkxFIG5vdCBH UElPX0ZPTy4KPiAKPiA+IEFuZCB3aGF0IHdlIHdhbnQgdG8gZG8gaGVyZSBpcyBnZXQgc29tZSBy ZWFzb25hYmxlIHdheSB0bwo+ID4gcm91dGUgdGhhdCBncGlvIGxpbmUgY29udHJvbCBiZXR3ZWVu IHR3byB0b3RhbGx5IGRpZmZlcmVudCBkcml2ZXJzLgo+ID4KPiA+IEFsc28gcGxlYXNlIG5vdGUg dGhhdCB4ODYgaXMgYSBsb3Qgc2hpdHRpZXIgdGhhbiBhcm0gZm9yIHRoaXMga2luZCBvZgo+ID4g aW50ZXItZHJpdmVyLWRlcGVuY2llcyBzaW5jZSB3ZSBkb24ndCBldmVuIGhhdmUgYm9hcmQgZmls ZXMuIEhlbmNlIGFsc28KPiA+IHdoeSB0aGlzIHNlcmllcyBoYXMgc29tZSBwYXRjaGVzIHRvIGV4 cG9zZSB0aGUgYm9hcmQgZmlsZSBpbml0IHN0dWZmIHRvCj4gPiB0aGUgcG1pYyBkcml2ZXIgZm9y IHNldHVwLgo+IAo+IFdlIGRvbid0IGRvIGJvYXJkIGZpbGVzIGZvciBBUk0gYW55bW9yZSBlaXRo ZXIuIFdlIGRvIHRoaXMKPiB1c2luZyBkZXZpY2UgdHJlZSB3aGljaCBpcyBzaW1pbGFyIHRvIGhv dyB4ODYgdXNlIEFDUEkuCgpNYXliZSBJIHdhc250JyBjbGVhcjogVGhpcyBpcyB0aGUgaTkxNSBn ZnggZHJpdmVyLCB3ZSBub29kbGUgdGhpcwppbmZvcm1hdGlvbiBvdXQgb2YgYW4gZXZlbiBpbnRl cm5hbGx5IHVuZGVyc3BlY2lmaWVkIHZiaW9zIHRhYmxlLiBJdCBfaXNfCndvcnNlIHRoYW4gYm9h cmQgZmlsZXMuCgpBbHNvIHRoZXNlIHRhYmxlcyBzcGVjaWZ5IHRoZSBwcmVjaXNlIHBvd2VyIHNl cXVlbmNlIHVzaW5nIGZvcnRoICh0aGF0CnBhcnQgaXNuJ3QgaW4gdGhpcyBzZXJpZXMpLiAgSW1w bGVtZW50aW5nIGEgcmVndWxhdG9yIGZvciB0aGlzIHdvdWxkIGJlIGEKZXZlbiBiaWdnZXIgbGll IHRoYW4gd2hhdGV2ZXIga2luZCBvZiBsaWUgdXNlIHNlZSBpbiBleHBvc2luZyB0aGlzIGFzIGEK Z3Bpby4KCj4gPiBBbnl3YXkgaWYgeW91IHN0aWxsIHRoaW5rIGdwaW8gaXMgdG90YWxseSB0aGUg d3JvbmcgdGhpbmcgdGhlbiB3ZSdsbCBqdXN0Cj4gPiByb2xsIG91ciBvd24gdXNpbmcgdGhlIGNv bXBvbmVudCBmcmFtZXdvcmsuCj4gCj4gSSBndWVzcyBJIGJldHRlciBub3Qgc2F5IG5vIGlmIHRo ZSBhbHRlcm5hdGl2ZSBpcyBldmVuIHVnbGllci4KPiAKPiBUaGUgcHJvYmxlbSBJIGhhdmUgaXMg R1BJTyBiZWluZyB1c2VkIGFzIGtpdGNoZW4gc2luaywgYW5kCj4gYSByZWNlbnQgaW5jaWRlbnQg d2hlcmUgc29tZW9uZSBpbnN0YW50aWF0ZWQgZ2VuZXJpYyBHUElPCj4gY2hpcHMgb3ZlciBzb21l IDMyYml0IHJlZ2lzdGVyIGp1c3QgdG8gYmFzaWNhbGx5IHBva2UgYml0cyBpbiB0aGF0Cj4gcmVn aXN0ZXIgdG8gdHVybiBMRURzIG9uL29mZi4gU28gYSBsYXllciBjYWtlIGxpa2U6Cj4gR1BJTyBM RURzIDwtPiBnZW5lcmljIEdQSU8gPC0+IFJlZ2lzdGVyLgo+IAo+IEl0J3MgbmljZSBhbmQgc2lt cGxlIGZvciB0aGF0IHVzZXIgYXMgaXQncyB1c2luZyBleGlzdGluZyBrZXJuZWwgY29kZQo+IGFu ZCBqdXN0IG5lZWRzIHNvbWUgZGV2aWNlIHRyZWUgYWJzdHJhY3Qgc3R1ZmYgdG8gZ2V0IGdvaW5n LCBhbmQKPiBpdCB3b3Jrcy4gVGhlIHByb2JsZW0gaXMgdGhhdCBpdCB0YWtlcyBzb21ldGhpbmcg dGhhdCBpcyBub3QKPiBHUElPIChyYXRoZXIgYSBzZXQgb2YgYml0cyBjb250cm9sbGluZyBMRURz KSBhbmQgcHJldGVuZHMgdGhhdAo+IGl0IGlzIEdQSU8sIHdoaWxlIGl0IGlzIG5vdCwganVzdCB0 byBiZSBhYmxlIHRvIHVzZSBHUElPIExFRHMuCj4gV2hpbGUgdGhlIHJlYWwgc29sdXRpb24gaXMg dG8gd3JpdGUgYSBwdXJlIExFRCBkcml2ZXIsIHBvc3NpYmx5Cj4gb25lIHVzaW5nIHNvbWUgcmFu ZG9tIDMyYml0IHJlZ2lzdGVycywgTEVEIE1NSU8gb3Igd2hhdGV2ZXIuCj4gCj4gQW55d2F5LiBJ IHN0aWxsIHRoaW5rIGEgZml4ZWQgdm9sdGFnZSByZWd1bGF0b3Igd291bGQgYmUgc3VpdGFibGUK PiBmb3IgdGhpcy4KPiAKPiBIZXJlIGlzIGFuIGV4YW1wbGUgb2YgaG93IHdlIGRvIGRldmljZSB0 cmVlOgo+IAo+ICAgICAgICAgZW5fM3YzX3JlZzogZW5fM3YzIHsKPiAgICAgICAgICAgICAgICAg Y29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQiOwo+ICAgICAgICAgICAgICAgICByZWd1bGF0 b3ItbmFtZSA9ICJlbi0zdjMtZml4ZWQtc3VwcGx5IjsKPiAgICAgICAgICAgICAgICAgcmVndWxh dG9yLW1pbi1taWNyb3ZvbHQgPSA8MzMwMDAwMD47Cj4gICAgICAgICAgICAgICAgIHJlZ3VsYXRv ci1tYXgtbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ICAgICAgICAgICAgICAgICBncGlvID0gPCZh Yjg1MDBfZ3BpbyAyNSAweDQ+Owo+ICAgICAgICAgICAgICAgICBzdGFydHVwLWRlbGF5LXVzID0g PDUwMDA+Owo+ICAgICAgICAgICAgICAgICBlbmFibGUtYWN0aXZlLWhpZ2g7Cj4gICAgICAgICB9 Owo+IAo+IEluIHRoaXMgY2FzZSB0aGUgcmVndWxhdG9yIGlzIGJhc2VkIG9uIHRvcCBvZiBhIEdQ SU8gcGluLAo+IHNvIGJ5IHNldHRpbmcgdGhhdCBHUElPIGxpbmUgaGlnaCwgc29tZSBmZWF0dXJl IG9uIHRoZSBQQ0IKPiB3aWxsIGRyaXZlIGEgdm9sdGFnZSBhdCAzLjNWLgo+IAo+IEEgTUZEIGNl bGwgc3Bhd25lZCByZWd1bGF0b3IgY2FuIGJlIGEgdmVyeSBzbWFsbGlzaAo+IHRoaW5nIGluIGRy aXZlcnMvcmVndWxhdG9yLiBTdXJlLCBub3QgNSBsaW5lcyBpbiB0aGUgZXhpc3RpbmcKPiBHUElP IGRyaXZlciwgYnV0IHN0aWxsIHNtYWxsaXNoLgo+IAo+IFlvdSBtYXkgYWN0dWFsbHkgKm5lZWQq IHRvIHVzZSB0aGUgZml4ZWQgdm9sdGFnZSByZWd1bGF0b3IKPiB0b286IGlmIHlvdSBoYXZlIGEg cG93ZXItb24tZGVsYXkgZm9yIGl0LCB0aGF0IHRoZSBzb2Z0d2FyZSBuZWVkCj4gdG8gdGFrZSBp bnRvIGFjY291bnQsIHRoZSByZWd1bGF0b3IgZnJhbWV3b3JrIGlzIHlvdXIgZnJpZW5kLgo+IEVs c2UgdGhlcmUgd2lsbCBiZSBrbHVkZ3kgY29kZSBzdXJyb3VuZGluZyB0aGUgR1BJTyBlbmFibGUo KQo+IG9wZXJhdGlvbiB0byByZWltcGxlbWVudCB0aGUgc2FtZSBzb2x1dGlvbiAoSSBoYXZlIHNl ZW4gdGhpcwo+IGhhcHBlbikuCj4gCj4gU28gSSBpbWFnaW5lIHNvbWV0aGluZyBsaWtlIHRoaXMg aW4gZHJpdmVycy9yZWd1bGF0b3IvY3J5c3RhbC1wYW5lbC5jOgo+IAo+ICNpbmNsdWRlIDxsaW51 eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPiAjaW5jbHVkZSA8bGludXgvYml0b3BzLmg+Cj4gI2luY2x1 ZGUgPGxpbnV4L3JlZ21hcC5oPgo+ICNpbmNsdWRlIDxsaW51eC9tZmQvaW50ZWxfc29jX3BtaWMu aD4KPiAKPiAjZGVmaW5lIFBBTkVMX0VOIDB4NTIKPiAKPiBzdGF0aWMgaW50IGNyeXN0YWxfZW5h YmxlX3JlZ3VsYXRvcihzdHJ1Y3QgcmVndWxhdG9yX2RldiAqcmVnKQo+IHsKPiAgICAgICAgIHN0 cnVjdCBpbnRlbF9zb2NfcG1pYyAqcG1pYyA9IHJkZXZfZ2V0X2RydmRhdGEocmVnKTsKPiAKPiAg ICAgICAgIHJldHVybiByZWdtYXBfdXBkYXRlX2JpdHMocG1pYy0+cmVnbWFwLCBQQU5FTF9FTiwg MSwgMSk7Cj4gfQo+IAo+IHN0YXRpYyBpbnQgY3J5c3RhbF9kaXNhYmxlX3JlZ3VsYXRvcihzdHJ1 Y3QgcmVndWxhdG9yX2RldiAqcmVnKQo+IHsKPiAgICAgICAgIHN0cnVjdCBpbnRlbF9zb2NfcG1p YyAqcG1pYyA9IHJkZXZfZ2V0X2RydmRhdGEocmVnKTsKPiAKPiAgICAgICAgIHJldHVybiByZWdt YXBfdXBkYXRlX2JpdHMocG1pYy0+cmVnbWFwLCBQQU5FTF9FTiwgMSwgMCk7Cj4gfQo+IAo+IHN0 YXRpYyBpbnQgY3J5c3RhbF9pc19lbmFibGVkX3JlZ3VsYXRvcihzdHJ1Y3QgcmVndWxhdG9yX2Rl diAqcmVnKQo+IHsKPiAgICAgICAgIHN0cnVjdCBpbnRlbF9zb2NfcG1pYyAqcG1pYyA9IHJkZXZf Z2V0X2RydmRhdGEocmVnKTsKPiAgICAgICAgIGludCByZXQ7Cj4gICAgICAgICB1bnNpZ25lZCBp bnQgdmFsOwo+IAo+ICAgICAgICAgcmV0ID0gcmVnbWFwX3JlYWQocG1pYy0+cmVnbWFwLCBQQU5F TF9FTiwgJnZhbCk7Cj4gICAgICAgICBpZiAocmV0KQo+ICAgICAgICAgICAgICAgICByZXR1cm4g cmV0Owo+IAo+ICAgICAgICAgcmV0dXJuIHZhbCAmIDB4MTsKPiB9Cj4gCj4gc3RhdGljIHN0cnVj dCByZWd1bGF0b3Jfb3BzIGNyeXN0YWxfcGFuZWxfcmVnX29wcyA9IHsKPiAgICAgICAgIC5lbmFi bGUgICAgICA9IGNyeXN0YWxfZW5hYmxlX3JlZ3VsYXRvciwKPiAgICAgICAgIC5kaXNhYmxlICAg ICA9IGNyeXN0YWxfZGlzYWJsZV9yZWd1bGF0b3IsCj4gICAgICAgICAuaXNfZW5hYmxlZCAgPSBj cnlzdGFsX2lzX2VuYWJsZWRfcmVndWxhdG9yLAo+IH07Cj4gCj4gc3RhdGljIHN0cnVjdCByZWd1 bGF0b3JfZGVzYyBjcnlzdGFsX3BhbmVsX3JlZ3VsYXRvciA9IHsKPiAgICAgICAgLm5hbWUgPSAi Y3J5c3RhbC1wYW5lbCIsCj4gICAgICAgIC5maXhlZF91ViA9IDMzMDAwMDAsIC8qIE9yIHdoYXRl dmVyIHZvbHRhZ2UgdGhlIHBhbmVsIGhhcyAqLwo+ICAgICAgICAub3BzID0gJmNyeXN0YWxfcGFu ZWxfcmVnX29wcywKPiAgICAgICAgLmlkID0gMSwKPiAgICAgICAgLnR5cGUgPSBSRUdVTEFUT1Jf Vk9MVEFHRSwKPiAgICAgICAgLm93bmVyID0gVEhJU19NT0RVTEUsCj4gICAgICAgIC5lbmFibGVf dGltZSA9IE5OTiwgLyogVGhpcyBtYXkgYmUgcmVsZXZhbnQhICovCj4gfTsKPiAKPiBzdGF0aWMg aW50IGNyeXN0YWxjb3ZlX3BhbmVsX3JlZ3VsYXRvcl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2 aWNlICpwZGV2KQo+IHsKPiAgICAgICAgIHN0cnVjdCBkZXZpY2UgKmRldiA9IHBkZXYtPmRldi5w YXJlbnQ7Cj4gICAgICAgICBzdHJ1Y3QgaW50ZWxfc29jX3BtaWMgKnBtaWMgPSBkZXZfZ2V0X2Ry dmRhdGEoZGV2KTsKPiAgICAgICAgIHN0cnVjdCByZWd1bGF0b3JfY29uZmlnIGNvbmZpZyA9IHsg fTsKPiAKPiAgICAgICAgIGNvbmZpZy5kZXYgPSAmcGRldi0+ZGV2Owo+ICAgICAgICAgY29uZmln LmRyaXZlcl9kYXRhID0gcG1pYzsKPiAgICAgICAgIHJldHVybiBkZXZtX3JlZ3VsYXRvcl9yZWdp c3RlcigmcGRldi0+ZGV2LAo+ICZjcnlzdGFsX3BhbmVsX3JlZ3VsYXRvciwgY29uZmlnKTsKPiB9 Cj4gCj4gVW50ZXN0ZWQsIGJ1dCB0byBtZSBzaW1wbGUgYW5kIHN0cmFpZ2h0LWZvcndhcmQuCj4g Cj4gU29tZSBzdHVmZiBtYXkgYmUgbmVlZGVkIHRvIGFzc29jaWF0ZSB0aGUgcmVndWxhdG9yIHdp dGggdGhlIHJpZ2h0Cj4gZGV2aWNlIGluZGVlZCBidXQgbm90aGluZyBob3JyaWJseSBjb21wbGlj YXRlZC4KCk5hY2ssIHJlYWxseS4gV2UndmUgaGFkIGFuIGVwaWMgZGlzY3Vzc2lvbiBhdCBrcyB0 d28geWVhcnMgYWdvIGFib3V0IGhvdwphcm0gZ3B1IGRyaXZlcnMgZ28gb3ZlcmJvYXJkIHdpdGgg YWJzdHJhY3Rpb24uIFdlIGhhdmUgYWxsIHRoZSBpbnNhbml0eQp3aXRoIHBvd2VyIGRvbWFpbnMs IGNsb2NrIHRyZWVzIGFuZCB3aGF0bm9lbHNlIGluIGk5MTUua28sIGJ1dCBzaW5jZSBpdCdzCmFs bCBtb3N0bHkgZnJvbSB0aGUgc2FtZSBjb21wYW55IHdlIGhhdmUgaXQgaW50ZWdyYXRlZCBpbnRv IG9uZSBkcml2ZXIKd2l0aCBvdXIgb3duIGluZnJhc3RydWN0dXJlLiBEYXZlIEFpcmxpZSB3YXMg dGVsbGluZyB0aGlzIGV2ZXJ5b25lIGFuZCBJCmZ1bGx5IGFncmVlIHdpdGggaGltIC0gcHVzaGlu ZyBhYnN0cmFjdGlvbiBpbiB0aGUgbWlkZGxlIG9mIHRoZSBkcml2ZXIKd2l0aG91dCB0aGUgbmVl ZCBmb3IgaXQganVzdCBjYXVzZXMgdGVhcnMuCgpUaGUgcHJvYmxlbSBJIGhhdmUgaGVyZSBpcyB0 aGF0IHR3byBkaWZmZXJlbnQgcGllY2VzIG9uIHRoZSBzYW1lIGJvYXJkCmZyb20gdGhlIHNhbWUg Y29tcGFueSB3aGljaCB3b24ndCBldmVyIGdldCByZXVzZWQgYW55d2hlcmUgZWxzZSBuZWVkIHRv IGRvCmNyb3NzLWRyaXZlciBjb21tdW5pY2F0aW9uIGFib3V0IGEgZ3BpbyBsaW5lLiBJIGRvbid0 IHdhbnQgYW55IGtpbmQgb2YKYWRkaXRpb25hbCBhYnN0cmFjdGlvbiB0byBnZXQgaW50byB0aGUg d2F5IGF0IGFsbCwgdGhlIG9ubHkgdGhpbmcgSSB3YW50CmFyZToKLSBzb21lIGZ1bmN0aW9uIHRv IHN3aXRjaCB0aGF0IGxpbmUgd2l0aG91dCBkZWxheXMgb3IgY2xldmVybmVzcwogIGludGVyc3Bl cnNlZC4KLSBkeW5hbWljIGxvb2t1cC4KCkdQSU8gc2VlbWVkIGEgcGVyZmVjdCBmaXQsIGJ1dCBh cHBhcmVudGx5IGl0IGlzbid0LiBXZSdsbCByb2xsIG91ciBvd24uCgpBbmQgeWVhaCB5b3VyIGNv ZGUgaXNuJ3QgYW55IGxvbmdlciB0aGFuIHRoZSBncGlvIHZlcnNpb24sIGJ1dCByZWd1bGF0b3Jz CmRyYWcgaW4gYWxsIHRoYXQgY29uY2VwdHVhbCBzdHVmZiBhYm91dCB2b2x0YWdlL2RlbGF5cyBh bmQgZGVwZW5jaWVzIHRoYXQKaW1vIGp1c3QgaXNuJ3QgY29udHJvbGxlZCBieSB0aGUgcG1pYy4g V2UndmUgb3JpZ2luYWxseSBhYnVzZWQgdGhlIHBhbmVsCmludGVyZmFjZSBmb3IgYWxsIHRoaXMg YW5kIFRoaWVycnkgKGltbyByaWdodGZ1bGx5IHN1Z2dlc3RlZCkgdGhhdCB0aGlzCmlzbid0IGEg cGFuZWwgYnV0IGl0J2QgYmUgYmV0dGVyIHRvIGV4cG9zZSB0aGUgdW5kZXJseWluZyBzdHVmZi4g QWdhaW4gaW1vCmZha2luZyBhbGwgdGhhdCBzdHVmZiBzaW5jZSB5b3UgdGhpbmsgdGhpcyBsb29r cyBsaWtlIGEgcmVndWxhdG9yIGlzIGltbyBhCndvcnNlIGxpZSB0aGFuIHRoZSBleHBvc2luZyB0 aGlzIGFzIGEgZ3Bpby4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK