From: Christoph Hellwig Date: Wed, 8 Apr 2015 18:13:55 +0200 Subject: [Cluster-devel] [PATCH 2/2][v2] blk-plug: don't flush nested plug lists In-Reply-To: References: <1428347694-17704-1-git-send-email-jmoyer@redhat.com> <1428347694-17704-2-git-send-email-jmoyer@redhat.com> Message-ID: <20150408161355.GA16052@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit This looks good, but without the blk_finish_plug argument we're bound to grow programming mistakes where people forget it. Any chance we could have annotations similar to say rcu_read_lock/rcu_read_unlock or the spinlocks so that sparse warns about it?