From: Daniel Vetter Subject: Re: [PATCH 1/4] drm/i915: Make atomic use in-flight state for CRTC active value Date: Thu, 9 Apr 2015 16:45:04 +0200 Message-ID: <20150409144504.GQ12038@phenom.ffwll.local> References: <1428544614-28082-1-git-send-email-matthew.d.roper@intel.com> <1428544614-28082-2-git-send-email-matthew.d.roper@intel.com> <20150409124236.GI12038@phenom.ffwll.local> <20150409140031.GK11603@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 25E9C6E6F7 for ; Thu, 9 Apr 2015 07:43:07 -0700 (PDT) Received: by wizk4 with SMTP id k4so95099646wiz.1 for ; Thu, 09 Apr 2015 07:43:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150409140031.GK11603@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDksIDIwMTUgYXQgMDc6MDA6MzFBTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBUaHUsIEFwciAwOSwgMjAxNSBhdCAwMjo0MjozNlBNICswMjAwLCBEYW5pZWwgVmV0 dGVyIHdyb3RlOgo+ID4gT24gV2VkLCBBcHIgMDgsIDIwMTUgYXQgMDY6NTY6NTFQTSAtMDcwMCwg TWF0dCBSb3BlciB3cm90ZToKPiA+ID4gT3VyIGF0b21pYyBwbGFuZSBjb2RlIGN1cnJlbnRseSB1 c2VzIGludGVsX2NydGMtPmFjdGl2ZSB0byBkZXRlcm1pbmUKPiA+ID4gaG93L3doZW4gdG8gdXBk YXRlIHNvbWUgZGVyaXZlZCBzdGF0ZSB2YWx1ZXMuICBUaGlzIHdvcmtzIGZpbmUgZm9yIHB1cmUK PiA+ID4gcGxhbmUgdXBkYXRlcyBhdCB0aGUgbW9tZW50IHNpbmNlIHRoZSBDUlRDIHN0YXRlIGl0 c2VsZiBpc24ndCBjaGFuZ2VkIGFzCj4gPiA+IHBhcnQgb2YgdGhlIG9wZXJhdGlvbi4gIEhvd2V2 ZXIgYXMgd2UgY29udmVydCBtb3JlIG9mIG91ciBkcml2ZXIKPiA+ID4gaW50ZXJuYWxzIG92ZXIg dG8gYXRvbWljIG1vZGVzZXR0aW5nLCB3ZSBuZWVkIHRvIGxvb2sgYXQgd2hldGhlciB0aGUKPiA+ ID4gQ1JUQyB3aWxsIGJlIGFjdGl2ZSBhdCB0aGUgKmVuZCogb2YgdGhlIGF0b21pYyB0cmFuc2Fj dGlvbiAod2hpY2ggbWF5Cj4gPiA+IG5vdCBtYXRjaCB0aGUgY3VycmVudGx5IGNvbW1pdHRlZCBz dGF0ZSkuCj4gPiA+IAo+ID4gPiBUaGUgaW4tZmxpZ2h0IHZhbHVlIHdlIHdhbnQgdG8gdXNlIGlz IGdlbmVyYWxseSBpbiBhIGNydGNfc3RhdGUgb2JqZWN0Cj4gPiA+IGFzc29jaWF0ZWQgd2l0aCBv dXIgdG9wLWxldmVsIGF0b21pYyB0cmFuc2FjdGlvbi4gIEhvd2V2ZXIgdGhlcmUgYXJlIGEKPiA+ ID4gZmV3IGNhc2VzIHdoZXJlIHRoaXMgaXNuJ3QgdGhlIGNhc2U6Cj4gPiA+IAo+ID4gPiAgKiBX aGlsZSB1c2luZyB0cmFuc2l0aW9uYWwgYXRvbWljIGhlbHBlcnMgKGFzIHdlIGFyZSBhdCB0aGUg bW9tZW50KSwKPiA+ID4gICAgU2V0UGxhbmUoKSBjYWxscyB3aWxsIG9wZXJhdGUgb24gb3JwaGFu ZWQgcGxhbmUgc3RhdGVzIHRoYXQgYXJlbid0Cj4gPiA+ICAgIHBhcnQgb2YgYSB0b3AtbGV2ZWwg YXRvbWljIHRyYW5zYWN0aW9uLiAgSW4gdGhpcyBjYXNlLCB3ZSdyZSBub3QKPiA+ID4gICAgdG91 Y2hpbmcgdGhlIENSVEMgc3RhdGUsIHNvIGl0J3MgZmluZSB0byB1c2UgdGhlIGFscmVhZHktY29t bWl0dGVkCj4gPiA+ICAgIHZhbHVlIGZyb20gY3J0Yy0+c3RhdGUuCj4gPiA+IAo+ID4gPiAgKiBX aGlsZSB1cGRhdGluZyBwcm9wZXJ0aWVzIG9mIGEgZGlzYWJsZWQgcGxhbmUsIHdlJ2xsIGhhdmUg YSB0b3AtbGV2ZWwKPiA+ID4gICAgYXRvbWljIHN0YXRlLCBidXQgaXQgbWF5IG5vdCBjb250YWlu IHRoZSBDUlRDIHN0YXRlIHdlJ3JlIGxvb2tpbmcKPiA+ID4gICAgZm9yLiAgT25jZSBhZ2Fpbiwg dGhpcyBtZWFucyB3ZSdyZSBub3QgYWN0dWFsbHkgdG91Y2hpbmcgYW55IENSVEMKPiA+ID4gICAg c3RhdGUgc28gaXQncyBzYWZlIHRvIHVzZSB0aGUgdmFsdWUgZnJvbSBjcnRjLT5zdGF0ZSBkaXJl Y3RseS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5y b3BlckBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXRvbWljX3BsYW5lLmMgfCAxMSArKystLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jICAgICAgfCA3MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0t Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCAgICAgICAgICB8ICAzICsr Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyAgICAgICB8IDE2ICsr KysrLS0KPiA+ID4gIDQgZmlsZXMgY2hhbmdlZCwgOTMgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRp b25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYXRvbWljX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxh bmUuYwo+ID4gPiBpbmRleCA5NzZiODkxLi45MGM0YTgyIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ID4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ID4gPiBAQCAtMTExLDEyICsxMTEs MTcgQEAgc3RhdGljIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gPiA+ICB7Cj4gPiA+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0gc3RhdGUt PmNydGM7Cj4gPiA+ICAJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGM7Cj4gPiA+ICsJc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmludGVsX2NydGNfc3RhdGU7Cj4gPiA+ICAJc3RydWN0IGlu dGVsX3BsYW5lICppbnRlbF9wbGFuZSA9IHRvX2ludGVsX3BsYW5lKHBsYW5lKTsKPiA+ID4gIAlz dHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKmludGVsX3N0YXRlID0gdG9faW50ZWxfcGxhbmVfc3Rh dGUoc3RhdGUpOwo+ID4gPiArCWJvb2wgYWN0aXZlOwo+ID4gPiAgCj4gPiA+ICAJY3J0YyA9IGNy dGMgPyBjcnRjIDogcGxhbmUtPmNydGM7Cj4gPiA+ICAJaW50ZWxfY3J0YyA9IHRvX2ludGVsX2Ny dGMoY3J0Yyk7Cj4gPiA+ICAKPiA+ID4gKwlpbnRlbF9jcnRjX3N0YXRlID0gaW50ZWxfY3J0Y19z dGF0ZV9mb3JfcGxhbmUoaW50ZWxfc3RhdGUpOwo+ID4gPiArCWFjdGl2ZSA9IGludGVsX2NydGNf c3RhdGUtPmJhc2UuZW5hYmxlOwo+ID4gPiArCj4gPiA+ICAJLyoKPiA+ID4gIAkgKiBCb3RoIGNy dGMgYW5kIHBsYW5lLT5jcnRjIGNvdWxkIGJlIE5VTEwgaWYgd2UncmUgdXBkYXRpbmcgYQo+ID4g PiAgCSAqIHByb3BlcnR5IHdoaWxlIHRoZSBwbGFuZSBpcyBkaXNhYmxlZC4gIFdlIGRvbid0IGFj dHVhbGx5IGhhdmUKPiA+ID4gQEAgLTE0MywxMCArMTQ4LDggQEAgc3RhdGljIGludCBpbnRlbF9w bGFuZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPiA+ICAJLyogQ2xp cCBhbGwgcGxhbmVzIHRvIENSVEMgc2l6ZSwgb3IgMHgwIGlmIENSVEMgaXMgZGlzYWJsZWQgKi8K PiA+ID4gIAlpbnRlbF9zdGF0ZS0+Y2xpcC54MSA9IDA7Cj4gPiA+ICAJaW50ZWxfc3RhdGUtPmNs aXAueTEgPSAwOwo+ID4gPiAtCWludGVsX3N0YXRlLT5jbGlwLngyID0KPiA+ID4gLQkJaW50ZWxf Y3J0Yy0+YWN0aXZlID8gaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY193IDogMDsKPiA+ID4g LQlpbnRlbF9zdGF0ZS0+Y2xpcC55MiA9Cj4gPiA+IC0JCWludGVsX2NydGMtPmFjdGl2ZSA/IGlu dGVsX2NydGMtPmNvbmZpZy0+cGlwZV9zcmNfaCA6IDA7Cj4gPiA+ICsJaW50ZWxfc3RhdGUtPmNs aXAueDIgPSBhY3RpdmUgPyBpbnRlbF9jcnRjX3N0YXRlLT5waXBlX3NyY193IDogMDsKPiA+ID4g KwlpbnRlbF9zdGF0ZS0+Y2xpcC55MiA9IGFjdGl2ZSA/IGludGVsX2NydGNfc3RhdGUtPnBpcGVf c3JjX2ggOiAwOwo+ID4gPiAgCj4gPiA+ICAJLyoKPiA+ID4gIAkgKiBEaXNhYmxpbmcgYSBwbGFu ZSBpcyBhbHdheXMgb2theTsgd2UganVzdCBuZWVkIHRvIHVwZGF0ZQo+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+IGluZGV4IDdiZmUyYWYuLjg4YjBmNjkgMTAwNjQ0 Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4gQEAgLTEyNTYy LDYgKzEyNTYyLDUzIEBAIGludGVsX2NsZWFudXBfcGxhbmVfZmIoc3RydWN0IGRybV9wbGFuZSAq cGxhbmUsCj4gPiA+ICAJfQo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICsvKioKPiA+ID4gKyAqIGlu dGVsX2NydGNfc3RhdGVfZm9yX3BsYW5lIC0gT2J0YWluIENSVEMgc3RhdGUgZm9yIGEgcGxhbmUK PiA+ID4gKyAqIEBwc3RhdGU6IHBsYW5lIHN0YXRlIHRvIGxvb2t1cCBjb3JyZXNwb25kaW5nIGNy dGMgc3RhdGUgZm9yCj4gPiA+ICsgKgo+ID4gPiArICogV2hlbiB3b3JraW5nIHdpdGggYSB0b3At bGV2ZWwgYXRvbWljIHRyYW5zYWN0aW9uIChkcm1fYXRvbWljX3N0YXRlKSwKPiA+ID4gKyAqIGEg Q1JUQyBzdGF0ZSBzaG91bGQgYmUgcHJlc2VudCB0aGF0IGNvcnJlc3BvbmRzIHRvIHRoZSBwcm92 aWRlZAo+ID4gPiArICogcGxhbmUgc3RhdGU7IHRoaXMgZnVuY3Rpb24gcHJvdmlkZXMgYSBxdWlj ayB3YXkgdG8gZmV0Y2ggdGhhdAo+ID4gPiArICogQ1JUQyBzdGF0ZS4gIEluIGNhc2VzIHdoZXJl IHdlIGhhdmUgYSBwbGFuZSBzdGF0ZSB1bmFzc29jaWF0ZWQgd2l0aCBhbnkKPiA+ID4gKyAqIHRv cC1sZXZlbCBhdG9taWMgdHJhbnNhY3Rpb24gKGUuZy4sIHdoaWxlIHVzaW5nIHRoZSB0cmFuc2l0 aW9uYWwgYXRvbWljCj4gPiA+ICsgKiBoZWxwZXJzKSwgdGhlIGN1cnJlbnQgQ1JUQyBzdGF0ZSBm cm9tIGNydGMtPnN0YXRlIHdpbGwgYmUgcmV0dXJuZWQKPiA+ID4gKyAqIGluc3RlYWQuCj4gPiA+ ICsgKi8KPiA+ID4gK3N0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICoKPiA+ID4gK2ludGVsX2NydGNf c3RhdGVfZm9yX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcHN0YXRlKQo+ID4gPiAr ewo+ID4gPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSA9IHBzdGF0ZS0+YmFzZS5z dGF0ZTsKPiA+ID4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lID0gdG9faW50ZWxfcGxhbmUo cHN0YXRlLT5iYXNlLnBsYW5lKTsKPiA+ID4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBpbnRl bF9nZXRfY3J0Y19mb3JfcGlwZShwc3RhdGUtPmJhc2UucGxhbmUtPmRldiwKPiA+ID4gKwkJCQkJ CQlwbGFuZS0+cGlwZSk7Cj4gPiA+ICsJaW50IGk7Cj4gPiA+ICsKPiA+ID4gKwkvKgo+ID4gPiAr CSAqIFdoaWxlIHVzaW5nIHRyYW5zaXRpb25hbCBwbGFuZSBoZWxwZXJzLCB3ZSBtYXkgbm90IGhh dmUgYSB0b3AtbGV2ZWwKPiA+ID4gKwkgKiBhdG9taWMgdHJhbnNhY3Rpb24uICBPZiBjb3Vyc2Ug dGhhdCBhbHNvIG1lYW5zIHRoYXQgd2UncmUgbm90Cj4gPiA+ICsJICogYWN0dWFsbHkgdG91Y2hp bmcgQ1JUQyBzdGF0ZSwgc28ganVzdCByZXR1cm4gdGhlIGN1cnJlbnRseQo+ID4gPiArCSAqIGNv bW1pdHRlZCBzdGF0ZS4KPiA+ID4gKwkgKi8KPiA+IAo+ID4gSW1vIHRoaXMgbmVlZHMgYSBiaWcg RklYTUUgYXQgdGhlIHRvcCBvZiB0aGUgY29tbWVudCA7LSkKPiA+IAo+ID4gPiArCWlmICghc3Rh dGUpCj4gPiA+ICsJCXJldHVybiB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPnN0YXRlKTsKPiA+ ID4gKwo+ID4gPiArCWZvciAoaSA9IDA7IGkgPCBzdGF0ZS0+ZGV2LT5tb2RlX2NvbmZpZy5udW1f Y3J0YzsgaSsrKSB7Cj4gPiA+ICsJCWlmICghc3RhdGUtPmNydGNzW2ldKQo+ID4gPiArCQkJY29u dGludWU7Cj4gPiA+ICsKPiA+ID4gKwkJaWYgKHRvX2ludGVsX2NydGMoc3RhdGUtPmNydGNzW2ld KS0+cGlwZSA9PSBwbGFuZS0+cGlwZSkKPiA+ID4gKwkJCXJldHVybiB0b19pbnRlbF9jcnRjX3N0 YXRlKHN0YXRlLT5jcnRjX3N0YXRlc1tpXSk7Cj4gPiA+ICsJfQo+ID4gPiArCj4gPiA+ICsJLyoK PiA+ID4gKwkgKiBXZSBtYXkgaGF2ZSBhIHBsYW5lIHN0YXRlIHdpdGhvdXQgYSBjb3JyZXNwb25k aW5nIENSVEMgc3RhdGUgaWYKPiA+ID4gKwkgKiB3ZSdyZSB1cGRhdGluZyBhIHByb3BlcnR5IG9m IGEgZGlzYWJsZWQgcGxhbmUuICBBZ2FpbiwganVzdCB1c2luZwo+ID4gPiArCSAqIHRoZSBhbHJl YWR5LWNvbW1pdHRlZCBzdGF0ZSBmb3IgdGhpcyBwbGFuZSdzIENSVEMgc2hvdWxkIGJlIGZpbmUK PiA+ID4gKwkgKiBzaW5jZSB3ZSdyZSBub3QgYWN0dWFsbHkgdG91Y2hpbmcgdGhlIENSVEMgaGVy ZS4KPiA+ID4gKwkgKi8KPiA+IAo+ID4gSXMgdGhpcyByZWFsbHkgc3RpbGwgdHJ1ZSB3aXRoIEFu ZGVyJ3MgcGF0Y2hlcz8gSWYgdGhlIHVkcGF0ZSBpcyBwYXJ0IG9mIGEKPiA+IGRybV9hdG9taWNf c3RhdGUgc3RydWN0dXJlLCB0aGVuIHdlIHNob3VsZCBhbHdheXMgaGF2ZSB0aGUgY29ycmVzcG9u ZGluZwo+ID4gY3J0YyBzdGF0ZSBoYW5keSBJIHRoaW5rLiBXaGljaCBjYXNlcyBzdGlsbCBmYWls IHRoaXMgYXNzdW1wdGlvbj8KPiAKPiBBbnkgdGltZSBhIHRyYW5zYWN0aW9uIHVwZGF0ZXMgYSBw bGFuZSwgdGhlIGNvcnJlc3BvbmRpbmcgQ1JUQyBzdGF0ZSAoYXMKPiBkZWZpbmVkIGJ5IHBsYW5l X3N0YXRlLT5jcnRjKSBzaG91bGQgZ2V0IGFkZGVkIHRvIHRoZSB0cmFuc2FjdGlvbiBieSB0aGUK PiBhdG9taWMgY29yZSBjb2RlIChzcGVjaWZpY2FsbHkgaW4gZHJtX2F0b21pY19nZXRfcGxhbmVf c3RhdGUpLiAgQnV0IHdoZW4KPiBhIHBsYW5lIGlzIGRpc2FibGVkLCBzdGF0ZS0+Y3J0YyBpcyBO VUxMIHNvIHRoZXJlIHNpbXBseSBpcyBubwo+IGFzc29jaWF0ZWQgQ1JUQyB0byBhZGQgKGF0IGxl YXN0IGFzIGZhciBhcyB0aGUgY29yZSBpcyBjb25jZXJuZWQpLiAgU28KPiB5b3Ugd2luZCB1cCB3 aXRoIGp1c3QgYSBwbGFuZSBzdGF0ZSBiZWluZyBhZGRlZCB0byB0aGUgdG9wLWxldmVsIGF0b21p Ywo+IHN0YXRlIGluIHRoYXQgY2FzZS4KCldlIGFkZCBib3RoIHRoZSBvbGQgYW5kIHRoZSBuZXcg Y3J0YyBzdGF0ZSwgc28gd2hlbiB5b3UgZGlzYWJsZSBhIHBsYW5lCnlvdSBzaG91bGQgaGF2ZSB0 aGUgY3J0YyBzdGF0ZSBhdCBoYW5kLiBFeGNlcHQgd2hlbiBhIHBsYW5lIGlzIGFscmVhZHkKZGlz YWJsZSwgYnV0IEkgZ3Vlc3MgaW4gdGhhdCBjYXNlIHdlIHNob3VsZCBqdXN0IG5vdCBjYWxsIGFu eSBvZiB0aGUKY2FsbGJhY2tzPwotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=