From: Daniel Vetter Subject: Re: [PATCH 1/4] drm/i915: Make atomic use in-flight state for CRTC active value Date: Fri, 10 Apr 2015 09:24:59 +0200 Message-ID: <20150410072459.GW12038@phenom.ffwll.local> References: <1428544614-28082-1-git-send-email-matthew.d.roper@intel.com> <1428544614-28082-2-git-send-email-matthew.d.roper@intel.com> <20150409131856.GT17410@intel.com> <20150409141057.GL11603@intel.com> <20150409144630.GU17410@intel.com> <20150409145414.GO11603@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by gabe.freedesktop.org (Postfix) with ESMTP id 2843F6E389 for ; Fri, 10 Apr 2015 00:23:01 -0700 (PDT) Received: by widdi4 with SMTP id di4so117964269wid.0 for ; Fri, 10 Apr 2015 00:23:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150409145414.GO11603@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMDksIDIwMTUgYXQgMDc6NTQ6MTRBTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBUaHUsIEFwciAwOSwgMjAxNSBhdCAwNTo0NjozMFBNICswMzAwLCBWaWxsZSBTeXJq w6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUaHUsIEFwciAwOSwgMjAxNSBhdCAwNzoxMDo1N0FNIC0wNzAw LCBNYXR0IFJvcGVyIHdyb3RlOgo+ID4gPiBPbiBUaHUsIEFwciAwOSwgMjAxNSBhdCAwNDoxODo1 NlBNICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+ID4gT24gV2VkLCBBcHIgMDgs IDIwMTUgYXQgMDY6NTY6NTFQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90ZToKPiA+ID4gPiA+IE91 ciBhdG9taWMgcGxhbmUgY29kZSBjdXJyZW50bHkgdXNlcyBpbnRlbF9jcnRjLT5hY3RpdmUgdG8g ZGV0ZXJtaW5lCj4gPiA+ID4gPiBob3cvd2hlbiB0byB1cGRhdGUgc29tZSBkZXJpdmVkIHN0YXRl IHZhbHVlcy4gIFRoaXMgd29ya3MgZmluZSBmb3IgcHVyZQo+ID4gPiA+ID4gcGxhbmUgdXBkYXRl cyBhdCB0aGUgbW9tZW50IHNpbmNlIHRoZSBDUlRDIHN0YXRlIGl0c2VsZiBpc24ndCBjaGFuZ2Vk IGFzCj4gPiA+ID4gPiBwYXJ0IG9mIHRoZSBvcGVyYXRpb24uICBIb3dldmVyIGFzIHdlIGNvbnZl cnQgbW9yZSBvZiBvdXIgZHJpdmVyCj4gPiA+ID4gPiBpbnRlcm5hbHMgb3ZlciB0byBhdG9taWMg bW9kZXNldHRpbmcsIHdlIG5lZWQgdG8gbG9vayBhdCB3aGV0aGVyIHRoZQo+ID4gPiA+ID4gQ1JU QyB3aWxsIGJlIGFjdGl2ZSBhdCB0aGUgKmVuZCogb2YgdGhlIGF0b21pYyB0cmFuc2FjdGlvbiAo d2hpY2ggbWF5Cj4gPiA+ID4gPiBub3QgbWF0Y2ggdGhlIGN1cnJlbnRseSBjb21taXR0ZWQgc3Rh dGUpLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBUaGUgaW4tZmxpZ2h0IHZhbHVlIHdlIHdhbnQgdG8g dXNlIGlzIGdlbmVyYWxseSBpbiBhIGNydGNfc3RhdGUgb2JqZWN0Cj4gPiA+ID4gPiBhc3NvY2lh dGVkIHdpdGggb3VyIHRvcC1sZXZlbCBhdG9taWMgdHJhbnNhY3Rpb24uICBIb3dldmVyIHRoZXJl IGFyZSBhCj4gPiA+ID4gPiBmZXcgY2FzZXMgd2hlcmUgdGhpcyBpc24ndCB0aGUgY2FzZToKPiA+ ID4gPiA+IAo+ID4gPiA+ID4gICogV2hpbGUgdXNpbmcgdHJhbnNpdGlvbmFsIGF0b21pYyBoZWxw ZXJzIChhcyB3ZSBhcmUgYXQgdGhlIG1vbWVudCksCj4gPiA+ID4gPiAgICBTZXRQbGFuZSgpIGNh bGxzIHdpbGwgb3BlcmF0ZSBvbiBvcnBoYW5lZCBwbGFuZSBzdGF0ZXMgdGhhdCBhcmVuJ3QKPiA+ ID4gPiA+ICAgIHBhcnQgb2YgYSB0b3AtbGV2ZWwgYXRvbWljIHRyYW5zYWN0aW9uLiAgSW4gdGhp cyBjYXNlLCB3ZSdyZSBub3QKPiA+ID4gPiA+ICAgIHRvdWNoaW5nIHRoZSBDUlRDIHN0YXRlLCBz byBpdCdzIGZpbmUgdG8gdXNlIHRoZSBhbHJlYWR5LWNvbW1pdHRlZAo+ID4gPiA+ID4gICAgdmFs dWUgZnJvbSBjcnRjLT5zdGF0ZS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gICogV2hpbGUgdXBkYXRp bmcgcHJvcGVydGllcyBvZiBhIGRpc2FibGVkIHBsYW5lLCB3ZSdsbCBoYXZlIGEgdG9wLWxldmVs Cj4gPiA+ID4gPiAgICBhdG9taWMgc3RhdGUsIGJ1dCBpdCBtYXkgbm90IGNvbnRhaW4gdGhlIENS VEMgc3RhdGUgd2UncmUgbG9va2luZwo+ID4gPiA+ID4gICAgZm9yLiAgT25jZSBhZ2FpbiwgdGhp cyBtZWFucyB3ZSdyZSBub3QgYWN0dWFsbHkgdG91Y2hpbmcgYW55IENSVEMKPiA+ID4gPiA+ICAg IHN0YXRlIHNvIGl0J3Mgc2FmZSB0byB1c2UgdGhlIHZhbHVlIGZyb20gY3J0Yy0+c3RhdGUgZGly ZWN0bHkuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1h dHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYyB8IDExICsrKy0tCj4gPiA+ID4gPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jICAgICAgfCA3MyArKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tCj4gPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmggICAgICAgICAgfCAgMyArKwo+ID4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3Nwcml0ZS5jICAgICAgIHwgMTYgKysrKystLQo+ID4gPiA+ID4gIDQgZmlsZXMgY2hh bmdlZCwgOTMgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiAKPiA+ID4g PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiA+ID4gPiBp bmRleCA5NzZiODkxLi45MGM0YTgyIDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMKPiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiA+ID4gPiBAQCAtMTExLDEyICsxMTEs MTcgQEAgc3RhdGljIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gPiA+ID4gPiAgewo+ID4gPiA+ID4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGMg PSBzdGF0ZS0+Y3J0YzsKPiA+ID4gPiA+ICAJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGM7 Cj4gPiA+ID4gPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICppbnRlbF9jcnRjX3N0YXRlOwo+ ID4gPiA+ID4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmUgKmludGVsX3BsYW5lID0gdG9faW50ZWxfcGxh bmUocGxhbmUpOwo+ID4gPiA+ID4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKmludGVsX3N0 YXRlID0gdG9faW50ZWxfcGxhbmVfc3RhdGUoc3RhdGUpOwo+ID4gPiA+ID4gKwlib29sIGFjdGl2 ZTsKPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICAJY3J0YyA9IGNydGMgPyBjcnRjIDogcGxhbmUtPmNy dGM7Cj4gPiA+ID4gPiAgCWludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+ID4gPiA+ ID4gIAo+ID4gPiA+ID4gKwlpbnRlbF9jcnRjX3N0YXRlID0gaW50ZWxfY3J0Y19zdGF0ZV9mb3Jf cGxhbmUoaW50ZWxfc3RhdGUpOwo+ID4gPiA+ID4gKwlhY3RpdmUgPSBpbnRlbF9jcnRjX3N0YXRl LT5iYXNlLmVuYWJsZTsKPiA+ID4gPiA+ICsKPiA+ID4gPiA+ICAJLyoKPiA+ID4gPiA+ICAJICog Qm90aCBjcnRjIGFuZCBwbGFuZS0+Y3J0YyBjb3VsZCBiZSBOVUxMIGlmIHdlJ3JlIHVwZGF0aW5n IGEKPiA+ID4gPiA+ICAJICogcHJvcGVydHkgd2hpbGUgdGhlIHBsYW5lIGlzIGRpc2FibGVkLiAg V2UgZG9uJ3QgYWN0dWFsbHkgaGF2ZQo+ID4gPiA+ID4gQEAgLTE0MywxMCArMTQ4LDggQEAgc3Rh dGljIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUs Cj4gPiA+ID4gPiAgCS8qIENsaXAgYWxsIHBsYW5lcyB0byBDUlRDIHNpemUsIG9yIDB4MCBpZiBD UlRDIGlzIGRpc2FibGVkICovCj4gPiA+ID4gPiAgCWludGVsX3N0YXRlLT5jbGlwLngxID0gMDsK PiA+ID4gPiA+ICAJaW50ZWxfc3RhdGUtPmNsaXAueTEgPSAwOwo+ID4gPiA+ID4gLQlpbnRlbF9z dGF0ZS0+Y2xpcC54MiA9Cj4gPiA+ID4gPiAtCQlpbnRlbF9jcnRjLT5hY3RpdmUgPyBpbnRlbF9j cnRjLT5jb25maWctPnBpcGVfc3JjX3cgOiAwOwo+ID4gPiA+ID4gLQlpbnRlbF9zdGF0ZS0+Y2xp cC55MiA9Cj4gPiA+ID4gPiAtCQlpbnRlbF9jcnRjLT5hY3RpdmUgPyBpbnRlbF9jcnRjLT5jb25m aWctPnBpcGVfc3JjX2ggOiAwOwo+ID4gPiA+ID4gKwlpbnRlbF9zdGF0ZS0+Y2xpcC54MiA9IGFj dGl2ZSA/IGludGVsX2NydGNfc3RhdGUtPnBpcGVfc3JjX3cgOiAwOwo+ID4gPiA+ID4gKwlpbnRl bF9zdGF0ZS0+Y2xpcC55MiA9IGFjdGl2ZSA/IGludGVsX2NydGNfc3RhdGUtPnBpcGVfc3JjX2gg OiAwOwo+ID4gPiA+IAo+ID4gPiA+IFdlIGRlcGVuZCBvbiB0aGUgY2xpcHBpbmcgdG8ga2VlcCBw bGFuZXMgZnJvbSBnZXR0aW5nIGVuYWJsZWQgb24gYQo+ID4gPiA+IGRpc2FibGVkIHBpcGUuIFNv IEkgdGhpbmsgdGhpcyBpcyBnb2luZyB0byBibG93IHVwLgo+ID4gPiAKPiA+ID4gVGhhdCB3YXMg d2h5IEkgbWFkZSB0aGVzZSBjaGFuZ2VzLi4udGhlIGlkZWEgaGVyZSB3YXMgdGhhdCB3ZSBzaG91 bGQgYmUKPiA+ID4gYmFzaW5nIHRoYXQgY2xpcHBpbmcgb24gd2hhdCB0aGUgQ1JUQyBzdGF0ZSBp cyBnb2luZyB0byBiZSB3aGVuIHRoZQo+ID4gPiBwbGFuZSBzdGF0ZSBpcyBhY3R1YWxseSBjb21t aXR0ZWQsIG5vdCB3aGF0IGl0IGhhcHBlbnMgdG8gYmUgbm93LiAgU28gaWYKPiA+ID4gdGhlIENS VEMgaXMgZ29pbmcgdG8gYmUgZGlzYWJsZWQsIHRoaXMgc2hvdWxkIGVuc3VyZSB0aGF0IHRoZSBw bGFuZXMgYXJlCj4gPiA+IHByb3Blcmx5IGNsaXBwZWQgdG8gb2ZmLCBldmVuIGlmIHRoZSBDUlRD IGhhcHBlbnMgdG8gYmUgcnVubmluZyBhdCB0aGUKPiA+ID4gbW9tZW50LiAgQ29udmVyc2VseSwg aWYgdGhlIENSVEMgaXMgb2ZmIGF0IHRoZSBtb21lbnQsIGJ1dCB3aWxsIGJlIG9uIGF0Cj4gPiA+ IHRoZSBlbmQgb2YgdGhpcyB0cmFuc2FjdGlvbiwgd2Ugd2FudCB0byBtYWtlIHN1cmUgdGhhdCB0 aGUgcGxhbmVzIGFyZQo+ID4gPiBub3QgaW1wcm9wZXJseSBjbGlwcGVkIHRvIGludmlzaWJsZSwg b3RoZXJ3aXNlIHRoZXkgd29uJ3Qgc2hvdyB1cC4KPiA+IAo+ID4gV2VsbCB5ZWFoLCB3ZSB3YW50 IHRvIGNoYW5nZSB0aGUgY2xpcHBpbmcgY29tcHV0YXRpb24gdG8gdXNlIHRoZSBmdXR1cmUKPiA+ IHN0YXRlIGJ1dCBJIGRvbid0IHRoaW5rIHdlcmUgcmVhZHkgZm9yIGl0IHlldC4gQXQgbGVhc3Qg SSB3b3VsZG4ndCB3YW50Cj4gPiB0byBtYWtlIHRoaXMgY2hhbmdlIHVudGlsIHRoZSB3YXRlcm1h cmsgY29kZSBnZXRzIGZpeGVkIGFuZCB3ZSBjbGVhbiB1cAo+ID4gdGhlIHByaW1hcnkvY3Vyc29y IHBsYW5lIHN0YXRlIGhhbmRsaW5nLgo+ID4gCj4gPiBGb3IgaW5zdGFuY2Ugd2hhdCBoYXBwZW5z IGlmIHlvdSBkcG1zIG9mZiBhbmQgdGhlbiBlbmFibGUgYSBwbGFuZT8gSWYKPiA+IHRoZSBjbGlw cGluZyBpcyBiYXNlZCBvbiB0aGUgZW5hYmxlZCBzdGF0ZSBvZiB0aGUgY3J0YyB0aGVuIGl0J2xs IHRyeQo+ID4gdG8gZW5hYmxlIHRoZSBwbGFuZSwgbm8/Cj4gCj4gWWVhaCwgSSB0aGluayB0aGF0 IHdhcyBEYW5pZWwncyBjb25jZXJuIHRvby4uLiAtPmVuYWJsZSBpcyB0aGUgd3JvbmcKPiBmaWVs ZCB0byBiZSBwdWxsaW5nIG91dCBvZiB0aGUgc3RhdGUgb2JqZWN0IGhlcmUgYW5kIHdlIHNob3Vs ZCBiZSB1c2luZwo+IC0+YWN0aXZlIGluc3RlYWQgc2luY2UgdGhhdCB0YWtlcyBEUE1TIGFuZCBz dWNoIGludG8gYWNjb3VudC4KPiAKPiBJJ20gbm90IHN1cmUgaWYgLT5hY3RpdmUgaXMgcHJvcGVy bHkgdXBkYXRlZCBpbiBvdXIgQ1JUQyBzdGF0ZSB0b2RheSBieQo+IHRoZSBsZWdhY3kgbW9kZXNl dHRpbmcgY29kZXBhdGhzLCBidXQgaWYgd2UgY2FuIGdldCB0aGF0IHNxdWFyZWQgYXdheQo+IGFu ZCBzd2l0Y2ggdG8gdXNpbmcgY3J0Y19zdGF0ZS0+YWN0aXZlIHJhdGhlciB0aGFuIGNydGNfc3Rh dGUtPmVuYWJsZSBkbwo+IHlvdSBmb3JzZWUgYW55IG90aGVyIGlzc3VlcyB3aXRoIHB1bGxpbmcg dGhlIHZhbHVlIG91dCBvZiB0aGUgaW4tZmxpZ2h0Cj4gc3RhdGUgbGlrZSB0aGlzIHBhdGNoIHRy aWVzIHRvIGRvPwoKT24gcmVjb25zaWRlcmF0aW9uIC0+ZW5hYmxlIGlzIGltbyB0aGUgcmlnaHQg ZmllbGQgd2Ugc2hvdWxkIHVzZSBmb3Igd20KY29tcHV0YXRpb24gYW5kIGV2ZXJ5dGhpbmcuIE90 aGVyd2lzZSByZXNvdXJjZSBjb25zdHJhaW50IGNoZWNraW5nIHdpbGwgYmUKZmFpbCBhbmQgYSBk cG1zIG9uIG1pZ2h0IG5vdCB3b3JrLCBhbmQgdGhhdCdzIG5vdCBnb29kLgoKT2ZjIHdlIGNhbid0 IGp1c3QgdHJ5IHRvIGVuYWJsZSBwbGFuZXMgd2hlbiB0aGUgY3J0YyBpcyBvZmYsIGJ1dCBpbW8g dGhhdApuZWVkcyB0byBiZSBmaXhlZCBkaWZmZXJlbnRseS4gUm91Z2ggcGxhbiAod2hpY2ggaXMg d2hhdCBNYWFydGVuJ3Mgd29ya2luZwpvbikuCi0gVW5jb25kaXRpb25hbGx5IHNodXQgZG93biBw bGFuZXMgaW4gY3J0Y19kaXNhYmxlLCBieXBhc3NpbmcgYW55IHN0YXRlCiAgY2hhbmdlcy4gTWFh cnRlbiBpcyB3b3JraW5nIG9uIHNvbWUgZm9yY2UgcGxhbmUgZGlzYWJsZSBwYXRjaGVzIHRvCiAg b3ZlcndyaXRlIHRoZSAtPnZpc2libGUgY2hlY2tzLgotIFdoZW4gYSBjcnRjIGlzIGluIHRoZSBk aXNhYmxlX3BpcGVzIG9yIG1vZGVzZXRfcGlwZXMgc2V0cyBhZGQgYWxsIHRoZQogIHBsYW5lIHN0 YXRlcyB0byB0aGUgYXRvbWljIHVwZGF0ZSAoaW4gdGhlIGNydGMgY29tcHV0ZV9jb25maWcgZnVu Y3Rpb25zCiAgd2l0aCBhIGhhY2sgZm9yIGRpc2FibGVkIHBpcGVzIHVudGlsIHdlIGdldCB0aGF0 IG9uZSByaWdodCkuIEFsc28gY2FsbAogIHBsYW5lIGF0b21pY19jaGVjayBmdW5jdGlvbnMgZm9y IGFsbCBwbGFuZXMgaW4gdGhlIHN0YXRlIHVwZGF0ZS4KLSBSZW1vdmUgdGhlIHBsYW5lIGVuYWJs ZSBjb2RlIGZyb20gY3J0Y19lbmFibGUgYW5kIGluc3RlYWQganVzdCBkbyBhbgogIGF0b21pYyBw bGFuZSB1cGRhdGUgKGFzIHdlIGFscmVhZHkgaGF2ZSBmcm9tIE1hdHQncyBhdG9taWMgd29yaykg YXQgdGhlCiAgdmVyeSBlbmQgb2YgdGhlIG1vZGVzZXQgc2VxdWVuY2UsIGJ1dCBfb25seV8gd2hl biBhIGNydGMgaXMgYWN0aXZlLgoKVGhpcyB3YXkgd2Ugc2hvdWxkbid0IGhhdmUgYW55IGlzc3Vl IHdpdGggY2hlY2tpbmcgc3RhdGUgYW5kIC0+YWN0aXZlIGlzCm9ubHkgZ2F0aW5nIHdoYXQgaHcg d2UgZW5hYmxlLgoKV2hhdCB3ZSBtaWdodCB3YW50IHRvIGNoYW5nZSBpcyBwaW1wIHRoZSBzaGFy ZWQgYXRvbWljIGhlbHBlcnMgdG8gbm90IGNhbGwKYW55IGF0b21pY19jaGVjayBmdW5jdGlvbnMg Zm9yIHBsYW5lcy9jcnRjcyBpZiB0aGUgY3J0YyBpcyBub3QgZW5hYmxlZC4gSQp0aGluayB0aGF0 IHNob3VsZCBmdW5jdGlvbmFsbHkgc3Vic3RpdHV0ZSB0aGlzIHBhdGNoIGhlcmUuCi1EYW5pZWwK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==