From: Daniel Vetter Subject: Re: [PATCH 11/11] drm/i915: Don't modeset with old mode when set_crtc fails Date: Fri, 10 Apr 2015 12:12:14 +0200 Message-ID: <20150410101214.GJ6092@phenom.ffwll.local> References: <1428655120-22494-1-git-send-email-ander.conselvan.de.oliveira@intel.com> <1428655120-22494-12-git-send-email-ander.conselvan.de.oliveira@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by gabe.freedesktop.org (Postfix) with ESMTP id ABFED6E90C for ; Fri, 10 Apr 2015 03:10:17 -0700 (PDT) Received: by widdi4 with SMTP id di4so122481342wid.0 for ; Fri, 10 Apr 2015 03:10:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1428655120-22494-12-git-send-email-ander.conselvan.de.oliveira@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan de Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBcHIgMTAsIDIwMTUgYXQgMTE6Mzg6NDBBTSArMDMwMCwgQW5kZXIgQ29uc2VsdmFu IGRlIE9saXZlaXJhIHdyb3RlOgo+IFRoZSBtb2Rlc2V0IGNvZGUgaXMgbm93IHByb3Blcmx5IGRp dmlkZWQgaW4gdHdvIHBoYXNlcywgc28gdGhhdCBpdCBvbmx5Cj4gY2hhbmdlcyBoYXJkd2FyZSBz dGF0ZSBpZiBpdCBzdWNjZWVkcywgc28gdGhlcmUncyBubyBpbGwtZWZmZWN0IHRoYXQKPiBuZWVk cyB0byBiZSB1bmRvbmUgb24gZmFpbHVyZSBhbnltb3JlLgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0OCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAwNmYzYjgzLi44NGVmZDdhIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMjEzNiwzMyArMTIxMzYsOSBA QCBpbnRlbF9tb2Rlc2V0X3N0YWdlX291dHB1dF9zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGRpc2FibGVfY3J0Y19ub2Zi KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY3J0Yy0+YmFzZS5kZXY7Cj4gLQlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcjsKPiAt CXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiAtCj4gLQlEUk1fREVCVUdfS01T KCJUcnlpbmcgdG8gcmVzdG9yZSB3aXRob3V0IEZCIC0+IGRpc2FibGluZyBwaXBlICVjXG4iLAo+ IC0JCSAgICAgIHBpcGVfbmFtZShjcnRjLT5waXBlKSk7Cj4gLQo+IC0JZm9yX2VhY2hfaW50ZWxf Y29ubmVjdG9yKGRldiwgY29ubmVjdG9yKSB7Cj4gLQkJaWYgKGNvbm5lY3Rvci0+bmV3X2VuY29k ZXIgJiYKPiAtCQkgICAgY29ubmVjdG9yLT5uZXdfZW5jb2Rlci0+bmV3X2NydGMgPT0gY3J0YykK PiAtCQkJY29ubmVjdG9yLT5uZXdfZW5jb2RlciA9IE5VTEw7Cj4gLQl9Cj4gLQo+IC0JZm9yX2Vh Y2hfaW50ZWxfZW5jb2RlcihkZXYsIGVuY29kZXIpIHsKPiAtCQlpZiAoZW5jb2Rlci0+bmV3X2Ny dGMgPT0gY3J0YykKPiAtCQkJZW5jb2Rlci0+bmV3X2NydGMgPSBOVUxMOwo+IC0JfQo+IC0KPiAt CWNydGMtPm5ld19lbmFibGVkID0gZmFsc2U7Cj4gLX0KPiAtCj4gIHN0YXRpYyBpbnQgaW50ZWxf Y3J0Y19zZXRfY29uZmlnKHN0cnVjdCBkcm1fbW9kZV9zZXQgKnNldCkKPiAgewo+ICAJc3RydWN0 IGRybV9kZXZpY2UgKmRldjsKPiAtCXN0cnVjdCBkcm1fbW9kZV9zZXQgc2F2ZV9zZXQ7Cj4gIAlz dHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUgPSBOVUxMOwo+ICAJc3RydWN0IGludGVsX3Nl dF9jb25maWcgKmNvbmZpZzsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZp ZzsKPiBAQCAtMTIxOTUsMTIgKzEyMTcxLDYgQEAgc3RhdGljIGludCBpbnRlbF9jcnRjX3NldF9j b25maWcoc3RydWN0IGRybV9tb2RlX3NldCAqc2V0KQo+ICAJaWYgKHJldCkKPiAgCQlnb3RvIG91 dF9jb25maWc7Cj4gIAo+IC0Jc2F2ZV9zZXQuY3J0YyA9IHNldC0+Y3J0YzsKPiAtCXNhdmVfc2V0 Lm1vZGUgPSAmc2V0LT5jcnRjLT5tb2RlOwo+IC0Jc2F2ZV9zZXQueCA9IHNldC0+Y3J0Yy0+eDsK PiAtCXNhdmVfc2V0LnkgPSBzZXQtPmNydGMtPnk7Cj4gLQlzYXZlX3NldC5mYiA9IHNldC0+Y3J0 Yy0+cHJpbWFyeS0+ZmI7Cj4gLQo+ICAJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGRl dik7Cj4gIAlpZiAoIXN0YXRlKSB7Cj4gIAkJcmV0ID0gLUVOT01FTTsKPiBAQCAtMTIyODAsMjQg KzEyMjUwLDYgQEAgc3RhdGljIGludCBpbnRlbF9jcnRjX3NldF9jb25maWcoc3RydWN0IGRybV9t b2RlX3NldCAqc2V0KQo+ICAJCQkgICAgICBzZXQtPmNydGMtPmJhc2UuaWQsIHJldCk7Cj4gIGZh aWw6Cj4gIAkJaW50ZWxfc2V0X2NvbmZpZ19yZXN0b3JlX3N0YXRlKGRldiwgY29uZmlnKTsKPiAt Cj4gLQkJZHJtX2F0b21pY19zdGF0ZV9jbGVhcihzdGF0ZSk7Cj4gLQo+IC0JCS8qCj4gLQkJICog SEFDSzogaWYgdGhlIHBpcGUgd2FzIG9uLCBidXQgd2UgZGlkbid0IGhhdmUgYSBmcmFtZWJ1ZmZl ciwKPiAtCQkgKiBmb3JjZSB0aGUgcGlwZSBvZmYgdG8gYXZvaWQgb29wc2luZyBpbiB0aGUgbW9k ZXNldCBjb2RlCj4gLQkJICogZHVlIHRvIGZiPT1OVUxMLiBUaGlzIHNob3VsZCBvbmx5IGhhcHBl biBkdXJpbmcgYm9vdCBzaW5jZQo+IC0JCSAqIHdlIGRvbid0IHlldCByZWNvbnN0cnVjdCB0aGUg RkIgZnJvbSB0aGUgaGFyZHdhcmUgc3RhdGUuCj4gLQkJICovCj4gLQkJaWYgKHRvX2ludGVsX2Ny dGMoc2F2ZV9zZXQuY3J0YyktPm5ld19lbmFibGVkICYmICFzYXZlX3NldC5mYikKPiAtCQkJZGlz YWJsZV9jcnRjX25vZmIodG9faW50ZWxfY3J0YyhzYXZlX3NldC5jcnRjKSk7Cj4gLQo+IC0JCS8q IFRyeSB0byByZXN0b3JlIHRoZSBjb25maWcgKi8KPiAtCQlpZiAoY29uZmlnLT5tb2RlX2NoYW5n ZWQgJiYKPiAtCQkgICAgaW50ZWxfc2V0X21vZGUoc2F2ZV9zZXQuY3J0Yywgc2F2ZV9zZXQubW9k ZSwKPiAtCQkJCSAgIHNhdmVfc2V0LngsIHNhdmVfc2V0LnksIHNhdmVfc2V0LmZiLAo+IC0JCQkJ ICAgc3RhdGUpKQo+IC0JCQlEUk1fRVJST1IoImZhaWxlZCB0byByZXN0b3JlIGNvbmZpZyBhZnRl ciBtb2Rlc2V0IGZhaWx1cmVcbiIpOwoKSG0gcmVtb3ZpbmcgdGhpcyByZW1pbmRzIG1lIHRoYXQg d2Ugc3RpbGwgaGF2ZSB0cm91YmxlcyB3aXRoIGFsd2F5cwphc3N1bWluZyB0aGF0IHRoZXJlIGlz IGEgcHJpbWFyeSBmYiBhcm91bmQuIEdldHRpbmcgcmlkIG9mIGFsbCB0aGUgZmIKcG9pbnRlcnMg aW4gb3VyIG1vZGVzZXQgY29kZSBsb29rcyBsaWtlIGEgc2l6ZWFibGUgdGFzayB0b28uCi1EYW5p ZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==