From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Remove wait for for punit to updates freq. Date: Mon, 4 May 2015 09:59:37 +0200 Message-ID: <20150504075937.GI30184@phenom.ffwll.local> References: <1425528503-7760-1-git-send-email-deepak.s@linux.intel.com> <553FCE7D.6090806@virtuousgeek.org> <20150428183243.GP18908@intel.com> <554046EC.5090602@linux.intel.com> <20150429102630.GR18908@intel.com> <5541FE30.7030003@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTP id CEB196E368 for ; Mon, 4 May 2015 00:57:17 -0700 (PDT) Received: by wicmx19 with SMTP id mx19so71514677wic.1 for ; Mon, 04 May 2015 00:57:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5541FE30.7030003@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Deepak S Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMzAsIDIwMTUgYXQgMDM6MzQ6MzJQTSArMDUzMCwgRGVlcGFrIFMgd3JvdGU6 Cj4gCj4gCj4gT24gV2VkbmVzZGF5IDI5IEFwcmlsIDIwMTUgMDM6NTYgUE0sIFZpbGxlIFN5cmrD pGzDpCB3cm90ZToKPiA+T24gV2VkLCBBcHIgMjksIDIwMTUgYXQgMDg6MjA6MjBBTSArMDUzMCwg RGVlcGFrIFMgd3JvdGU6Cj4gPj4KPiA+Pk9uIFdlZG5lc2RheSAyOSBBcHJpbCAyMDE1IDEyOjAy IEFNLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPj4+T24gVHVlLCBBcHIgMjgsIDIwMTUgYXQg MTE6MTY6MjlBTSAtMDcwMCwgSmVzc2UgQmFybmVzIHdyb3RlOgo+ID4+Pj5PbiAwMy8wNC8yMDE1 IDA4OjA4IFBNLCBkZWVwYWsuc0BsaW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gPj4+Pj5Gcm9tOiBE ZWVwYWsgUyA8ZGVlcGFrLnNAbGludXguaW50ZWwuY29tPgo+ID4+Pj4+Cj4gPj4+Pj5XaGVuIEdQ VSBpcyBpZGxlIG9uIFZMViwgUmVxdWVzdCBmcmVxIHRvIHB1bml0IHNob3VsZCBiZSBnb29kIGVu b3VnaCB0bwo+ID4+Pj4+Z2V0IHRoZSB2b2x0YWdlIGJhY2sgdG8gVk5OLiBBbHNvLCBtYWtlIHN1 cmUgZ2Z4IGNsb2NrIGZvcmNlIGFwcGxpZXMKPiA+Pj4+PmJlZm9yZSByZXF1ZXN0aW5nIHRoZSBm cmVxIGZvdCB2bHYuCj4gPj4+Pj4KPiA+Pj4+PkJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRl c2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD03NTI0NAo+ID4+Pj4+c3VnZ2VzdGVkLWJ5OiBKZXNz ZSBCYXJuZXMgPGpiYXJuZXNAdmlydHVvdXNnZWVrLm9yZz4KPiA+Pj4+PlNpZ25lZC1vZmYtYnk6 IERlZXBhayBTIDxkZWVwYWsuc0BsaW51eC5pbnRlbC5jb20+Cj4gPj4+Pj4tLS0KPiA+Pj4+PiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyMCArKysrLS0tLS0tLS0tLS0tLS0t LQo+ID4+Pj4+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25z KC0pCj4gPj4+Pj4KPiA+Pj4+PmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4+Pj4+aW5kZXggZTcx MGI0My4uMmUxZWQwNyAxMDA2NDQKPiA+Pj4+Pi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3BtLmMKPiA+Pj4+PisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ Pj4+PkBAIC0zODk0LDcgKzM4OTQsNyBAQCBzdGF0aWMgdm9pZCB2YWxsZXl2aWV3X3NldF9ycHMo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgdTggdmFsKQo+ID4+Pj4+ICAgICogKiBJZiBHZnggaXMg SWRsZSwgdGhlbgo+ID4+Pj4+ICAgICogMS4gTWFzayBUdXJibyBpbnRlcnJ1cHRzCj4gPj4+Pj4g ICAgKiAyLiBCcmluZyB1cCBHZnggY2xvY2sKPiA+Pj4+Pi0gKiAzLiBDaGFuZ2UgdGhlIGZyZXEg dG8gUnBuIGFuZCB3YWl0IHRpbGwgUC1Vbml0IHVwZGF0ZXMgZnJlcQo+ID4+Pj4+KyAqIDMuIFJl cXVlc3QgdGhlIGZyZXEgdG8gUnBuLgo+ID4+Pj4+ICAgICogNC4gQ2xlYXIgdGhlIEZvcmNlIEdG WCBDTEsgT04gYml0IHNvIHRoYXQgR2Z4IGNhbiBkb3duCj4gPj4+Pj4gICAgKiA1LiBVbm1hc2sg VHVyYm8gaW50ZXJydXB0cwo+ID4+Pj4+ICAgKi8KPiA+Pj4+PkBAIC0zOTAyLDggKzM5MDIsOCBA QCBzdGF0aWMgdm9pZCB2bHZfc2V0X3Jwc19pZGxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiA+Pj4+PiAgIHsKPiA+Pj4+PiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0g ZGV2X3ByaXYtPmRldjsKPiA+Pj4+Pi0JLyogQ0hWIGFuZCBsYXRlc3QgVkxWIGRvbid0IG5lZWQg dG8gZm9yY2UgdGhlIGdmeCBjbG9jayAqLwo+ID4+Pj4+LQlpZiAoSVNfQ0hFUlJZVklFVyhkZXYp IHx8IGRldi0+cGRldi0+cmV2aXNpb24gPj0gMHhkKSB7Cj4gPj4+Pj4rCS8qIENIViBkb24ndCBu ZWVkIHRvIGZvcmNlIHRoZSBnZnggY2xvY2sgKi8KPiA+Pj4+PisJaWYgKElTX0NIRVJSWVZJRVco ZGV2KSkgewo+ID4+Pj4+ICAgCQl2YWxsZXl2aWV3X3NldF9ycHMoZGV2X3ByaXYtPmRldiwgZGV2 X3ByaXYtPnJwcy5taW5fZnJlcV9zb2Z0bGltaXQpOwo+ID4+Pj4+ICAgCQlyZXR1cm47Cj4gPj4+ Pj4gICAJfQo+ID4+Pj4+QEAgLTM5MjAsMjAgKzM5MjAsOCBAQCBzdGF0aWMgdm9pZCB2bHZfc2V0 X3Jwc19pZGxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+Pj4+PiAgIAkJ ICAgZ2VuNl9zYW5pdGl6ZV9ycHNfcG1fbWFzayhkZXZfcHJpdiwgfjApKTsKPiA+Pj4+PiAgIAl2 bHZfZm9yY2VfZ2Z4X2Nsb2NrKGRldl9wcml2LCB0cnVlKTsKPiA+Pj4+Pi0KPiA+Pj4+Pi0JZGV2 X3ByaXYtPnJwcy5jdXJfZnJlcSA9IGRldl9wcml2LT5ycHMubWluX2ZyZXFfc29mdGxpbWl0Owo+ ID4+Pj4+LQo+ID4+Pj4+LQl2bHZfcHVuaXRfd3JpdGUoZGV2X3ByaXYsIFBVTklUX1JFR19HUFVf RlJFUV9SRVEsCj4gPj4+Pj4tCQkJCQlkZXZfcHJpdi0+cnBzLm1pbl9mcmVxX3NvZnRsaW1pdCk7 Cj4gPj4+Pj4tCj4gPj4+Pj4tCWlmICh3YWl0X2ZvcigoKHZsdl9wdW5pdF9yZWFkKGRldl9wcml2 LCBQVU5JVF9SRUdfR1BVX0ZSRVFfU1RTKSkKPiA+Pj4+Pi0JCQkJJiBHRU5GUkVRU1RBVFVTKSA9 PSAwLCAxMDApKQo+ID4+Pj4+LQkJRFJNX0VSUk9SKCJ0aW1lZCBvdXQgd2FpdGluZyBmb3IgUHVu aXRcbiIpOwo+ID4+Pj4+LQo+ID4+Pj4+Kwl2YWxsZXl2aWV3X3NldF9ycHMoZGV2X3ByaXYtPmRl diwgZGV2X3ByaXYtPnJwcy5taW5fZnJlcV9zb2Z0bGltaXQpOwo+ID4+Pj4+ICAgCXZsdl9mb3Jj ZV9nZnhfY2xvY2soZGV2X3ByaXYsIGZhbHNlKTsKPiA+Pj4+Pi0KPiA+Pj4+Pi0JSTkxNV9XUklU RShHRU42X1BNSU5UUk1TSywKPiA+Pj4+Pi0JCSAgIGdlbjZfcnBzX3BtX21hc2soZGV2X3ByaXYs IGRldl9wcml2LT5ycHMuY3VyX2ZyZXEpKTsKPiA+Pj4+PiAgIH0KPiA+Pj4+PiAgIHZvaWQgZ2Vu Nl9ycHNfaWRsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPj4+Pj4KPiA+ Pj4+WWVhaCBJIHRoaW5rIHRoaXMgaXMgZmluZSAobWF5IG5lZWQgYSByZWJhc2UgdGhvdWdoLCB5 b3UgY2FuIGtlZXAgbXkgci1iCj4gPj4+PmlmIHlvdSBkbyB0aGF0IGluIGNhc2UgSmFuaSBkb2Vz bid0IHdhbnQgdG8gZGVhbCB3aXRoIHRoZSBtZXJnZSBjb25mbGljdHMpLgo+ID4+Pj4KPiA+Pj4+ UmV2aWV3ZWQtYnk6IEplc3NlIEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgo+ID4+ PlRoZSByZW1vdmFsIG9mIHRoZSBzdGVwcGluZyBjaGVjayBpcyBzdGlsbCBjb25mdXNpbmcgbWUg ZXZlbiBpZiB0aGUKPiA+Pj5yZXN0IHdvdWxkIGJlIE9LLgo+ID4+Pgo+ID4+U3RlcHBpbmcgY2hl Y2sgd2FzIGFkZGVkIGxhdGVzdCBCWVQgcmVsZWFzZS4gT24gb2xkZXIgQllUIHN0ZXBwaW5nLCBX ZSB1c2VkIHRvIHdhaXQgZm9yIHB1bml0IHRvIGdyYW50IHRoZSBmcmVxIGluIEdUIElkbGUgY2Fz ZSwgKG1vc3Qgb2YgdGhlIGNhc2VzIHB1bml0IGlzIHRpbWluZyBvdXQgOiggKQo+ID4+V2Ugbm93 IG1ha2UgdGhlIGdmeCBjbG9jayBmb3JjZSBhcHBseSB0byBhbGwgVkxWIGFuZCB0aGVuIHJlcXVl c3QgdGhlIGZyZXEgdG8gUlBuIHRoaXMgc2hvdWxkIGJlIGdvb2QgZW5vdWdoIHRvIGdldCB2b2x0 YWdlIHRvIFZubi4KPiA+QnV0IHdlIHNob3VsZG4ndCBuZWVkIHRoZSBnZnggY2xvY2sgZm9yY2Ug Zm9yIHRoZSBsYXRlc3QgVkxWCj4gPnN0ZXBwaW5nKHMpLCBhbmQgd2UgY2VydGFpbmx5IGRpZG4n dCBkbyBpdCBiZWZvcmUuIFNvIHdoeSBkbwo+ID5pdCBub3c/Cj4gPgo+IEhpIFZpbGxlLCBUaGlz IGlzIGtlZXAgY29kZSBjb21tb24gYWNyb3NzIGFsbCB0aGUgVkxWIHN0ZXBwaW5nLiA6KQoKTWFr ZXMgc2Vuc2UgKGF0IGxlYXN0IHRvIG1lKSBidXQgcGxlYXNlIGFkZCB0aGlzIGV4cGxhbmF0aW9u IHRvIHRoZSBjb21taXQKbWVzc2FnZSB3aGVuIHJlc2VuZGluZyBzbyBpdCB3b24ndCBnZXQgbG9z dC4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29y cG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK