From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Preallocate request before access of the ring Date: Wed, 6 May 2015 12:06:03 +0200 Message-ID: <20150506100603.GN30184@phenom.ffwll.local> References: <1430323845-28906-1-git-send-email-yu.dai@intel.com> <55422611.7030902@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTP id E58DA6E174 for ; Wed, 6 May 2015 03:03:44 -0700 (PDT) Received: by wiun10 with SMTP id n10so15941926wiu.1 for ; Wed, 06 May 2015 03:03:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55422611.7030902@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBcHIgMzAsIDIwMTUgYXQgMDE6NTQ6NDFQTSArMDEwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMjkvMDQvMTUgMTc6MTAsIHl1LmRhaUBpbnRlbC5jb20gd3JvdGU6Cj4gPiBGcm9t OiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiA+IAo+ID4gVGhpcyBpcyB0byBhdm9pZCBi YWQgSU8gYWNjZXNzIGNhdXNlZCBieSB3cml0aW5nIE5PT1AgdG8gd3JhcCB0aGUKPiA+IHJpbmcg YnVmZmVyIHdoaWxzdCByaW5nIGlzIHVucGlubmVkLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBB bGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2xyYy5jIHwgNiArKystLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRp b25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ ID4gaW5kZXggNzMyZmQ2My4uM2U4ZmNmZCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYwo+ID4gQEAgLTgwMywxMiArODAzLDEyIEBAIHN0YXRpYyBpbnQgaW50ZWxfbG9naWNhbF9y aW5nX2JlZ2luKHN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmLAo+ID4gIAlpZiAocmV0 KQo+ID4gIAkJcmV0dXJuIHJldDsKPiA+ICAKPiA+IC0JcmV0ID0gbG9naWNhbF9yaW5nX3ByZXBh cmUocmluZ2J1ZiwgY3R4LCBudW1fZHdvcmRzICogc2l6ZW9mKHVpbnQzMl90KSk7Cj4gPiArCS8q IFByZWFsbG9jYXRlIHRoZSBvbHIgYmVmb3JlIHRvdWNoaW5nIHRoZSByaW5nICovCj4gPiArCXJl dCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2MocmluZywgY3R4KTsKPiA+ICAJaWYgKHJldCkKPiA+ ICAJCXJldHVybiByZXQ7Cj4gPiAgCj4gPiAtCS8qIFByZWFsbG9jYXRlIHRoZSBvbHIgYmVmb3Jl IHRvdWNoaW5nIHRoZSByaW5nICovCj4gPiAtCXJldCA9IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Mo cmluZywgY3R4KTsKPiA+ICsJcmV0ID0gbG9naWNhbF9yaW5nX3ByZXBhcmUocmluZ2J1ZiwgY3R4 LCBudW1fZHdvcmRzICogc2l6ZW9mKHVpbnQzMl90KSk7Cj4gPiAgCWlmIChyZXQpCj4gPiAgCQly ZXR1cm4gcmV0Owo+IAo+IFJldmlld2VkLWJ5OiBEYXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25A aW50ZWwuY29tPgo+IAo+IHdpdGggaW5wdXQgYWxzbyBmcm9tIEpvaG4gSGFycmlzb24gPGpvaG4u Yy5oYXJyaXNvbkBpbnRlbC5jb20+LCB3aG8KPiB3b3VsZCBsaWtlIHRvIHBvaW50IG91dCB0aGF0 IHRoaXMgd2lsbCBiZSBzdXBlcmNlZGVkIGJ5IHRoZSBBbnRpLU9MUgo+IHBhdGNoZXMgYWxyZWFk eSBwb3N0ZWQuIChJbiB0aGF0IG1vZGVsLCB0aGUgcmVxdWVzdCB3aWxsIGJlIGFsbG9jYXRlZAo+ IG11Y2ggZWFybGllciwgYW5kIHBhc3NlZCBhcm91bmQgZXhwbGljaXRseSByYXRoZXIgdGhhbiBk YW5nbGluZyBmcm9tIHRoZQo+IGNvbnRleHQpLgoKRG8gd2UgbmVlZCB0aGlzIGZvciBleGVjbGlz dCBpbiBnZW5lcmFsLCBpLmUuIGNjOiBzdGFibGU/IFdoZXJlJ3MgdGhlIGJ1ZwpyZXBvcnQvaWd0 IHRlc3RjYXNlPwoKRm9yIHNlcmlvdXMtbG9va2luZyBidWdzIHBsZWFzZSBhZGQgbW9yZSBkZXRh aWxzIGxpa2UgdGhhdCB0byB0aGUgY29tbWl0Cm1lc3NhZ2UsIG90aGVyd2lzZSBtYWludGFpbmVy cyBoYXZlIG5vIGlkZWEgd2hlcmUgdG8gYXBwbHkgYSBwYXRjaC4KClRoYW5rcywgRGFuaWVsCi0t IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=